On 2/4/2011 1:27 AM, Martin Pool wrote:
> On 4 February 2011 10:34, Robert Collins <email address hidden> wrote:
>> Perhaps you could just set pipefile in Makefile ?
>
> s//pipefail
>
> This would make it bash-specific, and we're probably generally not
> running bash, and it would need to be done on the same line, since
> Make runs each line in a separate process. But otherwise yes.
>
> The thing is if we make it exit nonzero on failure, we should not need
> to have a pipeline at all, as far as I can see. Just emit subunit to
> stdout and pqm should be able to use that both for the progress
> display and to send to the user if it fails.
>
As I recall, wasn't the original issue that the subunit-foo that we were
running at the end of the pipe didn't exit non-zero for failing tests vs
corrupted stream?
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 2/4/2011 1:27 AM, Martin Pool wrote:
> On 4 February 2011 10:34, Robert Collins <email address hidden> wrote:
>> Perhaps you could just set pipefile in Makefile ?
>
> s//pipefail
>
> This would make it bash-specific, and we're probably generally not
> running bash, and it would need to be done on the same line, since
> Make runs each line in a separate process. But otherwise yes.
>
> The thing is if we make it exit nonzero on failure, we should not need
> to have a pipeline at all, as far as I can see. Just emit subunit to
> stdout and pqm should be able to use that both for the progress
> display and to send to the user if it fails.
>
As I recall, wasn't the original issue that the subunit-foo that we were
running at the end of the pipe didn't exit non-zero for failing tests vs
corrupted stream?
John
=:->
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org/
MFxsACgkQJdeBCY SNAANr+ gCbBDDhwaw4Ea3X Rm9iZ03abzfm XNvB+OKznws/ uxw9MI5jqQi
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAk1
XOAAnRRe/
=uF45
-----END PGP SIGNATURE-----