Comment 1 for bug 611037

Revision history for this message
John A Meinel (jameinel) wrote :

I also saw a fair amount of time spent before the 'Build phase: adding file contents' was displayed. It is also possible that it is spending a lot of time trying to stat all 70k files before it decides whether or not there is going to be a file that is in conflict. Again, it should be possible to notice that a directory is not present, and thus we don't need to check all possible files underneath that dir.

I don't have profiles to specifically support this, but I did do a breakin during the post-build phase and it trapped on 'isdir()'.

ISTR that some of the os.path functions actually do multiple stats. (maybe it was just us doing os.path.isdir(), os.path.isfile(), etc.)

We might want to fix the _delete_any code to do a stat and check if it even exists first.