Comment 4 for bug 594155

Revision history for this message
John Szakmeister (jszakmeister) wrote : Re: [Bug 594155] Re: bzr co attempts to check .bzr/branch/branch-format when using a smart server

On Mon, Jun 14, 2010 at 9:56 PM, Robert Collins
<email address hidden> wrote:
> John, a few notes:
>  - bzr is not yet VFS free - the smart server protocol only expresses a subset of the operations that can take place.

You know, I remember looking at the smart server code and thinking "it
doesn't look like everything is here", now that you mention it.

>  - I don't think the behaviour you're seeing is by design, we can certainly look at changing it.

That would be awesome. I did spend some time trying to track down the
issue. Should the code ever be calling
BzrDir.open_from_transport(self.root_transport, _server_formats=False)
when root_transport is remote?

>  - even if changed, because we're not VFS free, you'll still get VFS requests coming into the smart server - but you could choose to disable that entirely, and we can work on making more operations VFS free.

That would be great too. I'm obviously less familiar with the bzr
internals, so any tips on where to go with this would be useful.

BTW, I think bug #262366 is related to this, now that you changed the
description. :-)