Comment 1 for bug 475501

Revision history for this message
Vincent Ladeuil (vila) wrote :

Thanks for working on this !

Would you mind doing a merge proposal so we can better track your patch ?
A couple of comments in the mean time:

The _save() docstring is out of date: obviously this is used outside of tests now,

Can you add tests to:
- check that the file is created with the right umask,
- check that we issue the warning if not (and mention the mode bits in the warning)

I'm not sure about how to address that concern on windows, but at least to start we may not want to
do a check there if there is no way to make it succeeds...

Don't hesitate to bring the topic on the mailing list where we'll get more feedback.