"Committing to: ..." message should include thread name

Bug #242824 reported by Andrew Bennetts
2
Affects Status Importance Assigned to Milestone
Loom
Triaged
Medium
Unassigned

Bug Description

It would be good if "bzr commit" in a thread reported which thread it was committing to. bzr itself already reports which branch it is committing to, this is just an extension of that.

At the moment the output looks like:

$ bzr ci -m "Fix test failures."
Committing to: /home/andrew/warthogs/bzr/push-improvement-loom/
modified bzrlib/tests/test_selftest.py
Committed revision 3467.

I would like something more like:

Committing to: 'old-hpss-branch-implementation-test' in /home/andrew/warthogs/bzr/push-improvement-loom/
modified bzrlib/tests/test_selftest.py
Committed revision 3467.

The reason why this is useful is that if a commit is made in the wrong location, then it immediately becomes obvious, which allows the user to uncommit immediately to undo the mistake (and prevents them from unknowingly doing further commits on the wrong thread).

Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 242824] [NEW] "Committing to: ..." message should include thread name

 importance medium
 status triaged

Changed in bzr-loom:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
John A Meinel (jameinel) wrote :

As an interesting workaround, you might configure your shell to show you "bzr nick" of where you are working. Because that will show you the name of the loom you are working on. You can do it in bash with something like:

PS1='\u@\h \w {$(bzr nick 2>/dev/null)}\n\$ '

That gives a 2-line prompt which looks like:

jameinel@host ~/working/directory {nick}
$ <your command here>

I have mine tweaked a bit to not show nick if I'm not in a directory, and to color the whole thing as I like it.

That would actually give you the information *before* you commit, rather than after.

Just a thought.

Revision history for this message
Andrew Bennetts (spiv) wrote :

John, that is an interesting workaround. In my case I'd want it to not show the nick if the branch wasn't a loom, or perhaps just if the nick is different to the basename of the branch root directory.

Fixing this bug would wholly satisfy me though, without the need to clutter my prompt or to figure out the right magic incantations to do so efficiently :)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.