OpenStack Compute (nova)

image_ref updated too early for rebuild

Bug #997245 reported by Chris Behrens
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Chris Behrens
OpenStack Compute (nova) 2012.2 "folsom"

Bug Description

The image_ref is updated immediately in the DB in compute/api on a rebuild. This causes us to lose the original image_ref and when we send a usage notification in the compute manager, we're sending one for the new image, not the old.

We shouldn't use the DB to pass the new image_ref this way... we should send it over RPC and update it on the manager side.

Chris Behrens (cbehrens)
Changed in nova:
assignee: nobody → Chris Behrens (cbehrens)
importance: Undecided → High
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/7282

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/7282
Committed: http://github.com/openstack/nova/commit/55e6021ce36b2f2d4ef9222252b9ab784f67d9f7
Submitter: Jenkins
Branch: master

commit 55e6021ce36b2f2d4ef9222252b9ab784f67d9f7
Author: Chris Behrens <email address hidden>
Date: Wed May 9 19:20:46 2012 +0000

    Defer image_ref update to manager on rebuild

    We shouldn't update the DB and use it for passing the new image_ref for
    a rebuild. This causes a usage exists notification for the new image
    instead of the old... and technically the new image is not accurate
    until we shutdown the old instance and try building the new one..

    Fixes bug 997245

    Change-Id: Ia4bd4b8af90080a11875d9ee56661286bc3f5593

Changed in nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/7289

Changed in nova:
status: Fix Committed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/7289
Committed: http://github.com/openstack/nova/commit/b5db5a346f9916ecdd630284f7596ea762bf1a5e
Submitter: Jenkins
Branch: master

commit b5db5a346f9916ecdd630284f7596ea762bf1a5e
Author: Chris Behrens <email address hidden>
Date: Wed May 9 21:09:33 2012 +0000

    API does need new image_ref on rebuild immediately.

    This restores the DB update for image_ref immediately on rebuild, but
    passes the old image_ref to the manager for use with instance.exists
    notification.

    Fixes the fix for bug 997245

    Change-Id: I8cf6a8759e8fe605bb023048a320b15eee3bcd80

Changed in nova:
status: In Progress → Fix Committed
Devin Carlen (devcamcar)
Changed in nova:
milestone: none → folsom-1
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.