QueueDraw is very expensive
Bug #994884 reported by
Michal Hruby
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Nux |
Fix Released
|
Undecided
|
Andrea Azzarone | ||
2.0 |
Fix Committed
|
Undecided
|
Unassigned | ||
Unity |
Fix Released
|
Undecided
|
Unassigned | ||
nux (Ubuntu) |
Fix Released
|
High
|
Andrea Azzarone | ||
Precise |
Fix Released
|
High
|
Unassigned | ||
unity (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Precise |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Test Case]
Performance fix - only way of testing is performing the benchmarking steps again to check if there is improvement.
[Regression Potential]
No obvious regression potential.
Original description:
I've been running a callgrind session trying to figure out how we could speed up opening the dash and it turned out that especially the first time the dash is opened, we spend more than 25% of time in QueueDraw - see the attached callgrind profile (best viewed with kcachegrind).
Attaching also a simple unity patch that was used to collect the data + the command line was `valgrind --tool=callgrind --instr-atstart=no --collect-
Related branches
lp://staging/~azzar1/nux/fix-994884
- Michal Hruby (community): Approve
- Tim Penhey (community): Approve
-
Diff: 130 lines (+51/-2)5 files modifiedNux/Area.cpp (+1/-0)
Nux/ProgramFramework/TestView.cpp (+7/-0)
Nux/ProgramFramework/TestView.h (+4/-0)
Nux/View.cpp (+4/-2)
tests/gtest-nux-view.cpp (+35/-0)
Changed in nux: | |
assignee: | Gord Allott (gordallott) → Andrea Azzarone (andyrock) |
status: | Confirmed → In Progress |
affects: | nux → nux (Ubuntu) |
Changed in nux: | |
status: | New → In Progress |
assignee: | nobody → Andrea Azzarone (andyrock) |
Changed in nux: | |
status: | In Progress → Fix Committed |
Changed in nux (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in unity: | |
status: | New → Invalid |
Changed in unity: | |
milestone: | none → 6.0 |
status: | Invalid → Fix Committed |
Changed in nux: | |
status: | Fix Committed → Fix Released |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in nux (Ubuntu Precise): | |
status: | New → In Progress |
Changed in nux (Ubuntu): | |
importance: | Undecided → High |
Changed in nux (Ubuntu Precise): | |
importance: | Undecided → High |
description: | updated |
description: | updated |
Changed in unity (Ubuntu): | |
status: | New → Fix Released |
Changed in unity (Ubuntu Precise): | |
status: | New → Fix Released |
To post a comment you must log in.
I think the dash opening slowly on some machines might be because Unity allocates far too much memory in doing so, which can take quite some time. See bug 982434.