OpenStack Compute (nova)

xensm volume driver: backend_add broken

Bug #988596 reported by Renuka Apte
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Renuka Apte
OpenStack Compute (nova) 2012.2 "folsom"

Bug Description

Tried to add a backend of type nfs. Volume driver crashes on add.
Reverting 77495cfe fixes it.

The logic for adding backends was written in a way that if the Storage repository (SR) needs to be created, it will not have a uuid associated with it. The uuid is provided by Xen when the SR is first created. This probably changed with 77495cfe.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/7288

Changed in nova:
assignee: nobody → Renuka Apte (renukaapte)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/7953

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/7953
Committed: http://github.com/openstack/nova/commit/9e337dac2960bbe8eaa4fbe3a8e5ca3e5e228936
Submitter: Jenkins
Branch: master

commit 9e337dac2960bbe8eaa4fbe3a8e5ca3e5e228936
Author: Renuka Apte <email address hidden>
Date: Tue May 29 11:45:57 2012 -0700

    Revert "Fix nova-manage backend_add with sr_uuid"

    Fixes bug 988596

    Change 77495cfe breaks storage manager, as it makes a
    wrong assumption about nova-manage. The sr-uuid must be
    generated and provided by the xenapi storage manager.

    When the volume service is started, SM volume driver will
    create a new SR for everything that does not have an
    existing sr_uuid and will populate the db with the result.
    It will only introduce the SRs that do have one. The introduce
    will work only if the uuid provided is something SM understands.

    This partially reverts commit 77495cfed17f12f225e11fbc10e0f8db516dadf2.
    Changes in db are left intact.

    Change-Id: I8405ac905a15f829f704951b94297f3b6f6c0a29

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-2 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.