red x's on APRV 0 votes

it's due to 2 things
1) any user with permissions to set a score for a given category will have that score recorded in the DB on review publish even if it is 0 and no change from the starting value
2) gerrit makes any category score retrieved from the DB that matches the category min score with a rejected flag in the UI

Since the approved category in the openstack gerrit was created with (min, max) of (0, 1), this means any time a core reviewer reviews a change but isn't the person to set the 'Approved' category to 1, then it will appear in the UI that they rejected the changed.

options to solve:
1) change approved category to go from -1 to +1, so -1 becomes the new min
2) prevent default scores/no scores from being recorded
3) add an additional test along with matching minimum value

Option 1 only requires a DB update and a service restart

Other options require code changes to gerrit and require consideration as to whether they are acceptable upstream.

I think Option 1 is ruled out, this is from Openstack's Gerrit server:

mysql> select * from approval_categories where category_id='VRIF'\G
*************************** 1. row ***************************
            name: Verified
abbreviated_name: V
        position: 0
   function_name: MaxWithBlock
  copy_min_score: N
     category_id: VRIF
1 row in set (0.00 sec)

mysql> select * from approval_category_values where category_id='VRIF'\G
*************************** 1. row ***************************
       name: Fails
category_id: VRIF
      value: -1
*************************** 2. row ***************************
       name: No score
category_id: VRIF
      value: 0
*************************** 3. row ***************************
       name: Verified
category_id: VRIF
      value: 1
3 rows in set (0.00 sec)

oh crap, ignore me. I read it as VRIF was the problem for some reason :)

Link to fix
https://review.openstack.org/gitweb?p=openstack-ci/gerrit.git;a=commit;h=667798c30026c22154e609553d20e6d257d8d0de

Under review upstream:
https://gerrit-review.googlesource.com/#/c/35371/

Fix proposed to branch: openstack/2.4.1
Review: https://review.openstack.org/8548

Reviewed: https://review.openstack.org/8548
Committed: http://github.com/openstack-ci/gerrit/commit/804a4de4fd27dcf4869237244bc2a29f763c620b
Submitter: Jenkins
Branch: openstack/2.4.1

commit 804a4de4fd27dcf4869237244bc2a29f763c620b
Author: Darragh Bailey <email address hidden>
Date: Fri Apr 20 12:43:07 2012 +0100

    Fix category block status without negative score

    Categories without blocking or approval scores will
    result in the blocking/approved image appearing
    in the category column after changes are merged
    should the score by the reviewer match the minimum
    or maximum value respectively.

    Add check to ignore "No Score" values of 0.

    Fixes bug 980927

    Change-Id: I29d8d6653a90cd8f80dcb2955fac90662142042e

Fix proposed to branch: openstack/2.4.2
Review: https://review.openstack.org/9132

Reviewed: https://review.openstack.org/9132
Committed: http://github.com/openstack-ci/gerrit/commit/8b3e6cfe022f9b66e2ac492f0b5d6ad5b7db06a8
Submitter: Jenkins
Branch: openstack/2.4.2

commit 8b3e6cfe022f9b66e2ac492f0b5d6ad5b7db06a8
Author: Darragh Bailey <email address hidden>
Date: Fri Apr 20 12:43:07 2012 +0100

    Fix category block status without negative score

    Categories without blocking or approval scores will
    result in the blocking/approved image appearing
    in the category column after changes are merged
    should the score by the reviewer match the minimum
    or maximum value respectively.

    Add check to ignore "No Score" values of 0.

    Fixes bug 980927

    Change-Id: I29d8d6653a90cd8f80dcb2955fac90662142042e

Fix proposed to branch: openstack/2.4.4
Review: https://review.openstack.org/35438

Reviewed: https://review.openstack.org/35438
Committed: http://github.com/openstack-infra/gerrit/commit/7cf064c398323647a5c1f0d08e9323059321fea7
Submitter: Jenkins
Branch: openstack/2.4.4

commit 7cf064c398323647a5c1f0d08e9323059321fea7
Author: Darragh Bailey <email address hidden>
Date: Fri Apr 20 12:43:07 2012 +0100

    Fix category block status without negative score

    Categories without blocking or approval scores will
    result in the blocking/approved image appearing
    in the category column after changes are merged
    should the score by the reviewer match the minimum
    or maximum value respectively.

    Add check to ignore "No Score" values of 0.

    Fixes bug 980927

    Change-Id: I29d8d6653a90cd8f80dcb2955fac90662142042e