unity-2d

[UIFe] Use average color of wallpaper to tint launcher/dash/panel/hud

Bug #960194 reported by Gerry Boland
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity-2d
Fix Released
Low
Unassigned
unity-2d 5.8
unity-2d (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Unity use the average colour of the wallpaper as a tint on the launcher, panel, dash and hud.

To narrow the delta between 2d and 3d, we have:
https://code.launchpad.net/~fboucault/unity-2d/wallpaper_average_color/+merge/98406
which adds this visual change.

Visual change can be seen with these images:
before: http://ubuntuone.com/5LFncDVm6PaaptVfvGHpgj
after: http://ubuntuone.com/5B0APYEQ2zpR9CAJ1mmEIC

This code is tested using unit tests, which read the wallpaper image and generate the average color.

See original description

Related branches

lp://staging/~unity-2d-team/unity-2d/wallpaper-based-tinting
Michał Sawicz: Approve
Jason Smith: Pending requested
John Lea: Pending (design) requested
Diff: 704 lines (+498/-4)
15 files modified
libunity-2d-private/Unity2d/plugin.cpp (+6/-0)
libunity-2d-private/src/CMakeLists.txt (+2/-0)
libunity-2d-private/src/colorizeeffect.cpp (+92/-0)
libunity-2d-private/src/colorizeeffect.h (+60/-0)
libunity-2d-private/src/imageutilities.cpp (+93/-0)
libunity-2d-private/src/imageutilities.h (+57/-0)
libunity-2d-private/src/panelpalettemanager.cpp (+8/-1)
libunity-2d-private/src/percentcoder.cpp (+1/-1)
libunity-2d-private/tests/CMakeLists.txt (+1/-0)
libunity-2d-private/tests/imageutilitiestest.cpp (+97/-0)
shell/Shell.qml (+3/-0)
shell/WallpaperColor.qml (+65/-0)
shell/common/Background.qml (+11/-0)
shell/dash/Dash.qml (+0/-1)
shell/launcher/Launcher.qml (+2/-1)
lp://staging/unity-2d
lp://staging/ubuntu/precise-proposed/unity-2d
Gerry Boland (gerboland)
Changed in unity-2d:
milestone: none → 5.8
importance: Undecided → Low
status: New → Confirmed
Gerry Boland (gerboland)
description: updated
Revision history for this message
Gerry Boland (gerboland) wrote :

ML requests:
https://lists.ubuntu.com/archives/ubuntu-translators/2012-March/005233.html
https://lists.ubuntu.com/archives/ubuntu-doc/2012-March/016429.html

Gerry Boland (gerboland)
description: updated
Revision history for this message
Adam Conrad (adconrad) wrote :

Once all the concerns from the MP are sorted (testsuite not working with LANG=C, design concerns about color, merge conflicts cleaned up), this has a rubber stamp from me for the freeze exception.

(Personally, I actually like that unity-2d looks different, but I understand the rationale for having them look the same :P)

Revision history for this message
Gerry Boland (gerboland) wrote :

Hi Adam,
yes the MR history didn't look too good, did it. It was pretty old.
I can confirm that Design approves of this change (the author worked directly with Design), that the test suite passes & there are no merge conflicts. Original reviewer has commented briefly as much.

(Personally yes, I preferred the old way too)
-Gerry

Revision history for this message
Jeremy Bícha (jbicha) wrote :

I'm explicitly +1'ing this from the Docs Team, but any changes that make Unity 2D more like Unity 3D are awesome! (Currently we only use 3D for screenshots.)

Revision history for this message
Kate Stewart (kate.stewart) wrote :

jbicha_ confirmed they are using Unity-3D for the screen shots, so this change is fine from their perspective.
Based on that and the comments from Gerry, consider this approved.

Łukasz Zemczak (sil2100)
Changed in unity-2d:
status: Confirmed → Fix Committed
Didier Roche-Tolomelli (didrocks)
Changed in unity-2d:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-2d - 5.8.0-0ubuntu1

---------------
unity-2d (5.8.0-0ubuntu1) precise-proposed; urgency=low

  * New upstream release
    - Loss of DBus connection with active Dash/Hud results in broken panel
      (LP: #953168)
    - [launcher] super key and number from _keypad_ doesn't work (LP: #750514)
    - [dash] Home lens state not reset if dash closed & reopened (LP: #948299)
    - HUD is silent to screen readers (LP: #949445)
    - Use title case capitalization "Lock to Launcher" & "Unlock from
      Launcher" (LP: #949636)
    - tiles highlight incorrect, highlight only visible at edge (LP: #953403)
    - [UIFe] Use average color of wallpaper to tint launcher/dash/panel/hud
      (LP: #960194)
  * debian/control:
    - build-dep on latest nux and unity-core
 -- Didier Roche <email address hidden> Fri, 23 Mar 2012 15:33:38 +0100

Changed in unity-2d (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.