OpenStack Compute (nova)

Improve rpc RemoteError to return original exception args

Bug #920705 reported by Dean Troyer on 2012-01-23

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	Wishlist	Alex Meade	OpenStack Compute (nova) 2012.2 "folsom"

Bug Description

The original exception information returned in an rpc.RemoteError is reduced to strings. We need a way to return the original exception args intact to the calling routines.

Revision history for this message

Brian Waldon (bcwaldon) wrote on 2012-01-27:

Being able to return enough information to reconstruct the same exception on the other side of an rpc connection would be fantastic.

Changed in nova:
status:	New → Triaged
importance:	Undecided → Wishlist

Brian Waldon (bcwaldon) on 2012-02-26

Changed in nova:
assignee:	nobody → Brian Waldon (bcwaldon)

Brian Waldon (bcwaldon) on 2012-02-29

Changed in nova:
status:	Triaged → In Progress

Brian Waldon (bcwaldon) on 2012-03-12

Changed in nova:
assignee:	Brian Waldon (bcwaldon) → Alex Meade (alex-meade)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-03-23: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5749

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-04-10: Fix merged to nova (master)

Reviewed: https://review.openstack.org/5749
Committed: http://github.com/openstack/nova/commit/a0150a4d9e751ec222221558dfe89a66b0c118ab
Submitter: Jenkins
Branch: master

commit a0150a4d9e751ec222221558dfe89a66b0c118ab
Author: Alex Meade <email address hidden>
Date: Wed Mar 21 19:13:16 2012 +0000

Add the serialization of exceptions for RPC calls.

    This change uses json to serialize an exception so that it can be sent
    through RPC calls to be reconstructed on the other side. The traceback is added
    to the exception message. If recreating the exception fails for whatever reason
    then a RemoteError is created containing all of the exception information.

Adds flag 'allowed_rpc_exception_modules' to prevent dangerous modules from
being accessed and allowing arbitrary code to be run.

Fixes bug 920705
Fixes bug 940500

Change-Id: Ife3b64b19fe8abbc730184d4ee7d9fcabfd29db3

Changed in nova:
status:	In Progress → Fix Committed

Devin Carlen (devcamcar) on 2012-05-22

Changed in nova:
milestone:	none → folsom-1

Thierry Carrez (ttx) on 2012-05-23

Changed in nova:
status:	Fix Committed → Fix Released

Thierry Carrez (ttx) on 2012-09-27

Changed in nova:
milestone:	folsom-1 → 2012.2

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.