[desktop] Gallery does not display photos in sub folders
Bug #907870 reported by
Pat McGowan
This bug affects 6 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
gallery-app |
Fix Released
|
High
|
Arthur Mello | ||
gallery-app (Ubuntu) |
Fix Released
|
High
|
Arthur Mello |
Bug Description
It would be nice if
1) all photos in sub folders of the Pictures folder were discovered and displayed
2) an Album or Event was created for each existing sub folder
Related branches
lp://staging/~artmello/gallery-app/display_photos_in_sub_folders
- Gustavo Pichorim Boiko (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 245 lines (+176/-3)7 files modifiedsrc/album/CMakeLists.txt (+3/-0)
src/media/media-monitor.cpp (+38/-3)
src/media/media-monitor.h (+1/-0)
src/medialoader/CMakeLists.txt (+1/-0)
tests/unittests/CMakeLists.txt (+1/-0)
tests/unittests/mediamonitor/CMakeLists.txt (+36/-0)
tests/unittests/mediamonitor/tst_mediamonitor.cpp (+96/-0)
lp://staging/~bfiller/gallery-app/multiple-bug-fixes
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 2286 lines (+380/-1082)44 files modifiedCMakeLists.txt (+0/-1)
debian/control (+0/-3)
rc/qml/AlbumViewer/AlbumInternals/FramePortrait.qml (+16/-0)
rc/qml/AlbumsOverview.qml (+1/-0)
rc/qml/Components/MediaGrid.qml (+19/-0)
rc/qml/MediaViewer/PhotoViewerDelegate.qml (+21/-8)
rc/qml/MediaViewer/ZoomablePhotoComponent.qml (+2/-1)
rc/qml/OrganicView/OrganicMediaList.qml (+24/-0)
rc/qml/Utility/PhotosToolbarActions.qml (+1/-0)
src/album/CMakeLists.txt (+3/-0)
src/gallery-application.cpp (+2/-5)
src/gallery-manager.cpp (+0/-53)
src/gallery-manager.h (+0/-6)
src/media/media-monitor.cpp (+38/-3)
src/media/media-monitor.h (+1/-0)
src/media/media-source.cpp (+19/-4)
src/medialoader/CMakeLists.txt (+1/-4)
src/medialoader/gallery-standard-image-provider.cpp (+11/-49)
src/medialoader/gallery-standard-image-provider.h (+0/-4)
src/medialoader/gallery-thumbnail-image-provider.cpp (+0/-102)
src/medialoader/gallery-thumbnail-image-provider.h (+0/-59)
src/medialoader/preview-manager.cpp (+0/-423)
src/medialoader/preview-manager.h (+0/-87)
src/photo/photo-caches.cpp (+3/-0)
src/photo/photo.cpp (+2/-17)
src/video/video.cpp (+3/-2)
tests/autopilot/gallery_app/tests/__init__.py (+4/-1)
tests/autopilot/gallery_app/tests/test_albums_view.py (+29/-1)
tests/autopilot/gallery_app/tests/test_events_view.py (+26/-1)
tests/autopilot/gallery_app/tests/test_photo_viewer.py (+2/-2)
tests/autopilot/gallery_app/tests/test_photos_view.py (+16/-7)
tests/unittests/CMakeLists.txt (+1/-1)
tests/unittests/gallerystandardimageprovider/CMakeLists.txt (+0/-2)
tests/unittests/gallerystandardimageprovider/tst_gallerystandardimageprovidertest.cpp (+0/-5)
tests/unittests/gallerythumbnailimageprovider/CMakeLists.txt (+0/-34)
tests/unittests/gallerythumbnailimageprovider/tst_gallerythumbnailimageprovider.cpp (+0/-54)
tests/unittests/mediamonitor/CMakeLists.txt (+36/-0)
tests/unittests/mediamonitor/tst_mediamonitor.cpp (+96/-0)
tests/unittests/mediaobjectfactory/CMakeLists.txt (+0/-3)
tests/unittests/stubs/gallery-manager_stub.cpp (+0/-9)
tests/unittests/stubs/gallery-standard-image-provider_stub.cpp (+1/-9)
tests/unittests/stubs/gallery-thumbnail-image-provider_stub.cpp (+0/-55)
tests/unittests/stubs/preview-manager_stub.cpp (+0/-65)
tests/unittests/video/tst_video.cpp (+2/-2)
lp://staging/~artmello/gallery-app/gallery-app-multiple-bug-fixes
- Bill Filler (community): Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 2348 lines (+394/-1087)44 files modifiedCMakeLists.txt (+0/-1)
debian/control (+0/-3)
rc/qml/AlbumViewer/AlbumInternals/FramePortrait.qml (+16/-0)
rc/qml/AlbumsOverview.qml (+1/-0)
rc/qml/Components/MediaGrid.qml (+19/-0)
rc/qml/MediaViewer/PhotoViewerDelegate.qml (+21/-8)
rc/qml/MediaViewer/ZoomablePhotoComponent.qml (+2/-1)
rc/qml/OrganicView/OrganicMediaList.qml (+24/-0)
rc/qml/Utility/PhotosToolbarActions.qml (+1/-0)
src/album/CMakeLists.txt (+3/-0)
src/gallery-application.cpp (+2/-5)
src/gallery-manager.cpp (+0/-53)
src/gallery-manager.h (+0/-6)
src/media/media-monitor.cpp (+57/-7)
src/media/media-monitor.h (+4/-1)
src/media/media-source.cpp (+19/-4)
src/medialoader/CMakeLists.txt (+1/-4)
src/medialoader/gallery-standard-image-provider.cpp (+11/-49)
src/medialoader/gallery-standard-image-provider.h (+0/-4)
src/medialoader/gallery-thumbnail-image-provider.cpp (+0/-102)
src/medialoader/gallery-thumbnail-image-provider.h (+0/-59)
src/medialoader/preview-manager.cpp (+0/-423)
src/medialoader/preview-manager.h (+0/-87)
src/photo/photo-caches.cpp (+3/-0)
src/photo/photo.cpp (+2/-17)
src/video/video.cpp (+3/-2)
tests/autopilot/gallery_app/tests/__init__.py (+4/-1)
tests/autopilot/gallery_app/tests/test_albums_view.py (+29/-1)
tests/autopilot/gallery_app/tests/test_events_view.py (+26/-1)
tests/autopilot/gallery_app/tests/test_photo_viewer.py (+2/-2)
tests/autopilot/gallery_app/tests/test_photos_view.py (+16/-7)
tests/unittests/CMakeLists.txt (+1/-1)
tests/unittests/gallerystandardimageprovider/CMakeLists.txt (+0/-2)
tests/unittests/gallerystandardimageprovider/tst_gallerystandardimageprovidertest.cpp (+0/-5)
tests/unittests/gallerythumbnailimageprovider/CMakeLists.txt (+0/-34)
tests/unittests/gallerythumbnailimageprovider/tst_gallerythumbnailimageprovider.cpp (+0/-54)
tests/unittests/mediamonitor/CMakeLists.txt (+36/-0)
tests/unittests/mediamonitor/tst_mediamonitor.cpp (+88/-0)
tests/unittests/mediaobjectfactory/CMakeLists.txt (+0/-3)
tests/unittests/stubs/gallery-manager_stub.cpp (+0/-9)
tests/unittests/stubs/gallery-standard-image-provider_stub.cpp (+1/-9)
tests/unittests/stubs/gallery-thumbnail-image-provider_stub.cpp (+0/-55)
tests/unittests/stubs/preview-manager_stub.cpp (+0/-65)
tests/unittests/video/tst_video.cpp (+2/-2)
lp://staging/~artmello/gallery-app/gallery-app-ignore_dot_directories
- PS Jenkins bot: Approve (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 47 lines (+15/-1)2 files modifiedsrc/media/media-monitor.cpp (+3/-1)
tests/unittests/mediamonitor/tst_mediamonitor.cpp (+12/-0)
Changed in goodhope: | |
milestone: | proto1 → proto2 |
Changed in goodhope: | |
milestone: | proto2 → alpha1 |
Changed in goodhope: | |
milestone: | alpha1 → beta1 |
summary: |
- Gallery does not display photos in sub folders + [desktop] Gallery does not display photos in sub folders |
Changed in goodhope: | |
milestone: | beta1 → final |
Changed in goodhope: | |
status: | New → Confirmed |
Changed in goodhope: | |
importance: | Medium → Low |
information type: | Private → Private Security |
information type: | Private Security → Public |
affects: | goodhope → gallery-app |
Changed in gallery-app: | |
milestone: | final → none |
Changed in gallery-app: | |
status: | Confirmed → In Progress |
Changed in gallery-app: | |
importance: | Low → High |
assignee: | nobody → Arthur Mello (artmello) |
tags: | added: desktop-touch |
Changed in gallery-app (Ubuntu): | |
status: | New → Fix Committed |
Changed in gallery-app: | |
status: | In Progress → Fix Committed |
Changed in gallery-app (Ubuntu): | |
importance: | Undecided → High |
assignee: | nobody → Arthur Mello (artmello) |
Changed in gallery-app: | |
milestone: | none → 14.03 |
Changed in gallery-app (Ubuntu): | |
milestone: | none → ubuntu-14.03 |
Changed in gallery-app: | |
status: | Fix Committed → Fix Released |
Changed in gallery-app: | |
status: | Confirmed → In Progress |
Changed in gallery-app (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in gallery-app: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Pat,
are you proposing this as a placeholder convenience for running Gallery on the desktop, or as a permanent feature? In the current design, events are tied to time so it's hard to see how we could make one event per folder in the current interface. But we could probably automatically generate albums from folders if you like.