-m and -f filter is not working

Easily reproducible, so confirming

Breaks functionality, marking as critical and target as 0.1 version

This patch solves this problem. -m and -f is now working. It also solves the problems with --stats in #84903.

Comment 1:
========

Can we simplify this ?

+def add_dict_value(dict, key, value):
+ if not dict.has_key(key):
+ dict[key] = 0
+ dict[key] += value
+ return dict

like

+def add_dict_value(dict, key):
+ if not dict.has_key(key):
+ dict[key] = 0
+ dict[key] += 1
+ return dict

Comment 2:
========

self.bugs = filter(lambda x,b=bug: int(x)!=int(b),self.bugs)

filter() returns list if the second parameter is not a string or tuple.

Checking the type of self.bugs:

self.bugs = set()

It is a set.

So is the fix is changing self.bugs from a set to a list ?

I can see an already existing similar thing just above the change

self.bugs = filter(minFilter, self.bugs)

so from this is initializing self.bugs to set() is incorrect (this will be a new bug i guess ? )

Note: update() member function is part of set and not list. We use it in the code for self.bugs. Also is set.update deprecated in python 2.5 ?

Pappan

Thanks a lot for your comments Pappan.
I added changed the patch to solve the two issues in your comment.

self.bugs is now a set().

Markus

Version three of this patch after some code-cleaning

Thanks a lot Markus.
------------------------------------------------------------
revno: 101
committer: Daniel Holbach <email address hidden>
branch nick: bughelper.main
timestamp: Mon 2007-03-05 13:45:56 +0100
message:
  Patches by Markus Korn <email address hidden> to fix bug 89726 and bug 89250
------------------------------------------------------------