Dash - when a file is dragged from the Dash (Dash home, file lens, or music lens) and dropped on a Launcher icon, the Dash should automatically close
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Released
|
Critical
|
John Lea | ||
Unity |
Fix Released
|
Medium
|
Brandon Schaefer | ||
5.0 |
Fix Released
|
Medium
|
Brandon Schaefer | ||
unity (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Precise |
Fix Released
|
Low
|
Unassigned |
Bug Description
[Test Case]
1. Open the dash
2. Open the file lens
3. Start dragging any file from the file lens to the Launcher
-> Dash should close once the file gets dragged over the Launcher
[Regression Potential]
No regression potential, trivial fix.
Original description:
When a file is dragged from the Dash (Dash home, file lens, or music lens) and dropped on a Launcher icon, the Dash should automatically close.
To Reproduce:
1. drag and drop a .png file from the file lens on to the Firefox icon in the Launcher
What currently incorrectly happens:
- the file loads in Firefox, but the Dash remains open so that the window the file has just opened into is hidden behind the Dash.
Correct desired functionality
- As soon as the user drops the file on the Firefox icon, the Dash should close with a 100ms fade
Related branches
- Thomi Richards (community): Approve
-
Diff: 89 lines (+23/-6)2 files modifiedlauncher/Launcher.cpp (+5/-2)
manual-tests/Dash.txt (+18/-4)
- Marco Trevisan (Treviño): Approve
-
Diff: 60 lines (+19/-3)2 files modifiedmanual-tests/Dash.txt (+14/-1)
plugins/unityshell/src/Launcher.cpp (+5/-2)
Changed in unity: | |
assignee: | nobody → John Lea (johnlea) |
tags: | added: onew udo |
Changed in unity: | |
assignee: | John Lea (johnlea) → nobody |
Changed in ayatana-design: | |
assignee: | nobody → John Lea (johnlea) |
importance: | Undecided → High |
status: | New → Fix Committed |
description: | updated |
Changed in unity: | |
milestone: | none → backlog |
status: | New → Triaged |
Changed in unity (Ubuntu): | |
status: | New → Triaged |
milestone: | none → later |
Changed in unity: | |
importance: | Undecided → Medium |
Changed in unity (Ubuntu): | |
importance: | Undecided → Medium |
tags: | added: udp |
Changed in ayatana-design: | |
status: | Fix Committed → Triaged |
Changed in unity: | |
assignee: | nobody → Jason Smith (jassmith) |
Changed in ayatana-design: | |
status: | Triaged → Fix Committed |
tags: | added: top5p |
Changed in ayatana-design: | |
importance: | High → Critical |
Changed in unity (Ubuntu): | |
milestone: | later → none |
Changed in unity: | |
milestone: | backlog → 5.10.0 |
status: | Triaged → In Progress |
Changed in unity (Ubuntu): | |
status: | Triaged → In Progress |
Changed in unity: | |
milestone: | 5.10.0 → 5.12.0 |
Changed in unity: | |
milestone: | 5.12.0 → 5.14.0 |
Changed in unity: | |
assignee: | Jason Smith (jassmith) → nobody |
status: | In Progress → Triaged |
Changed in unity (Ubuntu): | |
status: | In Progress → Confirmed |
Changed in unity: | |
assignee: | nobody → Brandon Schaefer (brandontschaefer) |
status: | Triaged → In Progress |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity: | |
milestone: | 5.14.0 → 6.0 |
Changed in unity (Ubuntu): | |
status: | Confirmed → Fix Committed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in unity (Ubuntu Precise): | |
importance: | Undecided → Low |
status: | New → In Progress |
description: | updated |
tags: |
added: verification-done removed: verification-needed |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
tags: |
added: reviewedbydesignq removed: udp |
sometimes I think you should leave well enough alone, this is one of those cases where the design is being overwrought
If the app being dropped on is open on that WS then the Dash already auto closes
If it's open on another WS or not at all then a simple click on the icon dismisses the Dash & raises the window
What this little changes is doing though is preventing users from doing multiple DnD from an open Dash
The potential loss isn't reflected in any gain from a user vs. design perspective