Increase resolution of 'Imported Image length' setting

Bug #854612 reported by Andy Finch
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenShot Video Editor
Fix Released
Medium
Unassigned

Bug Description

The Imported Image length setting in the preferences has a minimum limit of 1 second. It should be allowed to go to 0.1 or smaller, to make time lapse videos easier to produce, when used in combination with the 'Add To Timeline' feature.

Related branches

Andy Finch (fincha)
Changed in openshot:
milestone: none → 1.4.1
status: New → Confirmed
Revision history for this message
Jonathan Thomas (jonoomph) wrote :

Just a thought. If someone is doing a time-lapse, it's much more efficient to use the "Image Sequence" feature. It can go 1/60 of a second if needed, and is very simple to do, rather than adding each picture individually. As long as the images are named sequentially, such as "Image001.jpg", "Image002.jpg", etc...

Revision history for this message
Jonathan Thomas (jonoomph) wrote :

Thanks for the suggestion. I have added 2 digits of precision to the "Imported Image Length" preference

Changed in openshot:
importance: Undecided → Medium
status: Confirmed → Fix Committed
Revision history for this message
Jef Damen (jef-damen) wrote :

Thanks for changing the precision of the "Imported Image Length".
I just tested this new function by changing this value to 0,1 sec.
But after this changing I can't re-open the Preference window to chang it back to another value.
This error appears in the terminal:
-------
on_mnuPreferences_activate called with self.GtkImageMenuItem
Traceback (most recent call last):
  File "/home/jef/openshot/openshot/windows/MainGTK.py", line 1669, in on_mnuPreferences_activate
    preferences.PreferencesMgr(project=self.project, form=self)
  File "/home/jef/openshot/openshot/windows/preferences.py", line 94, in __init__
    self.valImageLength.set_value(float(self.form.settings.general["imported_image_length"]))
ValueError: invalid literal for float(): 0,10
------
It's also not possible to add pictures on the timeline.

Changed in openshot:
status: Fix Committed → Fix Released
Revision history for this message
Jonathan Thomas (jonoomph) wrote :

The regression has been fixed, and is now in the trunk.

Revision history for this message
Jonathan Thomas (jonoomph) wrote :

Hi Jef, can you test out the newest version (in the trunk or daily PPA: https://code.launchpad.net/~openshot.developers/+archive/daily) and see if the bug is fixed for you?

Thanks!
-Jonathan

Revision history for this message
Olivier Girard (eolinwen) wrote :
Revision history for this message
Jef Damen (jef-damen) wrote :

I just did a new installation of the development version like Cenwen explained in his link and it seems to be working again.
Thanks.
But what I don't understand is: what is the difference between always updating to the latest revision with"bzr pull lp:openshot" or with the daily development version?
If I get the latest revision (625, to fix this bug) with "bzr pull lp:openshot" it doesn't work. I should think that I could get it work in this way also.
By the way, how can I check my Local ? Wich commando do I have to use in the terminal?
Thanks for your great work guys.

Revision history for this message
Olivier Girard (eolinwen) wrote :

Strange that bzr pull lp:openshot" doesn't work and the daily development version yes. Normally, it should be.

Revision history for this message
Andy Finch (fincha) wrote :

Silly question, but after pulling the latest code from bazaar, are you changing into the folder where it was downloaded to and starting openshot.py? If you are just running the 'openshot' command it will use the installed version.

Revision history for this message
Jef Damen (jef-damen) wrote :

Andy, sorry it's hard to tell because I messed up a lot of things with installing Openshot .
In the past I installed the official version with Synaptic and I think I installed the development version (with bazaar) in my home directory.
The commando for the official version is "openshot %F" and I upgrade and start the development version with these commando's in a text file:
#!/bin/sh
cd
cd openshot
bzr pull lp:openshot
cd openshot
python openshot.py

I don't know that this can help you.

Revision history for this message
Jef Damen (jef-damen) wrote :

I just updated Openshot on another computer with Bazaar to the latest revision (630) and I don't have any problems over there.
So don't be awake tonight to think about the problem on my laptop, I will not :-)

Revision history for this message
Jonathan Thomas (jonoomph) wrote :

Thanks for the testing help. Looks like this fix is ready to be deployed.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.