Dash - reflections should be fixed on the centre of the viewport, *NOT* the centre of the entire page including occluded areas
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ayatana Design |
Fix Released
|
High
|
John Lea | ||
| Unity |
Fix Released
|
Medium
|
Gord Allott | ||
| unity (Ubuntu) |
Fix Released
|
Medium
|
Gord Allott | ||
Bug Description
Dash reflections should be fixed on the centre of the viewport, not the centre of the entire page including occluded areas.
This bug can be seen easily by opening up all the category headers in a large set of search results and scrolling to the bottom. For the search results at the very bottom of the scrollable page you will see that the distance their shadows are offset is too large.
Desired solution:
The lightsource that casts the shadows should always be centred in the middle of the viewable dash area. Therefore as the results scroll, the shadows should change position in real time. The search results in the four corners of the visible area should always have the largest shadow, the search results in the centre of the visible are should have the smallest shadows.
The shadows must always be calculated relative to the position of the search results in the *visible dash area*.
Related branches
- Jason Smith (community): Approve
- Andrea Cimitan (community): Approve
-
Diff: 144 lines (+37/-12)5 files modifiedplugins/unityshell/src/DashView.cpp (+7/-5)
plugins/unityshell/src/ResultViewGrid.cpp (+19/-7)
plugins/unityshell/src/ResultViewGrid.h (+6/-0)
plugins/unityshell/src/UBusMessages.h (+2/-0)
tests/CMakeLists.txt (+3/-0)
| Changed in ayatana-design: | |
| assignee: | nobody → John Lea (johnlea) |
| importance: | Undecided → Medium |
| importance: | Medium → High |
| status: | New → Fix Committed |
| tags: | added: onew udo |
| summary: |
- Dash - reflections should be fixed on the centre of the viewport, not + Dash - reflections should be fixed on the centre of the viewport, *NOT* the centre of the entire page including occluded areas |
| Changed in unity: | |
| importance: | Undecided → Medium |
| status: | New → Confirmed |
| Changed in unity (Ubuntu): | |
| importance: | Undecided → Medium |
| status: | New → Confirmed |
| Changed in unity: | |
| assignee: | nobody → Gord Allott (gordallott) |
| milestone: | none → 4.18.0 |
| Changed in unity (Ubuntu): | |
| assignee: | nobody → Gord Allott (gordallott) |
| Changed in unity: | |
| milestone: | 4.18.0 → 4.20.0 |
| Changed in unity: | |
| status: | Confirmed → Triaged |
| status: | Triaged → Fix Committed |
| Changed in unity (Ubuntu): | |
| status: | Confirmed → Fix Committed |
| Changed in ayatana-design: | |
| status: | Fix Committed → Fix Released |
| Changed in unity: | |
| status: | Fix Committed → Fix Released |
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in unity (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| John Lea (johnlea) wrote | #2 |
| tags: |
added: reviewedbydesigno removed: onew udo |
This bug was fixed in the package unity - 4.20.0-0ubuntu1
---------------
unity (4.20.0-0ubuntu1) oneiric; urgency=low
* New upstream release + cherry-pick:
- compiz crashed with SIGSEGV in PluginClassHand
CompWindow, 0>::get() (LP: #835259)
- dash does not scroll down during keyboard navigation (LP: #852506)
- compiz crashed with SIGSEGV in _XFreeEventCook
- compiz crashed with SIGSEGV in g_object_unref() (LP: #847512)
- compiz crashed with SIGSEGV in nux::WindowComp
(LP: #831678)
- compiz and X can disagree on the stacking order (LP: #845719)
- compiz crashed with SIGSEGV in unity::
(LP: #855252)
- CCSM crashes Unity (LP: #861643)
- compiz crashed with SIGSEGV in PrivateWindow:
(LP: #862115)
- Touch - When dragging a window with a 3 touch, dragging to the top
should show the maximize gesture preview. (LP: #750316)
- compiz crashed with SIGABRT in raise() (LP: #750386)
- Launcher - Spread should not affect the state of window (LP: #764673)
- [UIFe] Add system setting icon to Launcher (LP: #764744)
- compiz crashed with SIGABRT in raise() [Merely unchecking the Unity
plugin is enough to crash Compiz...] (LP: #823386)
- Launcher - does not hide if revealed from top 24px of the left edge of
the screen (LP: #835989)
- Clickable areas of previously active window remains on 'Show Desktop'
(LP: #836325)
- Cannot search for some apps in Dash (LP: #837075)
- Dash - Search box cursor not responding correctly to focus (LP: #839704)
- Multi-display: Application menu only showing on primary screen
(LP: #845212)
- Ellipsized values in size filter (LP: #851359)
- (oneiric) dash result expansions don't display icons (LP: #854615)
- run the wrong command if enter is hit before the view is refreshed
(LP: #856205)
- Java application windows cut-off/
(LP: #857201)
- compiz crashed with SIGSEGV in sigc::signal_
- Minimizing a window should switch focus to the windows underneath it
(breaks restore) (LP: #859885)
- Ratings filter allows ratings > 1.0 (LP: #861255)
- Serious Unity problem stuck in spread when dragging icons back to the
dash (LP: #862045)
- Must use hardware keyboard to perform search for applications in Unity
(LP: #739812)
- Files lens should also search Downloads (LP: #748915)
- The dash crosses the monitor boundary when resolution is 1152x864 or
lesser width (LP: #765338)
- Dash - dragging a file outside of the Desktop Dash should close the Dash
(LP: #764641)
- Text in Dash search text box overflows and doesn't crop with longer
strings; RtL input starts in wrong place (LP: #834765)
- Where the average background colour is either very light or dark, adjust
this value to darken/lighten in order to preserve readability
(LP: #837993)
- Dash does not resize when I connect to an external display and mirror
displays (LP: #83813...