lightdm uses old upstart job config file

Bug #803513 reported by James Hunt
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
lightdm (Ubuntu)
Fix Released
Low
Unassigned
Oneiric
Fix Released
Low
Unassigned

Bug Description

File /etc/init/lightdm.conf is based upon a very old gdm.conf and thus needs to be updated since the "start on" and "emits" stanzas are not correct.

The key changes required -- taken from latest gdm.conf -- are:

start on ((filesystem
            and (runlevel [!06]
            and (started dbus
            and (drm-device-added card0 PRIMARY_DEVICE_FOR_DISPLAY=1
            or (graphics-device-added PRIMARY_DEVICE_FOR_DISPLAY=1
            or stopped udevtrigger)))))
            or runlevel PREVLEVEL=S)

stop on runlevel [016]

emits login-session-start
emits desktop-session-start

It should be possible to simplify the rather scary "start on" once we introduce the abstract events. Also note that if lightm has config files similar to other DMs, ideally it will emit the two events above. See bug 715093 and upstart-events(7).

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

maybe this is related to the fact that if you restart lightdm manually, it'll take the current vt and not vt7.

Changed in lightdm (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Changed in lightdm (Ubuntu Oneiric):
importance: Medium → Low
Changed in lightdm (Ubuntu Oneiric):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lightdm - 0.9.5-0ubuntu1

---------------
lightdm (0.9.5-0ubuntu1) oneiric; urgency=low

  [ Steve Langasek ]
  * Update upstart job to use current start condition lifted from gdm,
    and to check runlevels instead of /proc/cmdline so it's possible to
    start lightdm after switching out of recovery mode. LP: #803513.

  [ Didier Roche ]
  * debian/patches/01_transition_gnome_ubuntu_desktop.patch:
    natty-oneiric session name upgrade:
    - transition from unity-2d -> ubuntu-2d
    - transition from gnome-2d -> gnome-fallback

  [ Robert Ancell ]
  * New upstream release:
   [0.9.5]
    - Use accounts service in the daemon if it is available
    - Correctly load seat type in multi seat configuration
    - Add display-setup, session-setup and session-cleanup scripting hooks
    - Fix cancel button in GTK greeter (LP: #819240)
    - Fix line through GTK greeter menu items
    - Exit daemon if a seat fails which has exit-on-failure set to true
    - Add HasGuestAccount property to seat D-Bus interface (LP: #835084)
    - Fix XDMCP authorization
    - Update man file
    - Emit upstart events (LP: #715094)
   [0.9.4]
    - lightdm-set-defaults enables tweaking the default session and chosen
      greeter for lightdm. This is useful for derivatives waiting to not ship
      the whole configuration file of lightdm
    - Fix crash in GTK+ greeter when a user is added
    - Move xsessions-directory and xgreeters-directory from [SeatDefaults] to
      [LightDM]. This is a configuration break, but making it on the assumption
      that these settings are not likely to have been overridden.
    - Fix fallback from org.freedesktop.Accounts to passwd format
    - Fix duplicate user entries being shown when using passwd file
    - Add AddSeat D-Bus method for adding dynamic seats
    - Added a dm-tool program that allows user switching and adding seats
    - Allow remote X servers, e.g. launched using dm-tool add-nested-seat
    - Fix bug where sessions were started when the greeter quit and the user
      hadn't been authorized.
    - Fix bug where sessions used the seat bus name
    - Don't allow autologin-username to be set to empty
    - Fix bug where PAM session was not opened before writing to home directory
    - Fix crash when failing to write X authority
 -- Robert Ancell <email address hidden> Wed, 07 Sep 2011 16:09:53 +1000

Changed in lightdm (Ubuntu Oneiric):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.