[SRU] Difficult to distinguish which tab is selected
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Committed
|
Undecided
|
Unassigned | ||
Ubuntu theme |
Fix Released
|
High
|
Will Cooke | ||
ubuntu-themes (Ubuntu) |
Fix Released
|
High
|
Will Cooke | ||
Xenial |
Fix Released
|
High
|
Will Cooke |
Bug Description
[Impact]
* When a user opens multiple tabs in GNOME terminal all tabs are styled in a *very* visually similar manner. This makes it very hard to distinguish between the current active tab and all the others and on a HiDPI screen pretty much impossible.
* This fix has been ack'd by design and was targeted for X but didn't get reviewed and OK'd in time. Design team have approved this styling.
* This bug is fixed by extending the CSS specifically for Terminal (i.e. no other applications are affected) giving the active tab a darker background colour (using only theme defined colours) and reworks the borders around the tabs to remove the graduated image borders that only look right on a light coloured background. Changes have been made for both Ambiance and Radiance.
[Test Case]
* On a stock 16.04 install open GNOME Terminal (ctrl-alt-t)
* Open five new tabs (ctrl-shift-t)
* Click on the tab in the middle
* Note that it is hard to see at a glance which tab is currently selected
* Close Terminal and all open tabs.
* Install the patched theme
* Open Terminal and open five new tabs
* Click on the tab in the middle and note that it takes on a light grey background compared to the unselected tabs which are dark grey.
[Regression Potential]
* The patch only addresses tabs that are placed at the top of the window. However this is the only option in Terminal, so should not cause any problems.
* There is a work-around to match the "actions bar" (the bit with the dropdown selector and + button). This bug is supposed to be fixed in v3.20 and could be removed. This is commented in the CSS.
Related branches
- PS Jenkins bot (community): Approve (continuous-integration)
- Lars Karlitski: Pending requested
- Iain Lane: Pending requested
-
Diff: 93 lines (+78/-0)2 files modifiedAmbiance/gtk-3.0/apps/gnome-terminal.css (+39/-0)
Radiance/gtk-3.0/apps/gnome-terminal.css (+39/-0)
Changed in unity: | |
status: | New → Invalid |
Changed in light-themes (Ubuntu): | |
status: | New → Invalid |
Changed in unity: | |
status: | New → Invalid |
Changed in unity (Ubuntu): | |
status: | New → Invalid |
affects: | unity → null |
no longer affects: | null |
Changed in light-themes (Ubuntu): | |
status: | Confirmed → Fix Released |
Changed in light-themes (Ubuntu): | |
status: | Fix Released → Confirmed |
importance: | Undecided → High |
no longer affects: | unity (Ubuntu) |
affects: | light-themes → ubuntu-themes |
affects: | light-themes (Ubuntu) → ubuntu-themes (Ubuntu) |
tags: | added: rls-x-incoming |
Changed in ubuntu-themes (Ubuntu): | |
assignee: | nobody → Will Cooke (willcooke) |
Changed in ubuntu-themes: | |
assignee: | nobody → Will Cooke (willcooke) |
Changed in ubuntu-themes (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in ubuntu-themes: | |
status: | Confirmed → In Progress |
Changed in ubuntu-themes: | |
importance: | Undecided → High |
tags: | removed: rls-x-incoming |
tags: | added: xenial |
Changed in ayatana-design: | |
status: | New → Fix Committed |
tags: |
added: verification-done removed: verification-needed |
tags: | added: zesty |
It's probably better to explain why this isn't a valid problem with the theme rather than just setting the bug to invalid. Reset to New (would confirm as it's clearly a problem but there must be some reason this was invalidated so I'd like to find that out first)