Ubuntu
python-wadllib package

existing dependency on elementree at python level

Bug #681394 reported by Markus Korn
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
wadllib
Fix Released
High
Unassigned
python-wadllib (Ubuntu)
Fix Released
Low
Unassigned
Lucid
Fix Released
Undecided
Unassigned

Bug Description

Impact: Python code using pkg_resources where the code uses wadllib (or
    launchpadlib) will spuriosly fail, causing problems in other packages.
Development fix: cjwatson is fixing as part of his Python 3 port.
Stable fix: drop the requirement from the requires.txt, as it is not doing anything
   and only breaking code. elementtree is merged in to Python as of 2.6, and having
   then entry won't change what is installed on Ubuntu.
Test case:
    1. Install python-wadllib from lucid.
    2. Check that "elementtree" is listed in /usr/share/pyshared/wadllib-1.1.4.egg-info/requires.txt
    3. Install python-wadllib from lucid-proposed
    4. Check that "elementtree" is no-longer listed in /usr/share/pyshared/wadllib-1.1.4.egg-info/requires.txt
Regression potential: very low, as the line was redundant.

Binary package hint: python-wadllib

With the python-wadllib in maverick installed, the following code fails:

Python 2.6.6 (r266:84292, Sep 15 2010, 16:22:56)
[GCC 4.4.5] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from pkg_resources import require
>>> require("wadllib")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python2.6/dist-packages/pkg_resources.py", line 654, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib/python2.6/dist-packages/pkg_resources.py", line 552, in resolve
    raise DistributionNotFound(req)
pkg_resources.DistributionNotFound: elementtree
>>>

It is because `/usr/share/pyshared/wadllib-1.1.4.egg-info/requires.txt` contains `elementtree`, but in fact `elementree` is not used when the user is using python >= 2.5

See original description

Related branches

lp://staging/~cjwatson/wadllib/py3
Martin Packman (community): Approve
Diff: 564 lines (+148/-87)
6 files modified
.bzrignore (+1/-0)
README.txt (+2/-0)
setup.py (+24/-11)
src/wadllib/README.txt (+79/-64)
src/wadllib/__init__.py (+12/-0)
src/wadllib/application.py (+30/-12)
lp://staging/ubuntu/lucid-proposed/python-wadllib
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Fixed in 1.1.8+ds-1

Changed in python-wadllib (Ubuntu):
importance: Undecided → Low
status: New → Fix Released
Revision history for this message
Luca Falavigna (dktrkranz) wrote :

Well, actually no. Reopen.

Changed in python-wadllib (Ubuntu):
status: Fix Released → Triaged
Aaron Bentley (abentley)
Changed in wadllib:
status: New → Triaged
importance: Undecided → High
James Westby (james-w)
description: updated
Revision history for this message
Martin Pitt (pitti) wrote :

Needs fixing in precise first before this can be SRUed.

Revision history for this message
Robert Collins (lifeless) wrote :

Also I suspect we need to do a release :).

Changed in wadllib:
status: Triaged → Fix Committed
Revision history for this message
James Westby (james-w) wrote :

rick_h did a release with this in it last week. Barry is going to upload to Precise.

Thanks,

James

Changed in wadllib:
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

Seems this fix was part of http://launchpadlibrarian.net/91483771/python-wadllib_1.2.0%2Bds-2build1_1.3.0-0ubuntu1.diff.gz

Changed in python-wadllib (Ubuntu):
status: Triaged → Fix Released
Changed in python-wadllib (Ubuntu Lucid):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Markus, or anyone else affected,

Accepted python-wadllib into lucid-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Revision history for this message
Bartosz Kosiorek (gang65) wrote :

I installed this package from proposed, and there is no dependency from elementtree:

setuptools
lazr.uri
simplejson

[docs]
Sphinx
z3c.recipe.sphinxdoc

Vrification done.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python-wadllib - 1.1.4-1ubuntu1.1

---------------
python-wadllib (1.1.4-1ubuntu1.1) lucid-proposed; urgency=low

  * Removed dependency on elementtree from the egg-info dir as it is part of
    python from 2.6 onwards. The package doesn't depend on it anyway, so
    it won't make a difference to what is installed. (LP: #681394)
    .
    Having it listed in requires.txt meant that pkg_resources would error out
    when used with anything that depends on python-wadllib, breaking other
    software without cause.
 -- James Westby <email address hidden> Wed, 18 Jan 2012 11:18:05 -0500

Changed in python-wadllib (Ubuntu Lucid):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.