User may register without validating the email address
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Ubuntu Single Sign On Client | Status tracked in Trunk | |||||
| Stable-1-0 |
Fix Released
|
High
|
Natalia Bidart | |||
| Trunk |
Fix Released
|
Medium
|
Natalia Bidart | |||
| ubuntu-sso-client (Ubuntu) |
Fix Released
|
Medium
|
Natalia Bidart | |||
| Maverick |
Fix Released
|
Medium
|
Natalia Bidart | |||
| Natty |
Fix Released
|
Medium
|
Natalia Bidart | |||
Bug Description
If the user cancels the registration process before validating the email, the registration in the SSO server was completed but the preferred email was not set, so our SSO server can't process the ping request.
We need to check if the user has a validated email address before logging him in.
TEST CASE:
To test, run in this branch the following:
* killall ubuntu-sso-login; DEBUG=True PYTHONPATH=. ./bin/ubuntu-
* In d-feet, execute the method 'register' in the com.ubuntu.sso bus name, object path /credentials, interface name ApplicationCred
Parameters must be something like:
'Ubuntu Two', '', '', 0
* Once you get the SSO GUI, register a non existent user and do not enter the validation code. Just close the window when the validation code is requested.
* Open the SSO GUI again using d-feet and try to register the same user, you'll get a "Email already registered" error.
* Click on "I already have an account..." to login, and try to login with the former user and pass.
Behavior expected:
- The login process doesn't succeed but instead the email verification screen appears.
Related branches
- Alejandro J. Cura (community): Approve
- Roman Yepishev (community): Approve (fieldtest)
-
Diff: 447 lines (+181/-24)6 files modifiedubuntu_sso/account.py (+21/-0)
ubuntu_sso/gui.py (+17/-2)
ubuntu_sso/main.py (+31/-18)
ubuntu_sso/tests/test_account.py (+37/-0)
ubuntu_sso/tests/test_gui.py (+37/-1)
ubuntu_sso/tests/test_main.py (+38/-3)
- Alejandro J. Cura (community): Approve
- Roman Yepishev (community): Approve (fieldtest)
-
Diff: 449 lines (+173/-34)4 files modifiedubuntu_sso/gui.py (+19/-6)
ubuntu_sso/main.py (+57/-24)
ubuntu_sso/tests/test_gui.py (+26/-1)
ubuntu_sso/tests/test_main.py (+71/-3)
| Changed in ubuntu-sso-client: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| assignee: | nobody → Naty Bidart (nataliabidart) |
| tags: | added: desktop+ u1-natty |
| Changed in ubuntu-sso-client (Ubuntu): | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| assignee: | nobody → Naty Bidart (nataliabidart) |
| tags: | added: u1-maverick-sru |
| description: | updated |
| description: | updated |
| description: | updated |
| Changed in ubuntu-sso-client (Ubuntu Maverick): | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| Changed in ubuntu-sso-client (Ubuntu Maverick): | |
| assignee: | nobody → Naty Bidart (nataliabidart) |
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-sso-client (Ubuntu Natty): | |
| status: | Triaged → Fix Released |
| Martin Pitt (pitti) wrote Please test proposed package | #2 |
| Changed in ubuntu-sso-client (Ubuntu Maverick): | |
| status: | Triaged → Fix Committed |
| tags: | added: verification-needed |
| Natalia Bidart (nataliabidart) wrote | #3 |
| tags: |
added: verification-done removed: verification-needed |
| Launchpad Janitor (janitor) wrote | #4 |
| Changed in ubuntu-sso-client (Ubuntu Maverick): | |
| status: | Fix Committed → Fix Released |
| tags: | added: testcase |
This bug was fixed in the package ubuntu-sso-client - 1.1.2-0ubuntu1
---------------
ubuntu-sso-client (1.1.2-0ubuntu1) natty; urgency=low
* New upstream release:
[ Natalia B. Bidart <email address hidden> ]
* The success page is not shown until the backend notifies that the ping
finished successfully (LP: #667893).
* Added a new DBus signal UserNotValidated to indicate when a user is
registered but not validated (LP: #667899).
* Added new workflow so email validation is requested if necessary.
-- Natalia Bidart (nessita) <email address hidden> Thu, 04 Nov 2010 11:00:45 -0300