Ubuntu
evolution-data-server package

Encode proxy user/password in proxy URL

Bug #664167 reported by Brian J. Murrell on 2010-10-20

This bug affects 1 person

	Status	Importance	Assigned to
evolution-data-server	Fix Released	Medium	gnome-bugs #615274
evolution-data-server (Ubuntu)	Fix Released	Medium	Mathieu Trudel-Lapierre
Maverick	Fix Released	Low	Unassigned

Bug Description

Binary package hint: evolution-data-server

SRU JUSTIFICATION:
Small patch to use along with patch in bug 664169 to use proxy credentials to load images.
This is a big issue for corporate users wishing to have access to rich email content (embedded images) from behind a secured proxy (as it is the case in many large enterprises).

There is minimal impact since this only affects users behind a proxy, and only if they use a secured proxy (requiring authentication).

TEST CASES:
- Requires a proxy with authentication turned on. This can be easily achieved using squid using the pam_auth provider, for example.

1) Configure the proxy settings in Gnome (System->Preferences->Network Proxy) or Evolution (Edit->Preferences->Network Preferences), including authentication username and password.
2) Load a message which contains embedded images from the Internet in a URL document (see attached example: lp_664169_test_case.mbox -- this test case can be loaded in Evolution by double-clicking it)
3) Force loading the images from the Internet by pressing Ctrl-I.

For a successful test cases, you will see embedded images being loaded from the Internet and displayed in the message.
For a failed test cases, the images will not load.

---

We need the patch from the upstream bug 615274 landed so that proxy credentials are used properly.

See original description

Tags:

Related branches

lp://staging/~cyphermox/evolution-data-server/lp664167 (Merged)

lp://staging/ubuntu/maverick-proposed/evolution-data-server

Bug Watch Updater (bug-watch-updater) on 2010-10-20

Changed in evolution-data-server:
importance:	Unknown → Medium
status:	Unknown → Fix Released

Revision history for this message

Brian J. Murrell (brian-interlinx) wrote on 2010-10-21:

109-Bug-615274-use-proxy-password.patch Edit (2.4 KiB, text/plain)

This patch is a backport of the upstream patch.

To test, configure evolution to use a proxy which requires a username/password to gain access, then while viewing an e-mail that has image URL references, try to force the images to load with a ctrl-i. If the images load and you have the patch from LP 664169, you should see the images.

summary:

- need upstream patch from bug 615274
+ Encode proxy user/password in proxy URL

Revision history for this message

Pedro Villavicencio (pedro) wrote on 2010-10-21:

Didier may you please have a look to it? Thanks.

Changed in evolution-data-server (Ubuntu):
status:	New → Triaged
importance:	Undecided → Medium
assignee:	nobody → Didier Roche (didrocks)
assignee:	Didier Roche (didrocks) → nobody

Revision history for this message

Brian J. Murrell (brian-interlinx) wrote on 2010-11-20:

Will this be making it into an updated evolution-data-server package for Maverick any time soon?

Sebastien Bacher (seb128) on 2010-11-22

Changed in evolution-data-server (Ubuntu):
assignee:	nobody → Didier Roche (didrocks)

Mathieu Trudel-Lapierre (cyphermox) on 2010-11-22

Changed in evolution-data-server (Ubuntu):
assignee:	Didier Roche (didrocks) → Mathieu Trudel-Lapierre (mathieu-tl)

Mathieu Trudel-Lapierre (cyphermox) on 2010-11-22

description:

updated

Revision history for this message

Mathieu Trudel-Lapierre (cyphermox) wrote on 2010-11-22:

lp_664169_test_case.mbox Edit (13.9 KiB, text/plain)

Not absolutely certain this will work properly, but here is an attempted test case for embedded images from the Internet.

Mathieu Trudel-Lapierre (cyphermox) on 2010-11-22

description:

updated

Revision history for this message

Mathieu Trudel-Lapierre (cyphermox) wrote on 2010-11-25:

evolution-data-server_2.30.3-2ubuntu2.1.debdiff Edit (4.4 KiB, text/plain)

The attached debdiff applies the patch and appears to fix the problem.

Revision history for this message

Brian J. Murrell (brian-interlinx) wrote on 2010-12-15:

Great. So will this go into a new release for evolution for Maverick or has interest in maintaining evolution in Maverick waned?

Revision history for this message

Sebastien Bacher (seb128) wrote on 2010-12-15:

the issue is fixed in the natty version

Changed in evolution-data-server (Ubuntu):
status:	Triaged → Fix Released
Changed in evolution-data-server (Ubuntu Maverick):
status:	New → Fix Committed
importance:	Undecided → Low

Revision history for this message

Sebastien Bacher (seb128) wrote on 2010-12-15:

thank you for the sru work

Revision history for this message

Brian J. Murrell (brian-interlinx) wrote on 2010-12-15: Re: [Bug 664167] Re: Encode proxy user/password in proxy URL

On Wed, 2010-12-15 at 15:27 +0000, Sebastien Bacher wrote:
> the issue is fixed in the natty version

But what about the maverick version that we are all still using?

I was assured that evolution in maverick was going to be maintained
through the maverick cycle if I expended the extra effort of pushing my
patches upstream to the Ubuntu maintainers instead of continuing to just
maintain my own local, patched and working release. Is this no longer
the case? Will this effort not benefit maverick any more? Just want to
know so that I can stop wasting my time if that's the case.

Revision history for this message

Sebastien Bacher (seb128) wrote on 2010-12-15:

#10

the sru debdiff in this bug was uploaded earlier, see the task set to fix commited, not sure what your concern are, ubuntu-sru needs to review it though

Revision history for this message

Martin Pitt (pitti) wrote on 2010-12-20: Please test proposed package

#11

Accepted evolution-data-server into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags:

added: verification-needed

Revision history for this message

Brian J. Murrell (brian-interlinx) wrote on 2010-12-20: Re: [Bug 664167] Re: Encode proxy user/password in proxy URL

#12

On Mon, 2010-12-20 at 08:46 +0000, Martin Pitt wrote:
> Accepted evolution-data-server into maverick-proposed, the package will
> build now and be available in a few hours. Please test and give feedback
> here.

I'm afraid I won't be able to do that testing as I also need the patch
in bug 660626 applied to my e-d-s and will have to continue to use my
own build for that as the patch did not seem to make it into the
-proposed version.

In fact I asked a number of times on bug 660626 about whether that patch
would be included and all queries went unanswered.

Revision history for this message

Mathieu Trudel-Lapierre (cyphermox) wrote on 2011-01-18:

#13

Brian,

Is there no way that you could test in a different account/different system so that we could confirm this bug is fixed in the packages in -proposed? That way maybe we could avoid requiring the X-Evolution-Source patch for sorting/filtering, especially since it's an unrelated fix?

Thanks.

Revision history for this message

Brian J. Murrell (brian-interlinx) wrote on 2011-01-21:

#14

Well, I am using the maverick-proposed build plus my patch(es) so I think it's fair to say that it's been tested and confirmed.

Martin Pitt (pitti) on 2011-01-25

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2011-01-25:

#15

This bug was fixed in the package evolution-data-server - 2.30.3-2ubuntu2.1

---------------
evolution-data-server (2.30.3-2ubuntu2.1) maverick-proposed; urgency=low

  * lp664167_de16bec_encode_auth_in_proxy_url.patch: backport another fix from
    the gnome-2.32 branch to support encoding proxy user/passwd auth parameters
    in proxy URL (LP: #664167)
-- Mathieu Trudel-Lapierre <email address hidden> Tue, 23 Nov 2010 11:18:46 -0500