Ubuntu Single Sign On Client

100% cpu usage after clicking a link on T&C page

Bug #655327 reported by Alejandro J. Cura on 2010-10-05

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Ubuntu Single Sign On Client	Status tracked in Trunk
Stable-1-0	Fix Released	High	Natalia Bidart
Trunk	Fix Released	High	Alejandro J. Cura
ubuntu-sso-client (Ubuntu)	Fix Released	High	Natalia Bidart	Ubuntu natty-alpha-1
Maverick	Fix Released	High	Natalia Bidart
Natty	Fix Released	High	Natalia Bidart	Ubuntu natty-alpha-1

Bug Description

When a link is clicked on the Terms and Conditions page, the cpu usage suddenly goes to 100% (and won't go down).

FIX: use the gtk main loop instead of the twisted main loop, seems like twisted and pywebkit does not play nicely.

Minimal patch: see linked branch.

TEST CASE:
* call the com.ubuntu.sso DBus service (/credentials path object) using, for example, d-feet
* open the registration window: call login_or_register_to_get_credentials passing arguments "Test", "http://one.ubuntu.com/terms", "testing a bit more", 0
* when the GTK interface pops out, click the "Terms & Conditions" button, and then click any link.

See original description

Tags:

Related branches

lp://staging/~alecu/ubuntu-sso-client/fix-100pct-links

Merged into lp://staging/ubuntu-sso-client at revision 641

Natalia Bidart (community): Approve on 2010-10-06

Rodrigo Moya (community): Approve on 2010-10-06

lp://staging/~nataliabidart/ubuntu-sso-client/fix-100pct-links-stable

Merged into lp://staging/ubuntu-sso-client/stable-1-0 at revision 633

Vincenzo Di Somma (community): Approve on 2010-10-12

John Lenton (community): Approve on 2010-10-12

lp://staging/ubuntu/maverick-proposed/ubuntu-sso-client

Natalia Bidart (nataliabidart) on 2010-10-06

Changed in ubuntu-sso-client:
status:	New → In Progress
importance:	Undecided → High
assignee:	nobody → Alejandro J. Cura (alecu)

dobey (dobey) on 2010-10-06

Changed in ubuntu-sso-client:
status:	In Progress → Fix Committed

Natalia Bidart (nataliabidart) on 2010-10-11

Changed in ubuntu-sso-client (Ubuntu):
status:	New → Triaged
importance:	Undecided → Medium
milestone:	none → natty-alpha-1
importance:	Medium → High
assignee:	nobody → Naty Bidart (nataliabidart)
tags:	added: desktop+ u1-natty

Natalia Bidart (nataliabidart) on 2010-10-12

tags:	added: u1-maverick-sru
description:	updated
description:	updated
description:	updated

Natalia Bidart (nataliabidart) on 2010-10-12

description:

updated

Revision history for this message

Martin Pitt (pitti) wrote on 2010-10-14: Please test proposed package

Accepted ubuntu-sso-client into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in ubuntu-sso-client (Ubuntu):
status:	Triaged → Fix Committed
Changed in ubuntu-sso-client (Ubuntu Maverick):
status:	New → Fix Committed
tags:	added: verification-needed

Natalia Bidart (nataliabidart) on 2010-10-14

Changed in ubuntu-sso-client (Ubuntu Maverick):
importance:	Undecided → High
assignee:	nobody → Naty Bidart (nataliabidart)

Revision history for this message

Natalia Bidart (nataliabidart) wrote on 2010-10-18:

Tested on a clean maverick install with -proposed enabled. Problem solved.

Jean-Baptiste Lallement (jibel) on 2010-10-18

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-10-18:

This bug was fixed in the package ubuntu-sso-client - 1.1.1-0ubuntu1

---------------
ubuntu-sso-client (1.1.1-0ubuntu1) natty; urgency=low

* New upstream release (1.1.1):

[ Alejandro J. Cura <email address hidden> ]
* Call the dbus mainloop thread init (fixes LP: #656545).

    [ Natalia B. Bidart <email address hidden> ]
      * Added the new dbus iface to the executable. Deprecated a few Dbus
      constants.

    [ Natalia B. Bidart <email address hidden> ]
      * Adding a new DBus iface to manage credentials with flexible API (LP:
      #653113).

    [ Natalia B. Bidart <email address hidden> ]
      * Replace twisted gtk reactor with the standard gtk mainloop. (LP:
      #655327).

    [ Natalia B. Bidart <email address hidden> ]
      * The TC browser will not be shown until the TOS page has been loaded. A
      spinner is shown in the mean time (LP: #620456).
      * The TC browser does not allow link navigation other than the TOS page
      (LP: #616961).

    [ Natalia B. Bidart <email address hidden> ]
      * Terms and conditions label is now translatable. Added a button to be
      able to browse the TC (LP: 654534).

    [ Natalia B. Bidart <email address hidden> ]
      * Moved logic from DBus SSOCredentials module into a self-contained, DBus
      agnostic module called 'credentials' (LP: #653113).

[ Natalia B. Bidart <email address hidden> ]
* Isolating SSO login processor into a separated module (LP: #637204).

[ Natalia B. Bidart <email address hidden> ]
* Cleanup code and modules to prepare the code for the DBus API refactor.

    [ Natalia B. Bidart <email address hidden> ]
      * Made entries name to be unicode to avoid a faulty capitalization when
      using turkish locale (LP: #652939).

    [ Natalia B. Bidart <email address hidden> ]
      * Workaround for LP: #467397 (when using turkish locale, decimal module
      import fails).

    [ Natalia B. Bidart <email address hidden> ]
      * Added encoding declaration on every file. Fixed error passing from GUI
      in GTK signals (LP: #652318).

[ Natalia B. Bidart <email address hidden> ]
* Avoiding calling a callback twice for buttons (LP: #652248).

    [ Natalia B. Bidart <email address hidden> ]
      * Removed unneeded assert sentences and replaced with warning logging
      when necessary (LP: #649317).

* New upstream release (1.1.0):

    [ Natalia B. Bidart <email address hidden> ]
      * Avoiding having the main window freezing when pinging the U1 server
      (LP: #645162).

[ Natalia B. Bidart <email address hidden> ]
* Do not create the login keyring, use default instead (LP: #639690).

[ Natalia B. Bidart <email address hidden> ]
* Avoid duplicating logging messages for module "main" (LP: #638981).

    [ Natalia B. Bidart <email address hidden> ]
      * Delay import of webkit to be able to build on non-graphical envs (LP:
      #628956).
-- Natalia Bidart (nessita) <email address hidden> Mon, 11 Oct 2010 10:22:28 -0300

This bug was fixed in the package ubuntu-sso-client - 1.1.1-0ubuntu1

---------------
ubuntu-sso-client (1.1.1-0ubuntu1) natty; urgency=low

* New upstream release (1.1.1):

[ Alejandro J. Cura <alecu@canonical.com> ]
      * Call the dbus mainloop thread init (fixes LP: #656545).

[ Natalia B. Bidart <natalia.bidart@canonical.com> ]
      * Added the new dbus iface to the executable. Deprecated a few Dbus
      constants.

[ Natalia B. Bidart <natalia.bidart@canonical.com> ]
      * Adding a new DBus iface to manage credentials with flexible API (LP:
      #653113).

[ Natalia B. Bidart <natalia.bidart@canonical.com> ]
      * Replace twisted gtk reactor with the standard gtk mainloop. (LP:
      #655327).

[ Natalia B. Bidart <natalia.bidart@canonical.com> ]
      * The TC browser will not be shown until the TOS page has been loaded. A
      spinner is shown in the mean time (LP: #620456).
      * The TC browser does not allow link navigation other than the TOS page
      (LP: #616961).

[ Natalia B. Bidart <natalia.bidart@canonical.com> ]
      * Terms and conditions label is now translatable. Added a button to be
      able to browse the TC (LP: 654534).

[ Natalia B. Bidart <natalia.bidart@canonical.com> ]
      * Moved logic from DBus SSOCredentials module into a self-contained, DBus
      agnostic module called 'credentials' (LP: #653113).

[ Natalia B. Bidart <natalia.bidart@canonical.com> ]
      * Isolating SSO login processor into a separated module (LP: #637204).

[ Natalia B. Bidart <natalia.bidart@canonical.com> ]
      * Cleanup code and modules to prepare the code for the DBus API refactor.

[ Natalia B. Bidart <natalia.bidart@canonical.com> ]
      * Made entries name to be unicode to avoid a faulty capitalization when
      using turkish locale (LP: #652939).

[ Natalia B. Bidart <natalia.bidart@canonical.com> ]
      * Workaround for LP: #467397 (when using turkish locale, decimal module
      import fails).

[ Natalia B. Bidart <natalia.bidart@canonical.com> ]
      * Added encoding declaration on every file. Fixed error passing from GUI
      in GTK signals (LP: #652318).

[ Natalia B. Bidart <natalia.bidart@canonical.com> ]
      * Avoiding calling a callback twice for buttons (LP: #652248).

[ Natalia B. Bidart <natalia.bidart@canonical.com> ]
      * Removed unneeded assert sentences and replaced with warning logging
      when necessary (LP: #649317).

* New upstream release (1.1.0):

[ Natalia B. Bidart <natalia.bidart@canonical.com> ]
      * Avoiding having the main window freezing when pinging the U1 server
      (LP: #645162).

[ Natalia B. Bidart <natalia.bidart@canonical.com> ]
      * Do not create the login keyring, use default instead (LP: #639690).

[ Natalia B. Bidart <natalia.bidart@canonical.com> ]
      * Avoid duplicating logging messages for module "main" (LP: #638981).

[ Natalia B. Bidart <natalia.bidart@canonical.com> ]
      * Delay import of webkit to be able to build on non-graphical envs (LP:
      #628956).
 -- Natalia Bidart (nessita) <nataliabidart@gmail.com>   Mon, 11 Oct 2010 10:22:28 -0300

Changed in ubuntu-sso-client (Ubuntu Natty):
status:	Fix Committed → Fix Released

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-10-20:

This bug was fixed in the package ubuntu-sso-client - 1.0.4-0ubuntu1

---------------
ubuntu-sso-client (1.0.4-0ubuntu1) maverick-proposed; urgency=low

* New upstream release:

[ Alejandro J. Cura <email address hidden> ]
* Replace twisted gtk reactor with the standard gtk mainloop. (LP: #655327).

[ Alejandro J. Cura <email address hidden> ]
* Call the dbus mainloop thread init (fixes LP: #656545).

* Adding .bzr-builddeb/default.conf as per Michael Vog (mvo) request.

* Adding dpkg (>= 1.15.7.2) as Pre-Depends (fixes LP: #658768).

* Adding gnome-keyring as dep since python-gnomekeyring doesn't install it.
-- Natalia Bidart (nessita) <email address hidden> Tue, 12 Oct 2010 10:07:55 -0300

Changed in ubuntu-sso-client (Ubuntu Maverick):
status:	Fix Committed → Fix Released

Ubuntu Foundations Team Bug Bot (crichton) on 2011-09-19

tags:

added: testcase

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.