Use X-GNOME-FullName over Name for more comprehensive entries

Bug #651260 reported by Kiwinote
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-center (Ubuntu)
Fix Released
Medium
Kiwinote
Maverick
Fix Released
Undecided
Unassigned
Natty
Fix Released
Medium
Kiwinote

Bug Description

Binary package hint: software-center

s-c 3.0.2

Open s-c with eg "software-center cheese empathy evolution gwibber". Note that the application list and details view uses the Name field from the desktop file resulting in 'Cheese, Empathy, Evolution, Gwibber', rather than the X-GNOME-FullName from the desktop file which would result in 'Cheese Webcam Booth, Empathy Internet Messaging, Evolution Mail and Calendar, Gwibber Social Client'. These longer names are a lot more descriptive and will hence help people to find the application they want (also in searches). I have implemented this new behaviour with a simple fix available in the branch linked.

It would be great to have this in s-c 3.0, but things to take note of:
- It would seem that Unity won't be affected by this change, but I aren't really sure..
- When running s-c in eg French and displaying eg Cheese , the fullname is not translated (in the 'where is it' path it is). This seems to be a difference in the gettext domains used in app-install/desktop/*.desktop versus applications/*.desktop. It seems like this is an unrelated (existing?) bug, already apparent in eg some summaries, but this change would make it more visible. Only some packages have this problem.

Kiwinote (kiwinote)
Changed in software-center (Ubuntu):
assignee: nobody → Kiwinote (kiwinote)
importance: Undecided → Medium
status: New → Fix Committed
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Michael Vogt pinged me about this bug, so just chiming in here for completeness.

I'm pretty sure this wont cause problems for Unity. The one place that comes to mind is when launching s-c to install an app from the Availabale group in the apps place. In that case we fire off 'software-center $pkgname/$name' (as I agreed with Michael at the platform sprint). If we now get X-GNOME-FullName instead of Name, this might confuse s-c?

Revision history for this message
Kiwinote (kiwinote) wrote :

Hi Mikkel, thanks for that info. As you correctly point out s-c doesn't play nicely with appnames containing spaces, as it is identified as a list of pkgs rather than as a single pkg (eg ./software-center evolution/Evolution Mail and Calendar). I'll have a quick look at the code that makes this decision, but I'm guessing that it's not entirely trivial to work out if we're dealing with a custom list or with a pkgname/appname combination (without making some assumptions/decisions I don't really want to make at this stage of the cycle). I would prefer this change not to land in 3.0 as I consider it too risky.

Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Accepted software-center into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in software-center (Ubuntu Maverick):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Omer Akram (om26er) wrote :

in the proposed version searching for gwibber shows 'gwibber social client' previously it only showed 'gwibber'

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-center - 3.0.5

---------------
software-center (3.0.5) maverick-proposed; urgency=low

  [ Andrea Cimitan ]
  * fix rendering with Ambiance theme (LP: #635208)

  [ Kiwinote ]
  * softwarecenter/app.py:
    - support launching apturls via alt+F2 in gnome (LP: #653889)
  * softwarecenter/db/update.py:
    - use 'X-GNOME-FullName' rather than 'Name', when available (LP: #651260)
      (test case: software-center cheese empathy evolution gwibber)
  * softwarecenter/view/appview.py:
    - unblock pkg if transaction is cancelled (LP: #652903)
      (test case: launch s-c with a list view, choose a pkg, click install,
       cancel auth, click install again, install should work as normal)
  * softwarecenter/view/availablepane.py:
    - don't show 'hide 1 technical item' in featured category (LP: #651236)
      (test case: browse to featured category (by clicking 'all'))
    - don't show 'hide technical items' in system category, as we don't
      have any apps to show (LP: #636854)
      (test case: browse to 'System' category)
  * softwarecenter/view/historypane.py:
    - correctly split pkgnames for pkg transactions dated before 28-ish July
      (LP: #651241)
      (test case: view transaction in history pane dated pre 28 July)
  * softwarecenter/view/viewswitcher.py:
    - emit 'transactions-changed' signal after connecting to the backend so
      that we display any pending transactions (LP: #652927)
      (see bug report for test case)

  [ Michael Vogt ]
  * softwarecenter/backend/aptd.py:
    - use keyserver.ubuntu.com on port 80 by default to avoid problems
      on machines that filter the port 11371
  * softwarecenter/backend/restfulclient.py, softwarecenter/enums.py:
    - use plain http for the "what-is-available" API call
  * send user default language for "/apps" and "/subscription" requests
    now that the server is ready for this
 -- Michael Vogt <email address hidden> Wed, 13 Oct 2010 16:13:10 +0200

Changed in software-center (Ubuntu Maverick):
status: Fix Committed → Fix Released
Kiwinote (kiwinote)
Changed in software-center (Ubuntu Natty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.