Emails from staging export-to-branch script going out to real world
Bug #593501 reported by
Jeroen T. Vermeulen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Jeroen T. Vermeulen | ||
Bug Description
The notifications for unpushed translations export branches sent by the staging version of the script are being sent out for real. Apparently staging codehosting must be configured to act differently from staging appserver.
We have to stop this from happening pronto. All branches copied from production to staging will be nonexistent on the staging codehosting server and so can trigger a notification.
Related branches
lp://staging/~jtv/launchpad/db-bug-593501
- Tim Penhey (community): Approve
- Canonical Launchpad Engineering: Pending (code) requested
-
Diff: 135 lines (+61/-1)4 files modifiedlib/canonical/config/schema-lazr.conf (+11/-0)
lib/lp/translations/doc/translations-export-to-branch.txt (+9/-1)
lib/lp/translations/scripts/tests/test_translations_to_branch.py (+29/-0)
lib/lp/translations/scripts/translations_to_branch.py (+12/-0)
| Changed in rosetta: | |
| importance: | Critical → High |
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | #1 |
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | #2 |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #3 |
| Changed in rosetta: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
Revision history for this message
| Ursula Junque (ursinha) wrote | #4 |
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | #5 |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in rosetta: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Not quite as bad as I feared; only a few people are affected. The fix is currently going through its tests; it disables the emails unless explicitly configured. I've asked the sysadmins to turn off the script on staging when their working day starts. The lp-production-