ifconfig eth0 down will cause system hang after fec.c driver update

Paul and Tobin,

Could you please help me to test the following kernel package on your side? See whether suspend/resume works and 'ifconfig eth0 down' works.
http://people.canonical.com/~roc/kernel/fec_suspend/

Thanks,
-Bryan

Using the kernel kernel there, I was able to successfully ifconfig eth0 down and also bring it back up without hanging the system. However, suspend/resume still does not work

Nice speed improvement. Downloading a test iso from my W2k3 server is now averaging 8.5 MB/s (previous kernel was at ~4.5 MB/s). Unfortunately, suspend/resume still fails.

Paul and Tobin,

Please help me to test again to see whether the ifconfig down cause system hang.

I updated this patch according to kernel team review.
http://people.canonical.com/~roc/kernel/ifconfig/

my git tree is here:
http://kernel.ubuntu.com/git?p=roc/ubuntu-lucid.git;a=shortlog;h=refs/heads/fec

Thanks,
-Bryan

Ifconfig now works, download speed still looks very good. Still no resume from suspend.

Tobin and Paul,

Could you please help me to test again for ifconfig issue and performance? I updated again according to the review from our kernel member.
http://people.canonical.com/~roc/kernel/ifconfig/

my git tree is here:
http://kernel.ubuntu.com/git?p=roc/ubuntu-lucid.git;a=shortlog;h=refs/heads/fec

Thanks,
-Bryan

I don't see any real difference between this kernel and the previous test kernel (comment #4).

Tobin,

Thanks a lot. My board broke now. Could you please try my testing kernel again?
I updated again according to the review from our kernel member.
http://people.canonical.com/~roc/kernel/ifconfig/

my git tree is here:
http://kernel.ubuntu.com/git?p=roc/ubuntu-lucid.git;a=shortlog;h=refs/heads/fec

Thanks,
-Bryan

Nope, this kernel had a bad oops during boot, and it fails to boot all the way, suggesting memory corruption.

See attached oops captured from serial console.

Added full kernel ouput from serial console.

I fixed this oops and please help me to test again. Thanks.
http://people.canonical.com/~roc/kernel/ifconfig/

my git tree is here:
http://kernel.ubuntu.com/git?p=roc/ubuntu-lucid.git;a=shortlog;h=refs/heads/fec

Thanks,
-Bryan

Tested ifdown3. No oops, download speed is great, and ifconfig eth0 down does not hang the system. Win!

@Brian, is the ifconfig eth0 down the same issue that is causing suspend/resume to fail? If not, we should probably split this into two bugs

@Paul,

Actually, I found this ifdown hang issue when I was debugging the suspend/resume regression. But even we fixed the ifdown hang issue, system can suspend now but cannot resume.

Yes, please help me file a bug about the resume failure regression.

Thanks,
-Bryan

The suspend/resume problem discussed here has been split into bug #571192

Regarding phylib resume issue, see one fix under
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=541cd3ee00a4fe975b22fac6a3bc846bacef37f7

Accepted linux-fsl-imx51 into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Tested and verified that this now works, thanks.

This bug was fixed in the package linux-fsl-imx51 - 2.6.31-608.15

---------------
linux-fsl-imx51 (2.6.31-608.15) lucid-proposed; urgency=low

  [ Andy Whitcroft ]

  * rebase to Ubuntu-2.6.31-22.61
  * update to ubuntu-debian:7e708d33054c373faf41da23b73e8b48c342d958
    - LP: #570500, #576274

  [ Bryan Wu ]

  * SAUCE: IMX51: fix stgl5000 regulator_get failing error
    - LP: #567157

  [ Mattias Walstrom ]

  * (pre-upstream) FEC: Fix kernel panic in fec_set_mac_address.
    - LP: #575558

  [ Upstream Kernel Changes ]

  * ENGR00120510 atlas switch mode control
  * ENGR00120456 mx51: set VIOHI always on
  * ENGR00121069: MX51: Complete the constraints for the various
    regulators.
  * ENGR00121385 MX51: Leave MC13892 VUSB Turned on for USB OTG to work
  * netdev/fec: fix ifconfig eth0 down hang issue
    - LP: #559065

  [ Ubuntu: 2.6.31-22.61 ]

  * SAUCE: docs -- fix doc strings for fc_event_seq
  * update to ubuntu-debian:7e708d33054c373faf41da23b73e8b48c342d958
    - LP: #570500, #576274
  * SAUCE: sched: update load count only once per cpu in 10 tick update
    window
    - LP: #513848
  * (pre-stable) x86-32, resume: do a global tlb flush in S4 resume
    - LP: #531309
  * PCI: Ensure we re-enable devices on resume
    - LP: #566149
 -- Stefan Bader <email address hidden> Mon, 14 Jun 2010 11:58:42 +0200