Ubuntu
pkgbinarymangler package

need to update Installed-Size header

Bug #451764 reported by Steve Langasek on 2009-10-14

This bug affects 4 people

Affects		Status	Importance	Assigned to	Milestone
	pkgbinarymangler	New	Undecided	Unassigned
	pkgbinarymangler (Ubuntu)	Fix Released	Low	Martin Pitt

Bug Description

Binary package hint: ubuntu-docs

The Installed-Size header in the ubuntu-docs package is broken, because it appears to be calculated on the package *before* translations have been stripped:
# apt-get install ubuntu-docs
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following packages will be upgraded:
ubuntu-docs
1 upgraded, 0 newly installed, 0 to remove and 6 not upgraded.
Need to get 0B/470kB of archives.
After this operation, 63.8MB of additional disk space will be used.

63.8MB of *additional* disk space, because the only information apt has available says that the package has grown from 165MB to 226 MB (!). The unpacked size of the *actual* package is 19MB.

The problem appears to be in this ordering of operations in the build log:

dh_gencontrol -pubuntu-docs
[...]
if [ -z "$CDBS_NO_GNOME_HELP_SYMLINKING" ] && [ -d debian/ubuntu-docs/usr/share/gnome/help ]; then \
            cd debian/ubuntu-docs && LC_ALL=C fdupes -r1nq usr/share/gnome/help | while read s; do \
                set -- $(echo $s | tr ' ' '\n' | sort); \
                f=$1; shift; \
                for d; do \
                    echo "symlinking duplicate Gnome help file $d to $f"; \
                    rm $d; ln -s /$f $d; \
                done; \
            done; \
        fi
[...]
dh_builddeb -pubuntu-docs -- -Z bzip2
pkgstriptranslations: processing control file: ./debian/ubuntu-docs/DEBIAN/control, package ubuntu-docs, directory ./debian/ubuntu-docs

Perhaps this will be fixed by fixing bug #441401, I don't know.

ProblemType: Bug
Architecture: amd64
Date: Wed Oct 14 16:47:33 2009
DistroRelease: Ubuntu 9.10
Package: ubuntu-docs 9.10.9
PackageArchitecture: all
ProcEnviron:
PATH=(custom, user)
LANG=en_US.UTF-8
SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-13.44-generic
SourcePackage: ubuntu-docs
Uname: Linux 2.6.31-13-generic x86_64

Tags:

Related branches

lp://staging/pkgbinarymangler

lp://staging/ubuntu/maverick/pkgbinarymangler

Revision history for this message

Steve Langasek (vorlon) wrote on 2009-10-14:

Dependencies.txt Edit (4.2 KiB, text/plain; charset="utf-8")
XsessionErrors.txt Edit (2.6 KiB, text/plain; charset="utf-8")

Changed in ubuntu-docs (Ubuntu):
importance:	Undecided → Low
status:	New → Triaged

Revision history for this message

Matthew East (mdke) wrote on 2009-10-15:

I'm wondering if this is a bug in the Launchpad build process - so that pkgstriptranslations should be run earlier in the build. Unfortunately I don't have nearly enough knowledge to work that out so will have to leave it to Martin, subscribing him.

Revision history for this message

Martin Pitt (pitti) wrote on 2009-10-19:

The build order seems correct, pkgbinarymangler is called from dpkg-builddeb through dh_builddeb. I'm not entirely sure what calculates Installed-Size:, though. Shouldn't dpkg-deb do that?

Revision history for this message

Steve Langasek (vorlon) wrote on 2009-10-19: Re: [Bug 451764] Re: Installed-Size header in ubuntu-docs is broken

On Mon, Oct 19, 2009 at 05:16:32PM -0000, Martin Pitt wrote:
> The build order seems correct, pkgbinarymangler is called from dpkg-
> builddeb through dh_builddeb. I'm not entirely sure what calculates
> Installed-Size:, though. Shouldn't dpkg-deb do that?

No, it's done by dpkg-gencontrol.

--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
<email address hidden> <email address hidden>

Martin Pitt (pitti) on 2009-10-20

summary:	- Installed-Size header in ubuntu-docs is broken + need to update Installed-Size header
affects:	ubuntu-docs (Ubuntu) → pkgbinarymangler (Ubuntu)

Martin Pitt (pitti) on 2010-07-06

Changed in pkgbinarymangler (Ubuntu):
status:	Triaged → Fix Committed
assignee:	nobody → Martin Pitt (pitti)

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-07-09:

This bug was fixed in the package pkgbinarymangler - 70

---------------
pkgbinarymangler (70) maverick; urgency=low

  * Move "PPA" check from dpkg-deb to pkgmaintainermangler and
    pkgstriptranslations. We want to call pkgsanitychecks for PPA builds as
    well, and also control behaviour for PPAs individually for each mangler.
  * pkgstriptranslations: Run if we are building in an OEM PPA. If the built
    package is in Ubuntu main, strip translations from it. However, introduce
    a blacklist of OEM projects (oem_blacklist in striptranslations.conf)
    which are close or past release, to not inflict this rather intrusive
    change on them.
  * debian/control: Update Maintainer field from myself to Ubuntu Developers.
  * Add debian/source/format: 3.0 (native).
  * debian/control: Bump Standards-Version to 3.9.0.
  * Apply a consistent indentation to all source files (4 spaces, expand
    tabs).
  * dpkg-deb: Replace hardcoded paths with "which", to allow local testing.
  * Replace hardcoded "/CurrentlyBuilding" path with a $BUILDINFO variable set
    in "common", to allow local testing.
  * Add test/icecream: Test source package building two binary packages
    "vanilla" and "chocolate" with two po/mo files each.
  * Allow changing the path of "common" with $PKGBINARYMANGLER_COMMON_PATH.
  * Allow changing the configuration file directory path with
    $PKGBINARYMANGLER_CONF_DIR.
  * pkgmaintainermangler: Allow changing the path to the override file with
    $PKMAINTAINERGMANGLER_OVERRIDES.
  * Add test/run: Test suite for checking the scripts/config files in the
    local build tree in a sandbox on the "icecream" test package. Cover all
    current scenarios: main/universe/PPA/OEM/NO_PKG_MANGLE/partner/local/no
    mangler.
  * debian/rules: Run tests during build, and have a failed test suite fail
    the build. Add python and fakeroot build dependencies for this.
  * Add debian/pkgbinarymangler.lintian-overrides: We divert "dpkg-deb", no
    need to ship a manpage for it.
  * striptranslations.blacklist: Drop language-selector. (LP: #570240)
  * test/run: Add test case for updating of Installed-Size. This reproduces
    LP #451764.
  * pkgstriptranslations: Adapt Installed-Size: header in control file if we
    stripped any files. (LP: #451764)
-- Martin Pitt <email address hidden> Fri, 09 Jul 2010 09:19:44 +0200

This bug was fixed in the package pkgbinarymangler - 70

---------------
pkgbinarymangler (70) maverick; urgency=low

* Move "PPA" check from dpkg-deb to pkgmaintainermangler and
    pkgstriptranslations. We want to call pkgsanitychecks for PPA builds as
    well, and also control behaviour for PPAs individually for each mangler.
  * pkgstriptranslations: Run if we are building in an OEM PPA. If the built
    package is in Ubuntu main, strip translations from it. However, introduce
    a blacklist of OEM projects (oem_blacklist in striptranslations.conf)
    which are close or past release, to not inflict this rather intrusive
    change on them.
  * debian/control: Update Maintainer field from myself to Ubuntu Developers.
  * Add debian/source/format: 3.0 (native).
  * debian/control: Bump Standards-Version to 3.9.0.
  * Apply a consistent indentation to all source files (4 spaces, expand
    tabs).
  * dpkg-deb: Replace hardcoded paths with "which", to allow local testing.
  * Replace hardcoded "/CurrentlyBuilding" path with a $BUILDINFO variable set
    in "common", to allow local testing.
  * Add test/icecream: Test source package building two binary packages
    "vanilla" and "chocolate" with two po/mo files each.
  * Allow changing the path of "common" with $PKGBINARYMANGLER_COMMON_PATH.
  * Allow changing the configuration file directory path with
    $PKGBINARYMANGLER_CONF_DIR.
  * pkgmaintainermangler: Allow changing the path to the override file with
    $PKMAINTAINERGMANGLER_OVERRIDES.
  * Add test/run: Test suite for checking the scripts/config files in the
    local build tree in a sandbox on the "icecream" test package. Cover all
    current scenarios: main/universe/PPA/OEM/NO_PKG_MANGLE/partner/local/no
    mangler.
  * debian/rules: Run tests during build, and have a failed test suite fail
    the build. Add python and fakeroot build dependencies for this.
  * Add debian/pkgbinarymangler.lintian-overrides: We divert "dpkg-deb", no
    need to ship a manpage for it.
  * striptranslations.blacklist: Drop language-selector. (LP: #570240)
  * test/run: Add test case for updating of Installed-Size. This reproduces
    LP #451764.
  * pkgstriptranslations: Adapt Installed-Size: header in control file if we
    stripped any files. (LP: #451764)
 -- Martin Pitt <martin.pitt@ubuntu.com>   Fri, 09 Jul 2010 09:19:44 +0200

Changed in pkgbinarymangler (Ubuntu):
status:	Fix Committed → Fix Released

Revision history for this message

Mantas Kriaučiūnas (mantas) wrote on 2012-10-28:

"Installed-Size" header in most Ubuntu packages from main section is still incorrect, even in latest Ubuntu release - 12.10:

ubuntu@ubuntu:~$ dpkg -s ubuntu-docs|grep "Installed-Size"
Installed-Size: 44551

While actual size of all installed files is less than 2 megabytes !

Please reopen this bugreport.

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Bug attachments

Add attachment

Remote bug watches

Bug watches keep track of this bug in other bug trackers.

Ubuntupkgbinarymangler package

need to update Installed-Size header

Bug Description

Related branches

Other bug subscribers

Bug attachments

Remote bug watches

Ubuntu
pkgbinarymangler package