Distribution.serieses is sorted by debversion, but versions are sane_version
Bug #404613 reported by
Curtis Hovey
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Triaged
|
Low
|
Unassigned |
Bug Description
in the schema, distroseries.
This is wrong since a distro other than Ubuntu or Debian may choose rules that differ than debversion. The issue in the code appears to be sorting, so a better sort rule is needed, such as sorted_
Changed in launchpad-registry: | |
assignee: | Curtis Hovey (sinzui) → nobody |
tags: | added: tech-debt |
To post a comment you must log in.
Hi Celso.
I see you added the sort by Version() rule. The tests you modified pass when I switch to sorted_ version_ numbers which is used for milestones and releases to resolve string confusions in version. This change will make the code behave as the schema expects, while preserving the sorted order.
However, is the schema wrong? Since this code has been in place for 3 months, I think we know that all distroseries versions conform to debversion. Should they always? I can use debversion to ensure all distroseries versions (for all distros) are debversion compatible.