+addseries form does not validate version field

Bug #42809 reported by Diogo Matsubara
24
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Unassigned

Bug Description

Steps to reproduce:

1. http://localhost:8086/distros/ubuntu/+addseries
2. Fill in distribution info:
   - Name: distrox
   - Parent release: Warty
   - Version: invalid
   - Other fields: anything
3. When the page redirects it crashes:
    * Module canonical.launchpad.database.distribution, line 218, in __getitem__
      for release in self.releases:
    * Module canonical.cachedproperty, line 77, in __get__
      result = self.fn(inst)
    * Module canonical.launchpad.database.distribution, line 128, in releases
      return sorted(ret, key=lambda a: Version(a.version), reverse=True)
    * Module canonical.launchpad.database.distribution, line 128, in <lambda>
      return sorted(ret, key=lambda a: Version(a.version), reverse=True)
    * Module sourcerer.deb.version, line 85, in __init__
      raise BadUpstreamError(

BadUpstreamError: ('Bad upstream version format', 'invalid')

The same validator should also be used in +addseries as per bug 296958

Related branches

Changed in launchpad:
status: Unconfirmed → Confirmed
affects: launchpad-foundations → launchpad-registry
Changed in launchpad-registry:
importance: Medium → Low
tags: added: oem-services
description: updated
summary: - +addrelease form doesn't validate version field
+ +addrelease and +addseries form don't validate version field
Curtis Hovey (sinzui)
tags: added: story-release-planning
Curtis Hovey (sinzui)
summary: - +addrelease and +addseries form don't validate version field
+ +addseries form don't validate version field
summary: - +addseries form don't validate version field
+ +addseries form does not validate version field
Changed in launchpad-registry:
assignee: nobody → Curtis Hovey (sinzui)
milestone: none → 3.0
status: Triaged → In Progress
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: 3.0 → 2.2.8
Curtis Hovey (sinzui)
description: updated
Revision history for this message
Curtis Hovey (sinzui) wrote :

Fixed in launchpad devel r9025.

Changed in launchpad-registry:
status: In Progress → Fix Committed
Revision history for this message
Ursula Junque (ursinha) wrote :

Actually fixed in devel r9026.

Revision history for this message
Curtis Hovey (sinzui) wrote : Bug 42809 Fix released

Fixed released in launchpad-project 2.2.8.

Changed in launchpad-registry:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in launchpad:
assignee: Curtis Hovey (sinzui) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.