Alert when a computer needs to be restarted

The attached branch is based on account-get-computers linked in bug
#435013.

We need to add a patch to add and enable the alert for all existing
accounts and computers, but that can be done in a subsequent branch.

Nice and clean, +1!

[1]

+ """Alert activates when computers need to be rebooted."""

Maybe s/activates/activated/ ?

[2]

+ rule = self.account.create_rule(ComputerRebootAlert)

It looks like all tests eventually need this, what about moving it to self.setUp ? Or did you prefer not do it on purpose for better readability?

[3]

+ """
+ ComputerRebootAlert has a special email template displaying the list
+ of computers that require a reboot.
+ """

This test docstring is duplicated between test_email_notification and test_email_notification_with_many_computers.

Amazing! This looks like a really useful feature.

[1] Import order looks a bit odd here (I believe we always put functions last, at least I do. ;)

- ComputerOfflineAlert, check_offline_computers)
+ ComputerOfflineAlert, check_offline_computers, ComputerRebootAlert)

Other than that and Free's comments, nothing else to add. +1!

Free:

[1]

The docstring is correct as it is.

[2]

I didn't think about it explicitly, but yeah, I think it's nice to
have it near the test logic instead of in setUp.

[3]

Fixed.

Sidnei:

[1]

Fixed.

I've linked another branch to bug #438456 that adds a patch to add
the new rule to all accounts and enable it for all computers. I'll
land this branch when that one is ready to land.

Merged to landscape/trunk r1382 [r=free,sidnei].

verified in staging