[Jaunty] Disable unwanted staging builds
Bug #366144 reported by
Stefan Bader
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux (Ubuntu) |
Fix Released
|
Wishlist
|
Stefan Bader |
Bug Description
SRU justification:
Impact: Having CONFIG_STAGING enabled will descend into the staging directory on build time and compile anything which has a matching config option. However the intention was to include only selective drivers from within the ubuntu directory. There has already been one case where a shared option name between ubuntu and staging lead to random module inclusion.
Fix: Disable CONFIG_STAGING for good. Fix up all code to include selective drivers in staging from the ubuntu directories. This will give no functional change but makes sure we are certain which modules are getting build.
Testcase: Modules and ABI before and after the change are the same.
Changed in linux (Ubuntu): | |
status: | In Progress → Fix Committed |
tags: | removed: verification-needed |
To post a comment you must log in.
On doing test compiles on armel, too, it turns out rtl8187se is failing miserably on armel.versatile. This is (at least) due to:
1. rtl8187se defining CR_TE (along other CR_ defines) which is also defined in the versatile architecture.
This could be simply solved by removing the CR_ defines from rtl8187se as the names are never used.
2. Some headers are incomplete if CONFIG_WIRELESS_EXT is not set but the rtl8187se driver does not
depend on it (and armel.versatile just has this odd setup)
Attached patch for 2. as this will prevent armel.versatile from building rtl8187se. 1. is questionable as I was told that CONFIG_PCI=y might be the wrong thing anyway.