Ubuntu
consolekit package

Consolekit should allow GetSessions

Bug #338001 reported by Ted Gould
2
Affects Status Importance Assigned to Milestone
ConsoleKit
Fix Released
Medium
consolekit (Ubuntu)
Fix Released
Wishlist
Ted Gould

Bug Description

Binary package hint: consolekit

The ConsoleKit manager interface has a GetSessions function which is currently set to deny. The same information is available by calling GetSeats and then querying each seat for it's sessions. But, GetSessions is so much easier, we should allow people to call it.

See original description
Revision history for this message
In , Ted Gould (ted) wrote :

Created an attachment (id=23537)
Patch to policy

Revision history for this message
Ted Gould (ted) wrote :

Binary package hint: consolekit

The ConsoleKit manager interface has a GetSessions function which is currently set to deny. The same information is available by calling GetSeats and then querying each seat for it's sessions. But, GetSessions is so much easier, we should allow people to call it.

Revision history for this message
Ted Gould (ted) wrote :
Bug Watch Updater (bug-watch-updater)
Changed in consolekit:
status: Unknown → Confirmed
Sebastien Bacher (seb128)
Changed in consolekit:
importance: Undecided → Wishlist
Revision history for this message
Bryce Harrington (bryce) wrote :

Looks good, upload sponsored.

Changed in consolekit:
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package consolekit - 0.3-0ubuntu4

---------------
consolekit (0.3-0ubuntu4) jaunty; urgency=low

  * Adding debian/patches/12-allow-get-sessions.patch to allow for
    the GetSessions command to be called on the Manager interface. This
    saves the effort of calling GetSeats and then GetSessions on each
    of them. (LP: #338001)

 -- Ted Gould <email address hidden> Wed, 04 Mar 2009 13:59:45 -0600

Changed in consolekit:
status: Fix Committed → Fix Released
Revision history for this message
Bryce Harrington (bryce) wrote :
Download full text (28.9 KiB)

 * Source Package: consolekit
 * Version: 0.3-0ubuntu4
 * Architecture: i386
 * Archive: ubuntu primary archive
 * Component: main
 * State: Failed to build
 * Duration: four minutes
 * Build Log:
https://launchpad.net/ubuntu/+source/consolekit/0.3-0ubuntu4/+build/899402/+files/buildlog_ubuntu-jaunty-i386.consolekit_0.3
-0ubuntu4_FAILEDTOBUILD.txt.gz
 * Builder: https://launchpad.net/+builds/palmer
 * Source: https://launchpad.net/ubuntu/+source/consolekit/0.3-0ubuntu4

/usr/bin/xsltproc ../../doc/dbus/spec-to-docbook.xsl ../../src/org.freedesktop.ConsoleKit.Manager.xml | tail -n +2 > org.freedesktop.ConsoleKit.Manager.ref.xml
xsl:call-template: misplaced text element
/usr/bin/xmlto xhtml-nochunks -m ../../doc/dbus/config.xsl ConsoleKit.xml
xmlto: input does not validate (status 3)
/build/buildd/consolekit-0.3/doc/dbus/ConsoleKit.xml:40: element listitem: validity error : Element listitem content does not follow the DTD, expecting (calloutlist | glosslist | itemizedlist | orderedlist | segmentedlist | simplelist | variablelist | caution | important | note | tip | warning | literallayout | programlisting | programlistingco | screen | screenco | screenshot | synopsis | cmdsynopsis | funcsynopsis | classsynopsis | fieldsynopsis | constructorsynopsis | destructorsynopsis | methodsynopsis | formalpara | para | simpara | address | blockquote | graphic | graphicco | mediaobject | mediaobjectco | informalequation | informalexample | informalfigure | informaltable | equation | example | figure | table | msgset | procedure | sidebar | qandaset | anchor | bridgehead | remark | highlights | abstract | authorblurb | epigraph | indexterm | beginpage)+, got (CDATA)
/build/buildd/consolekit-0.3/doc/dbus/ConsoleKit.xml:43: element listitem: validity error : Element listitem content does not follow the DTD, expecting (calloutlist | glosslist | itemizedlist | orderedlist | segmentedlist | simplelist | variablelist | caution | important | note | tip | warning | literallayout | programlisting | programlistingco | screen | screenco | screenshot | synopsis | cmdsynopsis | funcsynopsis | classsynopsis | fieldsynopsis | constructorsynopsis | destructorsynopsis | methodsynopsis | formalpara | para | simpara | address | blockquote | graphic | graphicco | mediaobject | mediaobjectco | informalequation | informalexample | informalfigure | informaltable | equation | example | figure | table | msgset | procedure | sidebar | qandaset | anchor | bridgehead | remark | highlights | abstract | authorblurb | epigraph | indexterm | beginpage)+, got (CDATA)
/build/buildd/consolekit-0.3/doc/dbus/ConsoleKit.xml:46: element listitem: validity error : Element listitem content does not follow the DTD, expecting (calloutlist | glosslist | itemizedlist | orderedlist | segmentedlist | simplelist | variablelist | caution | important | note | tip | warning | literallayout | programlisting | programlistingco | screen | screenco | screenshot | synopsis | cmdsynopsis | funcsynopsis | classsynopsis | fieldsynopsis | constructorsynopsis | destructorsynopsis | methodsynopsis | formalpara | para | simpara | address | blockquote | graphic | graphicco | mediaobject | mediaobje...

Changed in consolekit:
assignee: nobody → ted-gould
status: Fix Released → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package consolekit - 0.3.0-2ubuntu1

---------------
consolekit (0.3.0-2ubuntu1) jaunty; urgency=low

  * Merge with Debian unstable:
    - Some packaging fixes.
    - Fix current FTBFS due to invalid documentation XML. (LP: #338001)
  * Remaining Ubuntu changes:
    - debian/consolekit.preinst: Remove obsolete conffile on upgrade. This
      needs to be kept until after next LTS.
    - PolicyKit support:
      + debian/control: Build-depend on libpolkit-dev.
      + debian/consolekit.install: Install PolicyKit policy.

consolekit (0.3.0-2) unstable; urgency=low

  * debian/consolekit.prerm
    - Stop console-kit-daemon upon package removal (using start-stop-daemon).
      (Closes: #518346)

consolekit (0.3.0-1) unstable; urgency=low

  * New upstream release.
  * debian/patches/01-dbus_policy.patch
    - Removed, the access to the restart and stop actions is now properly
      restricted by checks in the source code.
  * debian/patches/02-exit_with_dbus.patch
    - Removed, merged upstream.
  * debian/patches/05-dbus_policy.patch
    - Updated by pulling latest patch from upstream Git.
  * debian/patches/06-xmlto_skip_validation.patch
    - Skip XML validation when generating the documentation. (Closes: #516253)
      A proper fix will be, to make ConsoleKit.xml actually valid XML.
  * debian/consolekit.docs
    - Update path to spec html file.
  * Merge patches from Ubuntu
    - debian/patches/04-consolekit_park.patch (Closes: #489032)
    - debian/patches/05-pam-add-nox11.patch
    - debian/patches/08-fix-double-close.patch
    - debian/patches/09-directory-handle-leak.patch (Closes: #516532)
    - debian/patches/10-file_monitor_remove_watch_crash.patch
    - debian/patches/11-unref-dbus-proxy.patch
    - debian/patches/12-allow-get-sessions.patch
  * debian/control
    - Wrap Build-Depends.
    - Bump Build-Depends on debhelper to (>= 7).
  * debian/compat
    - Bump debhelper compat level to 7.
  * Fix FTBFS on GNU/kFreeBSD. (Closes: #511270)
    - debian/patches/80-gnukfreebsd_support_configure.ac.patch
      debian/patches/81-gnukfreebsd_support_pseudo_run_autoconf.patch
      + Add kfreebsd target to configure(.ac) script
    - debian/control
      + Add libkvm-dev to Build-Depends on kfreebsd ports.
    Patch by Luca Favatella, thanks.
  * debian/libpam-ck-connector.{pam-auth-update,install,postinst,prerm},
    debian/rules: enable pam_ck_connector by default using the new
    pam-auth-update support.
  * debian/control: depend on libpam-runtime (>= 1.0.1-6) for the above.

 -- Martin Pitt <email address hidden> Mon, 16 Mar 2009 11:24:40 +0100

Changed in consolekit:
status: In Progress → Fix Released
Revision history for this message
In , Vincent Untz (vuntz) wrote :

Created an attachment (id=24665)
Updated patch (to master)

Revision history for this message
In , William Jon McCann (william-jon-mccann) wrote :

(From update of attachment 24665)
Sure. Looks fine. Please commit. Thanks.

Revision history for this message
In , Ray Strode (halfline) wrote :

Committed.

Bug Watch Updater (bug-watch-updater)
Changed in consolekit:
status: Confirmed → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in consolekit:
importance: Unknown → Medium
Bug Watch Updater (bug-watch-updater)
Changed in consolekit:
importance: Medium → Unknown
Bug Watch Updater (bug-watch-updater)
Changed in consolekit:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.