Ubuntu
nautilus package

Nautilus won't allow changing the icon of a launcher

Bug #336679 reported by pablomme on 2009-03-02

Affects		Status	Importance	Assigned to	Milestone
	nautilus (Ubuntu)	Fix Released	Medium	Ubuntu Desktop Bugs	Ubuntu ubuntu-9.04-beta

Bug Description

Binary package hint: nautilus

This is the continuation of bug #326444; I suspect the fix to that bug introduced this one.

I installed Jaunty from the Alpha5 liveCD. If I try to change the icon of an application launcher on the desktop, the icon won't change. E.g., if I try to set JAMin's icon to the correct pixmap, the following appears in jamin.desktop:

Icon[en_GB]=/usr/share/jamin/pixmaps/JAMin_icon.xpm

alongside the original

Icon=jamin.svg

This results in no icon change. If I edit the file by hand and delete the original line, no icon change either. If I delete both lines and add

Icon=/usr/share/jamin/pixmaps/JAMin_icon.xpm

the icon change becomes effective.

I would think that the icon should not be locale-dependent. Changing the name of the executable works fine, so this is specific to the icon property.

Nautilus is currently at version 1:2.25.91-0ubuntu1.

Related branches

lp://staging/ubuntu/lucid/nautilus

Revision history for this message

Sebastien Bacher (seb128) wrote on 2009-03-02:

thank you for your bug report, assigning to pitti who worked on those changes

Changed in nautilus:
assignee:	nobody → pitti
importance:	Undecided → Medium
milestone:	none → ubuntu-9.04-beta
status:	New → Confirmed

Revision history for this message

Sebastien Bacher (seb128) wrote on 2009-03-02:

that's rather a gnome-desktop issue

Revision history for this message

A. Walton (awalton) wrote on 2009-03-02:

dont-localize-icon-keys.diff Edit (1.9 KiB, text/x-diff)

It's a Nautilus issue. Patch attached.

Revision history for this message

Sebastien Bacher (seb128) wrote on 2009-03-02:

thanks awalton! will you fix the issue upstream now? any reason why the localized icon name should not be used?

Changed in gnome-desktop:
assignee:	pitti → desktop-bugs
status:	Confirmed → Fix Committed

Revision history for this message

A. Walton (awalton) wrote on 2009-03-02:

Should go upstream, but I'm at work.

The spec says that the string should be a localestring, but I don't think Nautilus has ever supported that, and I personally don't see much reason for it. If we want to turn it into a feature request for the next version, we could do that... But this should get things working for the upcoming release.

Revision history for this message

Martin Pitt (pitti) wrote on 2009-03-02:

Thanks for the patch!

I subscribed ubuntu-main-sponsors so that it doesn't get lost. However, we should wait a bit, so that it'll just trickle through a new upstream release.

Revision history for this message

pablomme (pablomme) wrote on 2009-03-03:

Thanks for the quick patching.

Another issue with .desktop files has sprung out on nautilus 1:2.25.92-0ubuntu1. If the second line of the .desktop file is a comment, the file is not recognized as a launcher but as a script, complete with text thumbnail icon and Run-or-Display dialogue on double-click.

This happens for instance with the Kdenlive launcher, which starts:

#!/usr/bin/env xdg-open
# KDE Config File
[Desktop Entry]
...

If I empty or entirely remove the second line, the launcher is recognized again.

Sorry for the unrelated bug report, I'll file a new one if you wish, but it seems that the right people are listening here.

Revision history for this message

A. Walton (awalton) wrote on 2009-03-03:

Please file separate bugs for separate problems.

Revision history for this message

A. Walton (awalton) wrote on 2009-03-03:

Committed upstream
2009-03-02 A. Walton <awalton@>

* libnautilus-private/nautilus-link.c
(nautilus_link_local_set_key),
(nautilus_link_local_set_text),
(nautilus_link_local_set_icon):
Don't localize 'Icon=' keys.
Fixes Launchpad Bug #336679.

Revision history for this message

pablomme (pablomme) wrote on 2009-03-03:

#10

Sorry, I should have done that straight away. See bug #337408.

Revision history for this message

Sebastien Bacher (seb128) wrote on 2009-03-04:

#11

unsubscribing the sponsor since the change is in svn and will be in 2.26 no hurry to backport it now

Revision history for this message

Launchpad Janitor (janitor) wrote on 2009-03-11:

#12

This bug was fixed in the package nautilus - 1:2.25.93-0ubuntu1

---------------
nautilus (1:2.25.93-0ubuntu1) jaunty; urgency=low

  * New upstream version:
    - Use ConsoleKit to make sure we only autorun on active sessions
      (lp: #222643)
    - Never show unmount if we show an eject menu item
    - Show the gvfs reported owner/group names (lp: #307530)
    - Don't allow changing default app for folders
    - Fix "can't unmount same location twice" bug
    - Don't write translated icon names (lp: #336679)
    - Really fix crasher on renaming (lp: #321359)
    - Correctly store geometry (lp: #326276)
    - Correctly recognize desktop files which have comments (lp: #337408)