nspluginwrapper creates "default" links even though NSPLUGINDIR is set

Bug #321814 reported by Alexander Sack
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
flashplugin-nonfree (Ubuntu)
Invalid
Undecided
Unassigned
Jaunty
Invalid
Undecided
Unassigned
nspluginwrapper (Ubuntu)
Fix Released
High
Saša Bodiroža
Jaunty
Fix Released
High
Saša Bodiroža

Bug Description

Binary package hint: nspluginwrapper

in jaunty after removing flashplugin-nonfree there are a few dangling links:

11:49 < BUGabundo> ls: cannot access /usr/lib/flashplugin-nonfree/libflashplayer.so: No such file
                   or directory
11:49 < BUGabundo> ls: cannot access /var/lib/flashplugin-nonfree/npwrapper.libflashplayer.so: No
                   such file or directory
11:49 < BUGabundo> lrwxrwxrwx 1 root root 57 2009-01-27 10:39
                   /usr/lib/iceweasel/plugins/npwrapper.libflashplayer.so ->
                   /var/lib/flashplugin-nonfree//npwrapper.libflashplayer.so
11:49 < BUGabundo> lrwxrwxrwx 1 root root 57 2009-01-27 10:39
                   /usr/lib/mozilla/plugins/npwrapper.libflashplayer.so ->
                   /var/lib/flashplugin-nonfree//npwrapper.libflashplayer.so

Those links shouldnt get created by the package in the first place; I know for sure that this didn't happen a while back, so probably is a regression for our NSPLUGINDIR= support patch.

Revision history for this message
Alexander Sack (asac) wrote :

cluttering FSH ... high imo.

Changed in nspluginwrapper:
importance: Undecided → High
status: New → Triaged
Revision history for this message
Fernando Miguel (fernandomiguel) wrote :

$ apt-cache policy flashplugin-nonfree
flashplugin-nonfree:
  Installed: (none)
  Candidate: 10.0.15.3ubuntu2
  Version table:
     10.0.15.3ubuntu2 0
        500 ftp://darkstar.ist.utl.pt jaunty/multiverse Packages
        500 ftp://archive.ubuntu.com jaunty/multiverse Packages
        100 /var/lib/dpkg/status

Revision history for this message
Alexander Sack (asac) wrote :

release blocker.

Changed in nspluginwrapper:
milestone: none → jaunty-alpha-6
Revision history for this message
Alexander Sack (asac) wrote :

... well, as much as universe packages can block releases.

Revision history for this message
Martin Pitt (pitti) wrote :

Alex, please fix, delegate to someone, or unmark as release blocker. (Release blockers need to have an assignee).

Changed in nspluginwrapper:
assignee: nobody → asac
Revision history for this message
Saša Bodiroža (jazzva) wrote :

I'll fix it later tonight, or tomorrow if that's not too late. Sorry for the delay, I was supposed to fix it in the first place.

Changed in nspluginwrapper:
assignee: asac → jazzva
Revision history for this message
Saša Bodiroža (jazzva) wrote :

I attached the branch that contains partial fix for this bug. I removed the Iceweasel dir from debian/patches/000_debian_make_symlinks.diff and it doesn't create links /usr/lib/iceweasel/plugins anymore.

Revision history for this message
Saša Bodiroža (jazzva) wrote :

Also, it seems this bug is located in flashplugin-nonfree's prerm script. nspluginwrapper is called in its postinst script and the wrapper is installed. The call to nspluginwrapper to uninstall the wrapper is missing in flashplugin-nonfree's prerm script. I added the f-n task to the bug report.

Revision history for this message
Saša Bodiroža (jazzva) wrote :

There is a part in debian/patches/000_debian_make_symlinks.diff which is used to install these default symlinks. We can remove it and just use NSPLUGIN_DIR env var, or keep it and add "nspluginwrapper -r" call in flashplugin-nonfree's prerm script. Alexander, if I understood correctly, we don't need the default symlinks. If that's correct, I think we can safely drop that part.

Revision history for this message
Steve Langasek (vorlon) wrote :

This bug is still open, after alpha-6. What needs to be happen here?

Changed in nspluginwrapper:
milestone: jaunty-alpha-6 → ubuntu-9.04-beta
Revision history for this message
Saša Bodiroža (jazzva) wrote :

I have pushed a new revision that contains the fix for this bug. It will not install wrappers to default dirs if NSPLUGIN_DIR environment variable is specified.

Alexander, I'll open a new bug for implementation of list_plugins which take those nspluginwrapper's meta-files in consideration.

Changed in flashplugin-nonfree (Ubuntu Jaunty):
status: New → Invalid
Revision history for this message
Steve Langasek (vorlon) wrote :

Pushed where? It's not in the authoritative bzr branch, and it's not in the beta freeze queue.

Revision history for this message
Saša Bodiroža (jazzva) wrote :

I pushed it to the branch linked to this bug report [1]. If I understood correctly, beta freeze applies only to the packages in main and restricted. nspluginwrapper is in multiverse.

[1] <https://code.edge.launchpad.net/~jazzva/nspluginwrapper/ubuntu.1.2.2-0ubuntu2>

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package nspluginwrapper - 1.2.2-0ubuntu2

---------------
nspluginwrapper (1.2.2-0ubuntu2) jaunty; urgency=low

  * Remove Iceweasel dir from debian/patches/000_debian_make_symlinks.diff
  * Update patch debian/patches/002_install_to_NSPLUGINDIR.diff to not install
    wrappers in default paths if NSPLUGIN_DIR is specified (LP: #321814)
  * Refresh patches

 -- Sasa Bodiroza <email address hidden> Thu, 19 Mar 2009 21:42:35 +0100

Changed in nspluginwrapper:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.