Silva

Adding a realtive links with query parameter cuts everything after "?"

Bug #263503 reported by Nico Grubert
2
Affects Status Importance Assigned to Milestone
Silva
Fix Released
Undecided
Unassigned
Silva 2.1

Bug Description

I want to add a link in kupu with a query parameter.
I type for example "/phonebook/index_DE?name=miller" in the link field and click the "add link" button.
The problem is:
If I save the document, the link changes to "/phonebook/index_DE".
If I use a absolute path "http://www.mydomain.com/phonebook/index_DE?name=miller" everything works fine.

It seems that kupu and also forms editor cuts everything after the "?" if one uses relative links.

If I use URL encoded links instead, it works fine.
Example: /phonebook/index_DE/%3Fsearch_name%3Dmiller

But I don't want our editors encode the the "?" and "=".

I have installed Silva 1.4.x, 2.0.8 and 2.1 and in all these versions this bug occurs.

Revision history for this message
Andy Altepeter (aaltepet) wrote :

I've done some work on the kupu portion of this. Silva's path adapter supports fragments (e.g. #anchor) but not queries. The path adapter now supports queries, but I still need to test the pathadapter tests, and check the widgets-based editor, and the widgets renderer and xslt renderers.

Changed in silva:
assignee: nobody → aaltepet
Revision history for this message
Andy Altepeter (aaltepet) wrote :

The widgets editor work fine -- it uses the path adapter to convert links.

The xslt renderer and the public widgets renderer do not use the path adapter all, but (and) they do work with the situations described above. These two renderers have verbatim copies of the same public link rendering code, and I wonder if this code could be consolidated or even removed in favor of just the path adapter. I'm creating a new case to discuss this possibility.

Revision history for this message
Andy Altepeter (aaltepet) wrote :

This is fixed, and will be released in Silva 2.1.1

Changed in silva:
milestone: none → 2.1
status: New → Fix Committed
Andy Altepeter (aaltepet)
Changed in silva:
assignee: aaltepet → nobody
Andy Altepeter (aaltepet)
Changed in silva:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.