missingok does not work

This leads to accumulation of large quantities of log files, raising severity.

This does not affect dapper and edgy, and is confirmed to affect hardy and intrepid. Feisty and Gutsy need to be investigated.

Feisty and Gutsy are also affected by this bug.

This not only accumulate log files but this leads to a completely unnoticed failure of the log rotation system. A quick & dirty fix is to replace the "return 1" at line 971 in config.c with a "continue" .

According to https://bugzilla.redhat.com/show_bug.cgi?id=166510 this has been fixed in FC6 logrotate-3.7.4-10.fc6, and rawhide logrotate-3.7.4-11.fc7 nearly 2 years ago.

Backporting those changes is a huge work and upgrading to the latest version would definitely be the right solution.

Raising severity, this breaks other packages' log rotation.

Jean-Baptiste, I looked through the code a bit, and I didn't find a better solution than your's either (except for very intrusive changes). I'll apply the change you suggested.

This bug was fixed in the package logrotate - 3.7.1-3ubuntu2

---------------
logrotate (3.7.1-3ubuntu2) intrepid; urgency=low

  * Add debian/patches/glob-failure.patch: Prevent logrotate from failing
    completely if one glob in any included file fails. This more or less
    behaves like an implied # "missingok" now, which isn't correctly parsed in
    the current version. Fixing it properly is a very intrusive change.
    (LP: #256891)

 -- Martin Pitt <email address hidden> Wed, 08 Oct 2008 13:59:23 +0200

Whoops, forgot to credit you in the changelog.

This bug was fixed in the package logrotate - 3.7.1-3ubuntu3

---------------
logrotate (3.7.1-3ubuntu3) intrepid; urgency=low

  * Argh, forgot to credit the patch author in previous upload, updated
    changelog.

logrotate (3.7.1-3ubuntu2) intrepid; urgency=low

  * Add debian/patches/glob-failure.patch: Prevent logrotate from failing
    completely if one glob in any included file fails. This more or less
    behaves like an implied # "missingok" now, which isn't correctly parsed in
    the current version. Fixing it properly is a very intrusive change.
    (LP: #256891) Thanks to Jean-Baptiste Lallement for analyzing the problem
    and proposing the patch!

 -- Martin Pitt <email address hidden> Wed, 08 Oct 2008 14:07:33 +0200

Fix for hardy uploaded, waiting for Steve to accept now.

For the record, the upstream test suite still passes with the patch applied, and the SRU test case now succeeds for me.

Feisty will go end of live in some two weeks, not worth the trouble any more.

gutsy update uploaded, too (same version as for hardy, just with different version number)

I rejected the current hardy and gutsy uploads, I just got a better fix for Intrepid (from Debian) which I am going to test first.

This is the new patch. The essential idea is the same (replace the "return 1" with a "continue"), but with better error reporting.

Also, the patch ensures that logrotate keeps stopping completely if "missingok" is *not* specified, to not change behaviour in that case.

Updated logrotate packages uploaded to hardy/gutsy-proposed, waiting for approval.

Accepted into -proposed, please test and give feedback here. Please see https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Accepted into gutsy-proposed as well.

Verified that the gutsy-proposed package resolves the issue on Gutsy.

Copied to -updates.