Ctrl/Cmd+(Shift)+Z: Undo/Redo

Bug #204366 reported by sander
2
Affects Status Importance Assigned to Milestone
Coccinella
Fix Released
Wishlist
Mats

Bug Description

These 2 related commands are missing for text and input fields:
1) Ctrl/Cmd+Z: Undo the latest changes to a text. The user can enter this command multiple times.
2) Ctrl/Cmd+Shift+Z: Redo the latest undone changes; reverse of Undo

PS: these commands would be also interesting in the whiteboard...you can add this feature there at once, or I can open a new bug entry for these commands in the whiteboard.

sander (s-devrieze)
Changed in coccinella:
assignee: nobody → matsben
importance: Undecided → Wishlist
description: updated
Revision history for this message
Mats (matsben) wrote : Re: [Bug 204366] [NEW] Ctrl/Cmd+(Shift)+Z: Undo/Redo

The whiteboard already has Undo/Redo. At least on Mac.
The text widget has some built in support for this
http://tcl.tk/man/tcl8.5/TkCmd/text.htm#M81
Any idea what the keybindings shall be? Mac has Command-Z for undo and
missing key binding for redo.

Revision history for this message
sander (s-devrieze) wrote :

> Any idea what the keybindings shall be? Mac has Command-Z for undo and
> missing key binding for redo.

Missing? On Tiger I can de Command + Shift + Z for redo...

Revision history for this message
Mats (matsben) wrote :

Added Shift-Z binding for redo in canvas.
Must read up on how this works for the text widget.

Revision history for this message
Mats (matsben) wrote :

Added some test code for the Message text widget. Not exactly sure how it works. It seems to add the separators at newlines.

Changed in coccinella:
status: New → In Progress
Revision history for this message
Mats (matsben) wrote :

There already was undo/redo in text but that wasn't activated. A simple -undo 1 was essentially all that was needed. Also sets new separators, fix Mac Edit menu and so on.

Changed in coccinella:
milestone: none → 0.96.8
status: In Progress → Fix Committed
Revision history for this message
sander (s-devrieze) wrote :

This does not work with the latest cvs version on OS X 10.4...

Revision history for this message
Mats (matsben) wrote :

It seems that I was slightly too slow to fix a remaining issue and you was slightly too fast to test it:

revision 1.285
date: 2008/03/25 16:12:35; author: matben; state: Exp; lines: +3 -3
 * Forgot the -undo 1 switch.
----------------------------
revision 1.284
date: 2008/03/25 14:54:25; author: matben; state: Exp; lines: +2 -1
 * Added missing toolbar button for Mac in NewMsg.
 * Bug #204366, Ctrl/Cmd+(Shift)+Z: Undo/Redo
   Added to Edit menu and added undo separators for spaces etc.

Revision history for this message
sander (s-devrieze) wrote :

It still does not work in the Subject field.

Revision history for this message
Mats (matsben) wrote : Re: [Bug 204366] Re: Ctrl/Cmd+(Shift)+Z: Undo/Redo
  • unnamed Edit (222 bytes, text/html; charset=ISO-8859-1)

It only applies to text widgets and not to entry widgets like the subject
field. There is no undo stack for entry widgets. If I test Cmd-Z in the
Safari address field it just erases the complete line. Not much of an undo.

Revision history for this message
sander (s-devrieze) wrote :

1) Subject field != address bar in a browser
2) Even erasing the whole line like how it does in Safari does not work in Coccinella

Revision history for this message
Mats (matsben) wrote :
  • unnamed Edit (937 bytes, text/html; charset=ISO-8859-1)

On Sat, Mar 29, 2008 at 2:21 PM, sander <email address hidden> wrote:

> 1) Subject field != address bar in a browser

It's the same type of widget.

>
> 2) Even erasing the whole line like how it does in Safari does not work in
> Coccinella

I was just questioning the usefulness of it. It could be added to the tk
tracker if you want, but the redo is slightly more complex since I need an
instance variable which isn't so easy in these bindings, but doable, of
course.

sander (s-devrieze)
Changed in coccinella:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.