Ubuntu
cryptsetup package

cryptroot-* autopkgtests fail on Ubuntu

Bug #1983522 reported by Benjamin Drung
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cryptsetup (Ubuntu)
Fix Released
High
Vladimir Petko

Bug Description

Running the autopkgtests from a merged cryptsetup 2:2.5.0-1 fails on Ubuntu 22.10 (kinetic):

autopkgtest [19:12:00]: @@@@@@@@@@@@@@@@@@@@ summary
upstream-testsuite PASS
ssh-test-plugin PASS
cryptdisks PASS
cryptdisks.init PASS
cryptroot-lvm FAIL non-zero exit status 100
cryptroot-legacy FAIL non-zero exit status 100
cryptroot-sysvinit FAIL non-zero exit status 100

The cryptroot-* autopkgtest call `setup_apt` which is tailored to Debian and fails on Ubuntu:

E: Unable to locate package apt

A full test log (run locally with a qemu autopkgtest runner) is attached.

Related branches

~vpa1977/ubuntu/+source/cryptsetup:merge-lp2019292-mantic
Steve Langasek (community): Approve
git-ubuntu import: Pending requested
Diff: 2664 lines (+2034/-27)
15 files modified
debian/changelog (+1857/-0)
debian/control (+7/-5)
debian/functions (+9/-1)
debian/initramfs/cryptroot-unlock (+12/-6)
debian/initramfs/hooks/cryptroot (+5/-3)
debian/patches/decrease_memlock_ulimit.patch (+49/-0)
debian/patches/series (+1/-0)
debian/rules (+2/-0)
debian/tests/control (+3/-2)
debian/tests/cryptroot-lvm.d/mock (+7/-2)
debian/tests/cryptroot-nested.d/config (+7/-0)
debian/tests/cryptroot-sysvinit.d/config (+7/-2)
debian/tests/initramfs-hook (+16/-2)
debian/tests/utils/cryptroot-common (+27/-3)
debian/tests/utils/mock.pm (+25/-1)
Revision history for this message
Benjamin Drung (bdrung) wrote :
Revision history for this message
Brian Murray (brian-murray) wrote :

Not only do they fail, they end up timing out which is a waste of resources so this should not be run anymore.

tags: added: update-excuse
Revision history for this message
Brian Murray (brian-murray) wrote :

I've gone ahead and added the package to never_run for Jammy and Kinetic:

https://git.launchpad.net/~ubuntu-release/autopkgtest-cloud/+git/autopkgtest-package-configs/commit/?id=fecfec0951e02ed7e59f42aa8ad996157784e42e

Revision history for this message
Brian Murray (brian-murray) wrote (last edit ):

I've tagged this foundations-triage-discuss as I think fixing the autopkgtests should be a priority given that the package is in main.

Changed in cryptsetup (Ubuntu):
status: New → Confirmed
importance: Undecided → High
tags: added: foundations-triage-discuss
Benjamin Drung (bdrung)
tags: added: foundations-todo
removed: foundations-triage-discuss
Vladimir Petko (vpa1977)
Changed in cryptsetup (Ubuntu):
assignee: nobody → Vladimir Petko (vpa1977)
status: Confirmed → In Progress
Revision history for this message
Vladimir Petko (vpa1977) wrote :

Fixed common code and crypt-sysvinit test - branch available at https://code.launchpad.net/~vpa1977/+git/cryptsetup/+ref/vpa1977/lp1983522-enable-sysvinit-test and ppa at https://code.launchpad.net/~vpa1977/+archive/ubuntu/cryptsetup-fix

Looking into fixing initramfs-hook test, there is a difference in layout of initramfs that needs to be accounted for.

Revision history for this message
Vladimir Petko (vpa1977) wrote :

Need to fix blowfish test for initramfs-hook, rest are passing locally in a branch.
Should finish tomorrow.

Revision history for this message
Vladimir Petko (vpa1977) wrote :

We had to disable cryptdisks test due to it using tty device which is not present in CI environment.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cryptsetup - 2:2.5.0-6ubuntu2

---------------
cryptsetup (2:2.5.0-6ubuntu2) lunar; urgency=medium

  * Fix cryptroot-* autopkgtests on Ubuntu. (LP: #1983522)
    - debian/tests/utils/cryptroot-common: fix apt source and kernel package
      names for Ubuntu
    - debian/tests/cryptroot-sysvinit.d: use systemd-sysv init for Ubuntu
      cryptroot-sysvinit package test
    - debian/tests/cryptroot-nested.d: fix cryptsetup-nested test, add
      workaround for LP1831747 by adding a e2fsprogs dependency
    - debian/tests/control: disable cryptdisks, cryptroot-lvm due to CI
      failures and update comments
    - debian/tests/utils/mock.pm: fix cryptoroot-lvm test adding retries to the
      suspend operation and consuming the console buffer before making
      assertions. It still hangs in CI and requires further work.
    - debian/tests/initramfs-hook: fix test's initramfs layout for Ubuntu and
      allow blowfish test use 64Mb of provisioned space (drop --size)

 -- Vladimir Petko <email address hidden> Fri, 02 Dec 2022 14:14:42 +1300

Changed in cryptsetup (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Re-opening to track fix for cryptroot-lvm test.

Changed in cryptsetup (Ubuntu):
status: Fix Released → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cryptsetup - 2:2.5.0-6ubuntu3

---------------
cryptsetup (2:2.5.0-6ubuntu3) lunar; urgency=medium

  * Fix cryptroot-lvm autopkgtest on Ubuntu. (LP: #1983522)
    - debian/tests/control: enable cryptroot-lvm
    - debian/tests/utils/mock.pm: return from consume() function if select()
      times out or fails

 -- Vladimir Petko <email address hidden> Fri, 02 Dec 2022 15:53:42 +1300

Changed in cryptsetup (Ubuntu):
status: In Progress → Fix Released
Benjamin Drung (bdrung)
tags: removed: foundations-todo
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.