SRU fwupd to 1.7.9 for jammy and focal: Getting wrong hwids by "sudo fwupdtool hwids"

Did you update the firmware between pass and fail? Or really just update the fwupd version?

@Richard

Yes, if the HWID correct, the update process could be done.
in the fail case, the HW ID doesn't match. cause the process stop.
"no HWIDs matche d09cbbed7-aafc-5da4-b4e9-ed1f69c914fb|caa05e67-8a4f-5051-aa9e-c3968534e2ee"

To me this looks to be some regression related to parsing smbios structures. Look at the get-devices output and you can see the product name changed at the top too.

Any chance you can try with 1.8.2? There is a snap for it that should make it easy to check with.

Unfortunately the smbios data structure doesn't come with the sosreport.
So can you please share /sys/firmware/dmi/tables/DMI

That should hopefully make this easier to reproduce away from this machine. @hughsie, BTW maybe we want to be dumping this part of the emulation profile stuff too in addition to HSI and devices.

I tried to upgrade v1.8.2, reading hwids of the BIOS info still incorrect by "sudo".

@Mario

# fwupdtool smbios-dump foo.bin
Failed to open file “foo.bin”: No such file or directory

smbios-dump FILE Dump SMBIOS data from a file
What's the BIOS file should I dump.

Sorry - my mistake, I meant to share SMBIOS DMI file:
/sys/firmware/dmi/tables/DMI

copy from /sys/firmware/dmi/tables/DMI

#fwupdtool smbios-dump DMI

Can you add smbios_entry_point as well?
This is for reproducing using something like:
# sudo FWUPD_SYSFSFWDIR=./foo fwupdtool --verbose hwids

Max - can you please try this patch?
https://github.com/fwupd/fwupd/pull/4853

@Mario,

Thanks. the fwupdtool can get the correct data after apply the patch#16.

https://launchpad.net/~os369510/+archive/ubuntu/lp1982103

Verify pass that upgrading BIOS from 0x1080100 to 0x1090100 by #fwupdmgr upgrade

Okay thanks. The plan is new release upstream on Monday and will fix in kinetic then.

At least For Jammy, I think if you are going to have to SRU anyway, it's probably better to pick up that new release too. All the other confirmed bugs with open jammy tasks should be fixed too.

(https://bugs.launchpad.net/ubuntu/jammy/+source/fwupd/+bugs?field.searchtext=&orderby=-importance&search=Search&field.status%3Alist=NEW&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=FIXCOMMITTED&assignee_option=any&field.assignee=&field.bug_reporter=&field.bug_commenter=&field.subscriber=&field.component-empty-marker=1&field.tag=&field.tags_combinator=ANY&field.status_upstream-empty-marker=1&field.upstream_target=&field.has_cve.used=&field.omit_dupes.used=&field.omit_dupes=on&field.affects_me.used=&field.has_patch.used=&field.has_branches.used=&field.has_branches=on&field.has_no_branches.used=&field.has_no_branches=on&field.has_blueprints.used=&field.has_blueprints=on&field.has_no_blueprints.used=&field.has_no_blueprints=on)

The attachment "0002-fu-smbios-Fix-parsing-smbios-data.kinetic.debdiff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

This bug was fixed in the package fwupd - 1.8.3-1

---------------
fwupd (1.8.3-1) unstable; urgency=medium

  * New upstream version (1.8.3)
  * Drop COD patch
  * Fixes HWIDs for some systems (LP: #1982103)

 -- Mario Limonciello <email address hidden> Fri, 22 Jul 2022 07:04:23 -0500

I prepare a ppa for focal with the patch. Please kindly test it.
(Note it also includes a fix to lp:1980334, so it also upgrades libxmlb)

If it works well, I plan to use it for SRU to focal.

https://launchpad.net/~ycheng-twn/+archive/ubuntu/fwupd-focal-mm1

Please use this ppa that go fwupd 1.7.9 instead:

https://launchpad.net/~ycheng-twn/+archive/ubuntu/focal-fwupd179-2

For jammy, please test it from https://launchpad.net/~ycheng-twn/+archive/ubuntu/fwupd-jammy-2

I think #1969976 should be added to your changelog too, that should have been fixed both in 1.7.x and 1.8.x I would have expected.

#1982103 should be added to your jammy changelog too.

And I think #1966364 will probably be fixed by both too.

The fwupd is works on jammy.
https://launchpad.net/~ycheng-twn/+archive/ubuntu/fwupd-jammy-2

SUT:HP ZBook Fury 17.3 inch G8 Mobile Workstation PC
BIOS:T95 0x01080100 to 0x01090b00

u@ubuntu:~$ sudo fwupdmgr upgrade
Devices with no available firmware updates:
 • ELAN0750:00 04F3:313A
 • MZVLB512HBJQ-000H1
 • MZVLB512HBJQ-000H1
 • MZVLB512HBJQ-000H1
 • MZVLB512HBJQ-000H1
 • UEFI Device Firmware
 • UEFI Device Firmware
 • UEFI dbx
Devices with the latest available firmware version:
 • Prometheus
 • Prometheus IOTA Config
╔══════════════════════════════════════════════════════════════════════════════╗
║ Upgrade System Firmware from 0x01080100 to 0x01090b00? ║
╠══════════════════════════════════════════════════════════════════════════════╣
║ Fixes and enhancements in System firmware 1.9.11.0: ║
║ ║
║ This stable release fixes the following issues: ║
║ ║
║ Some new functionality has also been added: ║
║ ║
║ HP ZBook Fury 17 G8 must remain plugged into a power source for the ║
║ duration of the update to avoid damage. ║
╚══════════════════════════════════════════════════════════════════════════════╝

Perform operation? [Y|n]: y
Downloading… [***************************************]
Downloading… [***************************************]
Decompressing… [***************************************]
Authenticating… [***************************************]
Waiting… [***************************************]
Writing… [***************************************]
Waiting… [***************************************]
Waiting… [***************************************]
Successfully installed firmware

An update requires a reboot to complete. Restart now? [y|N]:y

So, fwupd has a stable release exception, which makes the jammy upgrade to 1.8.3 potentially an acceptable SRU.

However, this upload hasn't followed the process for the exception documented here: https://wiki.ubuntu.com/firmware-updates

Either one of these bugs should be turned into the 1.8.3 tracking bug, or a new tracking bug should be filed and a new upload (to jammy-proposed) made referencing that bug.

I update bug lp:1979963 and I think it could be the
1.8.3 SRU tracking bug.

Please kindly share if anything else is missing.

Hello Max, or anyone else affected,

Accepted fwupd into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupd/1.8.3-1~22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

All autopkgtests for the newly accepted fwupd (1.8.3-1~22.04.1) for jammy have finished running.
The following regressions have been reported in tests triggered by the package:

fwupd/1.8.3-1~22.04.1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/jammy/update_excuses.html#fwupd

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

As fwupd 1.8.3 is removed from jammy-proposed due to certain issue, the SRU
team suggests us to SRU to fwupd 1.7.9 on Jammy for now.

Given so, here is the fwupd 1.7.9 ppa for Jammy.

https://launchpad.net/~ycheng-twn/+archive/ubuntu/jammy-fwupd179-1

As the libxmlb and modemmanger version in Jammy is updated enough, we
don't need to rebuild other deb in Jammy.

BTW: the last ppa for focal, on this bug is here if you want to test:

https://launchpad.net/~ycheng-twn/+archive/ubuntu/focal-fwupd179-10

@SRU team, as the SRU in focal need to upgrade libxmlb from version 0.1.15 to 0.3.6, and that will bump libxmlb1 to libxmlb2. Could you please comment on whether that still block image builds and when could we proceed with that?

As this SUR has been delayed for quite a while, the push from OEM customers have becomes harder and we do need this SRU to be completed.

Hello Max, or anyone else affected,

Accepted fwupd into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupd/1.7.9-1~22.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

All autopkgtests for the newly accepted fwupd (1.7.9-1~22.04.1) for jammy have finished running.
The following regressions have been reported in tests triggered by the package:

fwupd/1.7.9-1~22.04.1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/jammy/update_excuses.html#fwupd

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Hello Max, or anyone else affected,

Accepted fwupd into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupd/1.7.9-1~20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

All autopkgtests for the newly accepted fwupd (1.7.9-1~20.04.1) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

fwupd/1.7.9-1~20.04.1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#fwupd

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

deb diff and PPA to fix jammy/armhf autopkgtest failure.

ppa: https://launchpad.net/~ycheng-twn/+archive/ubuntu/jammy-fwupd179-2/+packages

The error is

FuPluginMtd:ERROR:../plugins/mtd/fu-self-test.c:50:fu_test_mtd_device_func: assertion failed (error == NULL): failed to open /dev/mtd0: No such file or directory (g-io-error-quark, 1)
Bail out! FuPluginMtd:ERROR:../plugins/mtd/fu-self-test.c:50:fu_test_mtd_device_func: assertion failed (error == NULL): failed to open /dev/mtd0: No such file or directory (g-io-error-quark, 1)
Aborted (core dumped)

The content of the debdiff is landed in kinetic and also merged upstream.

I think we can ignore the failure. If SRU team insist on fix it, please tell me and I'll find sponsor to re-upload.

deb diff and PPA to fix focal/armhf autopkgtest failure.

ppa: https://launchpad.net/~ycheng-twn/+archive/ubuntu/focal-fwupd179-11

Downloaded manually as a side channel, works just fine =)

On Tue, Oct 11, 2022 at 8:40 PM Łukasz Zemczak <email address hidden>
wrote:

> Hello Max, or anyone else affected,
>
> Accepted fwupd into focal-proposed. The package will build now and be
> available at https://launchpad.net/ubuntu/+source/fwupd/1.7.9-1~20.04.1
> in a few hours, and then in the -proposed repository.
>
> Please help us by testing this new package. See
> https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how
> to enable and use -proposed. Your feedback will aid us getting this
> update out to other Ubuntu users.
>
> If this package fixes the bug for you, please add a comment to this bug,
> mentioning the version of the package you tested, what testing has been
> performed on the package and change the tag from verification-needed-
> focal to verification-done-focal. If it does not fix the bug for you,
> please add a comment stating that, and change the tag to verification-
> failed-focal. In either case, without details of your testing we will
> not be able to proceed.
>
> Further information regarding the verification process can be found at
> https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in
> advance for helping!
>
> N.B. The updated package will be released to -updates after the bug(s)
> fixed by this package have been verified and the package has been in
> -proposed for a minimum of 7 days.
>
> ** Changed in: fwupd (Ubuntu Focal)
> Status: In Progress => Fix Committed
>
> ** Tags added: verification-needed-focal
>
> --
> You received this bug notification because you are subscribed to a
> duplicate bug report (1983257).
> https://bugs.launchpad.net/bugs/1982103
>
> Title:
> SRU fwupd to 1.7.9 for jammy and focal: Getting wrong hwids by "sudo
> fwupdtool hwids"
>
> Status in OEM Priority Project:
> In Progress
> Status in fwupd package in Ubuntu:
> Fix Released
> Status in fwupd source package in Focal:
> Fix Committed
> Status in fwupd source package in Jammy:
> Fix Committed
> Status in fwupd source package in Kinetic:
> Fix Released
>
> Bug description:
> [Impact]
>
> * BIOS of specific machines can't get updated.
>
> [Test Plan]
>
> * To reproduce and verify the bug:
> sudo fwupdtool hwids # to and check if the id is correct.
>
> * Since we bump version, so we will follow the test steps in
> https://wiki.ubuntu.com/firmware-updates to make sure there
> is no regression.
>
> [Where problems could occur]
>
> * It's rather a low risk for since we keep in stable
> branch that only accept patch but not new features.
>
> * Worse case the new fwupd will brick certain HW even if we have
> certain test coverage during the testing. It's unlikely to
> happen per past history of fwupd, they usually have very good
> code quality and have very limited regression. For the regression
> we know, it never bricks any HW.
>
> * Maybe we could not find certain device, or their fw upgrade
> won't working.
>
> [Other Info]
>
> * Per check, the fwupd-signed version is the same in Jammy and Focal
> And they both are compatible with fwupd ...

Jammy Extra SRU testing: All passed

1. UEFI capsule: pass
2. firmware upgrade or re-install, NVME/Docking etc: Pass/Pass
3. signed packages compatibility: Covered by 1
4-1 fwupdmgr update / install / reinstall sub-command: Pass/Pass/Pass
4-2 old and new version of fwupdmgr.sh in fwupd-tests: Pass (Note: no change in test content across version)
5. bus method: no change (Ref: https://github.com/ycheng/fwupd-dbus) passed
6. snap-store and gnome-software fw upgrade: Pass/Pass (by using local source that fake version bump)

Focal Extra SRU testing: All passed

1. UEFI capsule: Pass.
2. firmware upgrade or re-install, NVME/Docking etc: Pass/Pass
3. signed packages compatibility: Covered by 1
4-1 fwupdmgr update / install / reinstall sub-command: Pass/Pass/Pass
4-2 old and new version of fwupdmgr.sh in fwupd-tests: Pass (Note: no change in test content across version)
5. bus method: no change (Ref: https://github.com/ycheng/fwupd-dbus) passed
6. snap-store and gnome-software fw upgrade: Pass/Pass

Per Ian Kumlien's comment, he verified that on focal about wrong hwids.

I'll change to verified-done-focal after I finish other extra SRU testing.

Max or anyone, for jammy, still need one who have access to the machine to verified wrong hwids issue.

Verify the fwupd v1.7.9 from focal and jammy-proposed.
it works on HP EliteBook 850 G8 Notebook PC
and update BIOS from 01.08.01 to 01.09.01

Given all Jammy/Focal Extra SRU testing is passed,
I'll also tag verification-done-focal.

Hey! So I think we're ready to get these updates released to -updates. The armhf test failure I would recommend fixing with a follow up upload. I already uploaded follow up packages to the queues. I won't hint the failure, since I want people to re-run their tests against -proposed in case they see a failure (instead of not caring for test results at all). Filled in the test issues as https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1994143 .

Let's try getting this landed, finally!

The verification of the Stable Release Update for fwupd has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

This bug was fixed in the package fwupd - 1.7.9-1~20.04.1

---------------
fwupd (1.7.9-1~20.04.1) focal; urgency=medium

  * New upstream release, and drop all patches since they are merged.
  * Properly fall back to use DMI instead of /sys/class/dmi interface.
    (LP: #1982103)
  * Build depends on mondemmanager 1.8 and libxmlb 0.3.6 to support
    EM120/160. (LP: #1980334)
  * Don't stderr-fail the autopkgtest on modprobe error as they are
    optional. (LP: #1966364)
  * Run fwupd-refresh under a dedicated fwupd-refresh user. This is
    fixed in 1.1.7, so it's automatically included. (LP: #1969976)

 -- Yuan-Chen Cheng <email address hidden> Sun, 03 Jul 2022 03:18:51 +0000

This bug was fixed in the package fwupd - 1.7.9-1~22.04.1

---------------
fwupd (1.7.9-1~22.04.1) jammy; urgency=medium

  * New upstream release, and drop all patches since they are merged.
  * Properly fall back to use DMI instead of /sys/class/dmi interface.
    (LP: #1982103)
  * Don't stderr-fail the autopkgtest on modprobe error as they are
    optional. (LP: #1966364)
  * Run fwupd-refresh under a dedicated fwupd-refresh user. This is
    fixed in 1.7.7, so it's automatically included. (LP: #1969976)

 -- Yuan-Chen Cheng <email address hidden> Tue, 20 Sep 2022 03:18:51 +0000

All autopkgtests for the newly accepted fwupd (1.7.9-1~20.04.1) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

fwupd/1.7.9-1~20.04.1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#fwupd

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

All autopkgtests for the newly accepted fwupd (1.7.9-1~22.04.1) for jammy have finished running.
The following regressions have been reported in tests triggered by the package:

fwupd/1.7.9-1~22.04.1 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/jammy/update_excuses.html#fwupd

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!