Some dialogs in gnome-flashback are not respecting the application theme

Bug #1979120 reported by Regolith Linux
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNOME Flashback
Fix Released
Unknown
gnome-flashback (Ubuntu)
Fix Released
Low
Unassigned
Jammy
Fix Released
Low
Unassigned

Bug Description

[Impact]

Desktop UI dialogs are displayed inconsistently, some are light-themed, others dark, depending on the GTK theme set.

[Test Plan]
1. Load a gnome-flashback based desktop environment on Ubuntu Jammy.
2. Lock the screen
3. Press a key to get the password prompt dialog

Expected behavior: The password dialog is rendered with specified GTK theme
Actual behavior: The password dialog is not rendered in the system configured GTK theme

[Where problems could occur]

This patch changes which events the root window can receive. Regression potential should be minimal, but if the change is buggy, gnome-flashback will crash. Also, applications that subscribe to events may receive more events. It is their responsibility to handle them correctly, and they would probably receive these new events in other desktop environments too.

[Other info]

upstream bug report: https://gitlab.gnome.org/GNOME/gnome-flashback/-/issues/81
Ubuntu version: Ubuntu 22.04 LTS
Package version: gnome-flashback/jammy,now 3.44.0-1ubuntu1 amd64

description: updated
Jeremy Bícha (jbicha)
Changed in gnome-flashback (Ubuntu Jammy):
importance: Undecided → Low
Changed in gnome-flashback (Ubuntu):
importance: Undecided → Low
Changed in gnome-flashback (Ubuntu Jammy):
status: New → Triaged
Changed in gnome-flashback (Ubuntu):
status: New → Fix Committed
Changed in gnome-flashback:
status: Unknown → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-flashback - 3.44.0-2ubuntu1

---------------
gnome-flashback (3.44.0-2ubuntu1) kinetic; urgency=medium

  * Merge with Debian unstable, remaining changes:
    - debian/rules, debian/gnome-session-flashback.maintscript:
      + Add an epoch number to gnome-session-flashback package.
    - debian/gnome-session-flashback.gsettings-override:
      + Disable not needed status-notifier-watcher component.
      + Add the default settings for GNOME Flashback sessions.
    - debian/control.in:
      + Use Ubuntu VCS fields.
      + Build-depend on libcompizconfig0-dev to enable Compiz session
        support.
      + Make gnome-session-flashback depend on dbus-user-session,
        gsettings-desktop-schemas ≥ 40, indicator-common, ubuntu-mono
        and yaru-theme-gtk.
      + Make gnome-session-flashback suggest compiz.
      + Add Ubuntu epoch to the required nautilus version.
    - debian/patches/support-indicator-keyboard.diff:
      + Support “org.gnome.desktop.input-sources current” key, to make
        indicator-keyboard working.
    - debian/patches/load_indicators.diff:
      + Load indicators when starting the session via systemd.
    - debian/patches/snap_store.diff:
      + Replace GNOME Software with Snap Store in the Applications menu.
    - debian/gnome-session-flashback.install:
      + Install compiz session script and configuration files.

 -- Dmitry Shachnev <email address hidden> Sun, 03 Jul 2022 23:46:15 +0300

Changed in gnome-flashback (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Robie Basak (racb) wrote : Please test proposed package

Hello Regolith, or anyone else affected,

Accepted gnome-flashback into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-flashback/3.44.0-1ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gnome-flashback (Ubuntu Jammy):
status: Triaged → Fix Committed
tags: added: verification-needed verification-needed-jammy
Revision history for this message
Ken Gilmer (kgilmer) wrote :

Hello! I have verified that gnome-flashback/3.44.0-1ubuntu2 & gnome-flashback-common/3.44.0-1ubuntu2 have addressed the issue.

Steps I took:
1. Install Jammy ISO into VM via gnome-boxes
2. Install Regolith 2.0 into Jammy
3. In jammy session, install gnome-flashback/3.44.0-1ubuntu2 and gnome-flashback-common/3.44.0-1ubuntu2 manually via dpkg from links provided in this issue.
4. Reboot VM for gdm3 to see the new Xsession
5. Log into regolith session
6. Verify package install is updated version
7. Lock screen via dbus command
8. Press key to see unlock dialog

Expected behavior: dialog is rendered with Arc gtk theme, dark colors.
Actual behavior: same

The issue looks to be fixed. I also scanned /var/log/syslog for anything concerning but found nothing.

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Thank you for testing! Marking as verified accordingly.

tags: added: verification-done verification-done-jammy
removed: verification-needed verification-needed-jammy
Revision history for this message
Ubuntu SRU Bot (ubuntu-sru-bot) wrote : Autopkgtest regression report (gnome-flashback/3.44.0-1ubuntu2)

All autopkgtests for the newly accepted gnome-flashback (3.44.0-1ubuntu2) for jammy have finished running.
The following regressions have been reported in tests triggered by the package:

update-manager/1:22.04.9 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/jammy/update_excuses.html#gnome-flashback

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-flashback - 3.44.0-1ubuntu2

---------------
gnome-flashback (3.44.0-1ubuntu2) jammy; urgency=medium

  * Backport upstream patch to make dialogs respect system theme
    (LP: #1979120).

 -- Dmitry Shachnev <email address hidden> Mon, 04 Jul 2022 15:13:01 +0300

Changed in gnome-flashback (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for gnome-flashback has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.