Backport feature to show hidden passwords
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubiquity (Ubuntu) |
Invalid
|
Medium
|
Łukasz Zemczak | ||
| Focal |
Fix Released
|
Medium
|
Łukasz Zemczak | ||
Bug Description
[Impact]
Currently, while the root cause of the notorious bug LP: #1875062 is still not entirely known, certain affected users can type in an unexpected password during installation with no means to check what was actually typed in. As a semi-workaround, in jammy we have added a 'feature' to be able to temporarily show the typed in passwords for both the GTK and KDE frontends. This way users can at least double-check if the password they typed in is what was expected.
I think it's important to get this semi-workaround for 20.04.4, even though it's more of a feature than a bugfix. This way at least users have *some* means of protecting themselves. Even without this, this is a feature that is worth having.
Note to SRU members: this is essentially an UI-changing request, so it might require an ACK from the documentation teams (might need updating some installer screenshots?). So I'd understand if there is a pushback on this. However, I still think this is a feature really nice to have for .4
[Test Case]
Repeat for both Ubuntu and Kubuntu desktop:
* Download latest -proposed daily image
* Proceed with installation normally
* In partition layout, select LVM with encryption, make sure it's possible to unhide and hide the encryption password
* Further down the road, on the user configuration screen, make sure it's possible to unhide and hide the user password
[Regression Potential]
No core logic is touched, so most probable regressions are around the UI aspect of the installer. It's possible that due to an error the GTK or KDE UIs for password input will be corrupted, or logic with button press somehow messed up.
It's good to double check if password verification still works as before the change - though please note that I saw that the KDE frontend seems to be missing some icons for 'correct/incorrect password' in the LVM encrypted partition password selection even before the change.
Related branches
- Steve Langasek: Needs Information
-
Diff: 200 lines (+81/-4)7 files modifieddebian/changelog (+7/-0)
gui/gtk/stepPartCrypto.ui (+4/-2)
gui/gtk/stepUserInfo.ui (+2/-0)
gui/qt/stepUserSetup.ui (+26/-1)
ubiquity/frontend/kde_components/PartAuto.py (+12/-0)
ubiquity/plugins/ubi-partman.py (+8/-0)
ubiquity/plugins/ubi-usersetup.py (+22/-1)
| Changed in ubiquity (Ubuntu Focal): | |
| status: | New → In Progress |
| importance: | Undecided → Medium |
| Changed in ubiquity (Ubuntu): | |
| status: | In Progress → Invalid |
| Changed in ubiquity (Ubuntu Focal): | |
| assignee: | nobody → Łukasz Zemczak (sil2100) |
| milestone: | none → ubuntu-20.04.4 |
| Brian Murray (brian-murray) wrote Please test proposed package | #1 |
| Changed in ubiquity (Ubuntu Focal): | |
| status: | In Progress → Fix Committed |
| tags: | added: verification-needed verification-needed-focal |
| Łukasz Zemczak (sil2100) wrote | #2 |
| tags: |
added: verification-done verification-done-focal removed: verification-needed verification-needed-focal |
| Chris Halse Rogers (raof) wrote Update Released | #3 |
| Launchpad Janitor (janitor) wrote | #4 |
| Changed in ubiquity (Ubuntu Focal): | |
| status: | Fix Committed → Fix Released |
Hello Łukasz, or anyone else affected,
Accepted ubiquity into focal-proposed. The package will build now and be available at https:/
Please help us by testing this new package. See https:/
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-
Further information regarding the verification process can be found at https:/
N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.