sarg FTBFS in impish
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
sarg (Ubuntu) |
Fix Released
|
High
|
Sergio Durigan Junior |
Bug Description
sarg currently FTBFS in impish:
...
/usr/bin/ld: readlog_
/usr/bin/ld: readlog_
/usr/bin/ld: readlog_
/usr/bin/ld: readlog_
/usr/bin/ld: readlog_
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:78: sarg] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j1 returned exit code 2
make: *** [debian/rules:17: build] Error 25
The full build log can be found here:
The failure happens because sarg:
1) *A lot* of the variable declarations in the source code happen inside the include/conf.h file. This is a very bad practice.
2) There is no proper use of "extern" in the source code, so all the variables declared in the header file above get re-declared every time the header is included. It's a mess.
Upstream will probably need to re-engineer the code in a massive way, which is not feasible/
FWIW, sarg is one of the reverse dependencies of OpenLDAP, and is blocking the transition to OpenLDAP 2.5.5.
tags: | added: patch |
This is the patch I mentioned in the description.