snapd

grub-common: snapd autopkgtests fail on s390x

Bug #1925507 reported by Paolo Pisati on 2021-04-22

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
snapd	Invalid	Undecided	Unassigned
grub2 (Ubuntu)	Fix Released	Undecided	Unassigned
Focal	Fix Released	Undecided	Unassigned	Ubuntu ubuntu-20.04.3

Bug Description

[Impact]
Probably regression from #1901553, failing to install on s390x, info below.

[Test plan]
Just ensure those tests don't fail like that

[Regression potential]
grub units only start when /boot is mounted now, as they require /boot/grub/grub.cfg to exist. Should be fine, but might not start if boot failed to mount for some reason.

[Original bug report]
Snapd autopkgtests depend on grub-common:

debian/tests/control:
Depends: @builddeps@

debian/control:
Build-Depends:
...
grub-common,
...

but grub-common fails to install on s390x, consequently snapd autopkgtests fall apart on s390x.

Full log:

https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-hirsute-canonical-kernel-team-unstable/hirsute/s390x/s/snapd/20210422_080633_56960@/log.gz

```
Setting up grub-common (2.04-1ubuntu45) ...
Created symlink /etc/systemd/system/multi-user.target.wants/grub-common.service → /lib/systemd/system/grub-common.service.
Created symlink /etc/systemd/system/multi-user.target.wants/grub-initrd-fallback.service → /lib/systemd/system/grub-initrd-fallback.service.
Created symlink /etc/systemd/system/rescue.target.wants/grub-initrd-fallback.service → /lib/systemd/system/grub-initrd-fallback.service.
Created symlink /etc/systemd/system/emergency.target.wants/grub-initrd-fallback.service → /lib/systemd/system/grub-initrd-fallback.service.
Job for grub-initrd-fallback.service failed because the control process exited with error code.
See "systemctl status grub-initrd-fallback.service" and "journalctl -xe" for details.
update-rc.d: warning: start and stop actions are no longer supported; falling back to defaults
Job for grub-common.service failed because the control process exited with error code.
See "systemctl status grub-common.service" and "journalctl -xe" for details.
invoke-rc.d: initscript grub-common, action "start" failed.
[0;1;31m●[0m grub-common.service - Record successful boot for GRUB
     Loaded: loaded (]8;;file://autopkgtest/lib/systemd/system/grub-common.service/lib/systemd/system/grub-common.service]8;;; enabled; vendor preset: enabled)
     Active: [0;1;31mfailed[0m (Result: exit-code) since Thu 2021-04-22 08:06:10 UTC; 8ms ago
    Process: 3111 ExecStartPre=/bin/sh -c [ -s /boot/grub/grubenv ] || rm -f /boot/grub/grubenv; mkdir -p /boot/grub (code=exited, status=0/SUCCESS)
    Process: 3114 ExecStart=grub-editenv /boot/grub/grubenv unset recordfail [0;1;31m(code=exited, status=1/FAILURE)[0m
    Process: 3115 ExecStartPost=/bin/sh -c if grub-editenv /boot/grub/grubenv list | grep -q initrdless_boot_fallback_triggered=1; then echo "grub: GRUB_FORCE_PARTUUID set, initrdless boot paniced, fallback triggered."; fi (code=exited, status=0/SUCCESS)
   Main PID: 3114 (code=exited, status=1/FAILURE)

Apr 22 08:06:10 autopkgtest systemd[1]: Starting Record successful boot for GRUB...
Apr 22 08:06:10 autopkgtest grub-editenv[3114]: grub-editenv: error: cannot rename the file /boot/grub/grubenv.new to /boot/grub/grubenv.
Apr 22 08:06:10 autopkgtest systemd[1]: [0;1;39m[0;1;31m[0;1;39mgrub-common.service: Main process exited, code=exited, status=1/FAILURE[0m
Apr 22 08:06:10 autopkgtest systemd[1]: [0;1;38;5;185m[0;1;39m[0;1;38;5;185mgrub-common.service: Failed with result 'exit-code'.[0m
Apr 22 08:06:10 autopkgtest systemd[1]: [0;1;31m[0;1;39m[0;1;31mFailed to start Record successful boot for GRUB.[0m
dpkg: error processing package grub-common (--configure):
installed grub-common package post-installation script subprocess returned error exit status 1
```

See original description

Tags:

Related branches

~juliank/grub/+git/bionic:initrdless-backport

Merged into ~ubuntu-core-dev/grub/+git/bionic:master at revision 2e85288d3ad949263a7c628ca36c9efa12f56d0a

Ubuntu Core Development Team: Pending requested 2021-09-29

~ubuntu-core-dev/grub/+git/ubuntu:focal13

Merged into ~ubuntu-core-dev/grub/+git/ubuntu:focal at revision bce2941ab17540efb85faab28acdb52655450458

Dimitri John Ledkov: Pending requested 2021-08-12

~xnox/grub:ubuntu

Rejected for merging into ~ubuntu-core-dev/grub/+git/ubuntu:ubuntu

Julian Andres Klode: Pending requested 2021-07-16

Ubuntu Core Development Team: Pending requested 2021-07-16

Paolo Pisati (p-pisati) on 2021-04-22

summary:

- grub-common: snapd autopkgtest fails on s390x
+ grub-common: snapd autopkgtests fail on s390x

Steve Langasek (vorlon) on 2021-04-22

affects:

grub (Ubuntu) → grub2 (Ubuntu)

Dimitri John Ledkov (xnox) on 2021-06-22

Changed in grub2 (Ubuntu):
status:	New → Triaged

Revision history for this message

Launchpad Janitor (janitor) wrote on 2021-07-20:

This bug was fixed in the package grub2 - 2.04-1ubuntu46

---------------
grub2 (2.04-1ubuntu46) impish; urgency=medium

  * debian/grub-common.service: change type to oneshot, add wantedby
    sleep.target, after sleep.target. The service will now start after
    resume from hybernation. LP: #1929860
  * grub-initrd-fallback.service: add wantedby sleep.target, after
    sleep.target. The service will now start after resume from
    hybernation. LP: #1929860
  * cherrypick upstream fix to make armhf efi boot work. LP: #1788940
  * debian/rules: disable LTO. LP: #1922005
  * grub-initrd-fallback.service, debian/grub-common.service: only start
    units when booted with grub. Use presence of /boot/grub/grub.cfg as
    proxy. LP: #1925507
  * tests: patch qemu command to use ide-hd instead of the removed
    ide-drive.

-- Dimitri John Ledkov <email address hidden> Fri, 16 Jul 2021 14:01:31 +0100

Changed in grub2 (Ubuntu):
status:	Triaged → Fix Released

Julian Andres Klode (juliank) on 2021-08-12

description:	updated
Changed in grub2 (Ubuntu Focal):
milestone:	none → ubuntu-20.04.3

Revision history for this message

Łukasz Zemczak (sil2100) wrote on 2021-08-13: Please test proposed package

Hello Paolo, or anyone else affected,

Accepted grub2 into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/grub2/2.04-1ubuntu26.13 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in grub2 (Ubuntu Focal):
status:	New → Fix Committed
tags:	added: verification-needed verification-needed-focal

Revision history for this message

Julian Andres Klode (juliank) wrote on 2021-08-16 (last edit on 2021-08-16):

All autopkgtests have passed for the 2.04-1ubuntu26.13

tags:

added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal

Revision history for this message

Launchpad Janitor (janitor) wrote on 2021-08-19:

This bug was fixed in the package grub2 - 2.04-1ubuntu26.13

---------------
grub2 (2.04-1ubuntu26.13) focal; urgency=medium

[ Julian Andres Klode ]
* unapply all patches, use gbp pq instead of git-dpm

  [ Dimitri John Ledkov ]
  * 10_linux: emit messages when initrdless boot is configured, attempted and
    fails triggering fallback. LP: #1901553
  * grub-common.service: port init.d script to systemd unit. Add warning
    message, when initrdless boot fails triggering fallback. LP: #1901553
  * debian/grub-common.service: change type to oneshot, add wantedby
    sleep.target, after sleep.target. The service will now start after resume
    from hybernation. (LP: #1929860)
  * grub-initrd-fallback.service: add wantedby sleep.target, after
    sleep.target. The service will now start after resume from hybernation.
    LP: #1929860
  * grub-initrd-fallback.service, debian/grub-common.service: only start units
    when booted with grub. Use presence of /boot/grub/grub.cfg as proxy. LP:
    #1925507

-- Julian Andres Klode <email address hidden> Thu, 12 Aug 2021 11:18:25 +0200

Changed in grub2 (Ubuntu Focal):
status:	Fix Committed → Fix Released

Revision history for this message

Łukasz Zemczak (sil2100) wrote on 2021-08-19: Update Released

The verification of the Stable Release Update for grub2 has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Maciej Borzecki (maciek-borzecki) on 2021-09-30

Changed in snapd:
status:	New → Invalid

Revision history for this message

Julian Andres Klode (juliank) wrote on 2021-10-14:

This is being SRUed to bionic as part of backporting the initrdless feature

Revision history for this message

Steve Langasek (vorlon) wrote on 2021-10-22: Proposed package upload rejected

An upload of grub2 to bionic-proposed has been rejected from the upload queue for the following reason: "The debdiff for this is a mess, there is delta to all the packages under debian/patches, impossible to review; please reupload without the extra delta".

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.