admin endpoint certificate overwritten by expired copy
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
StarlingX |
Fix Released
|
High
|
Bin Qian |
Bug Description
Admin endpoint certificate on subclouds is currently overwritten by the copy in /opt/platform/
Severity:
---------
Medium, this can cause loss of communication between system controller and subcloud for short period of time
after subcloud controller reboot.
Steps to Reproduce:
-------------------
With a subcloud that is managed, wait for its admin endpoint certificate is expired. Reboot the subcloud controller(s), verify its admin endpoint.
The admin endpoint certificate is expired. And after a while, the certificate is corrected by the cert-mon.
Expected Behavior:
------------------
Admin endpoint certificate should not become expired.
CVE References
description: | updated |
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-puppet (master) | #1 |
Changed in starlingx: | |
status: | New → In Progress |
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ansible-playbooks (master) | #2 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (master) | #3 |
Fix proposed to branch: master
Review: https:/
Ghada Khalil (gkhalil) wrote : | #4 |
screening: stx.5.0/medium - this should be cherrypicked to the r/stx.5.0 release branch once it's ready
Changed in starlingx: | |
assignee: | nobody → Bin Qian (bqian20) |
tags: | added: stx.5.0 stx.distcloud |
Changed in starlingx: | |
importance: | Undecided → Medium |
Ghada Khalil (gkhalil) wrote : | #5 |
screening: raising the priority to high to ensure that we wait for this fix for r/stx.5.0
Changed in starlingx: | |
importance: | Medium → High |
OpenStack Infra (hudson-openstack) wrote : Fix merged to stx-puppet (master) | #6 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit 569b457592d3f3c
Author: Bin Qian <email address hidden>
Date: Wed Apr 14 14:54:40 2021 -0400
Generate admin ep cert on subcloud controllers in puppet
Enabled admin endpoint cert to be generated in manifest directly
from k8s secret data (via secure hieradata). This operation is
consistant to the system controller as well as admin endpoint cert
renewal.
Partial-Bug: 1923510
Change-Id: I442f3c2c97cf83
Signed-off-by: Bin Qian <email address hidden>
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ansible-playbooks (master) | #7 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (master) | #8 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit 862c1746abb8d89
Author: Bin Qian <email address hidden>
Date: Fri Apr 30 12:14:31 2021 -0400
Remove subcloud admin endpoint data migration
Admin endpoint cert upgrade will be handeled by manifest, so data
migration is no longer needed in subcloud.
On N+1 side, admin endpoint cert secret (key/cert) will be pulled
directly from k8s resource for manifest to generate endpoint cert
on first host unlock.
Only need to update SAN of admin endpoint cert.
Closes-Bug: 1923510
Depends-On: https:/
Change-Id: I4312abd6c767d6
Signed-off-by: Bin Qian <email address hidden>
Changed in starlingx: | |
status: | In Progress → Fix Released |
tags: | added: stx.cherrypickneeded |
Ghada Khalil (gkhalil) wrote : | #9 |
There are still two commits that need to merge for this LP:
https:/
https:/
Once these all merged, all commits need to be cherrypicked to the r/stx.5.0 release branch
OpenStack Infra (hudson-openstack) wrote : Fix merged to ansible-playbooks (master) | #10 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit e25439d49d12777
Author: Bin Qian <email address hidden>
Date: Wed Apr 14 14:53:56 2021 -0400
Remove creating admin endpoint cert in subcloud bootstrap
This change removes creating admin endpoint cert in subcloud
bootstrap.
The admin endpoint cert is generated in manifest at the time when
the controller node is unlock the first time. The cert data is
retrieved directly from k8s secret data (where cert-manager is
responsible to maintain it and keep it up to date).
Partial-Bug: 1923510
Depends-On: https:/
Signed-off-by: Bin Qian <email address hidden>
Change-Id: Ie6a5c8fe159efc
OpenStack Infra (hudson-openstack) wrote : | #11 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit bc0fba6bbbd0182
Author: Bin Qian <email address hidden>
Date: Wed Apr 28 11:52:36 2021 -0400
Remove restore subcloud admin endpoint certificate from config
This change is to exclude the admin endpoint certificate from restore
to config directory. The admin endpoint certificate is stored in k8s
(backup) and restore as part of k8s restore. Sysinv will generate it
into hieradata from k8s secret and puppet will genereate the pem for
haproxy.
Depends-On: https:/
Partial-Bug: 1923510
Signed-off-by: Bin Qian <email address hidden>
Change-Id: Iae8fb9c53e0aa6
Ghada Khalil (gkhalil) wrote : | #12 |
@Bin Qian, please cherrypick the code changes associated with this LP to the r/stx.5.0 release branch since the LP is tagged for that release.
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (r/stx.5.0) | #13 |
Fix proposed to branch: r/stx.5.0
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-puppet (r/stx.5.0) | #14 |
Fix proposed to branch: r/stx.5.0
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ansible-playbooks (r/stx.5.0) | #15 |
Fix proposed to branch: r/stx.5.0
Review: https:/
OpenStack Infra (hudson-openstack) wrote : | #16 |
Fix proposed to branch: r/stx.5.0
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to stx-puppet (r/stx.5.0) | #17 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: r/stx.5.0
commit fddac0bf3cc16be
Author: Bin Qian <email address hidden>
Date: Wed Apr 14 14:54:40 2021 -0400
Generate admin ep cert on subcloud controllers in puppet
Enabled admin endpoint cert to be generated in manifest directly
from k8s secret data (via secure hieradata). This operation is
consistant to the system controller as well as admin endpoint cert
renewal.
Partial-Bug: 1923510
Change-Id: I442f3c2c97cf83
Signed-off-by: Bin Qian <email address hidden>
(cherry picked from commit 569b457592d3f3c
OpenStack Infra (hudson-openstack) wrote : Fix merged to ansible-playbooks (r/stx.5.0) | #18 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: r/stx.5.0
commit 6e2cdc2854bdc62
Author: Bin Qian <email address hidden>
Date: Wed Apr 14 14:53:56 2021 -0400
Remove creating admin endpoint cert in subcloud bootstrap
This change removes creating admin endpoint cert in subcloud
bootstrap.
The admin endpoint cert is generated in manifest at the time when
the controller node is unlock the first time. The cert data is
retrieved directly from k8s secret data (where cert-manager is
responsible to maintain it and keep it up to date).
Partial-Bug: 1923510
Depends-On: https:/
Signed-off-by: Bin Qian <email address hidden>
Change-Id: Ie6a5c8fe159efc
(cherry picked from commit e25439d49d12777
OpenStack Infra (hudson-openstack) wrote : | #19 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: r/stx.5.0
commit 0fe9a931d375b92
Author: Bin Qian <email address hidden>
Date: Wed Apr 28 11:52:36 2021 -0400
Remove restore subcloud admin endpoint certificate from config
This change is to exclude the admin endpoint certificate from restore
to config directory. The admin endpoint certificate is stored in k8s
(backup) and restore as part of k8s restore. Sysinv will generate it
into hieradata from k8s secret and puppet will genereate the pem for
haproxy.
Depends-On: https:/
Partial-Bug: 1923510
Signed-off-by: Bin Qian <email address hidden>
Change-Id: Iae8fb9c53e0aa6
(cherry picked from commit bc0fba6bbbd0182
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (r/stx.5.0) | #20 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: r/stx.5.0
commit 4e2fc590723ff2b
Author: Bin Qian <email address hidden>
Date: Fri Apr 30 12:14:31 2021 -0400
Remove subcloud admin endpoint data migration
Admin endpoint cert upgrade will be handeled by manifest, so data
migration is no longer needed in subcloud.
On N+1 side, admin endpoint cert secret (key/cert) will be pulled
directly from k8s resource for manifest to generate endpoint cert
on first host unlock.
Only need to update SAN of admin endpoint cert.
Closes-Bug: 1923510
Depends-On: https:/
Change-Id: I4312abd6c767d6
Signed-off-by: Bin Qian <email address hidden>
(cherry picked from commit 862c1746abb8d89
tags: |
added: in-r-stx50 removed: stx.cherrypickneeded |
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-puppet (f/centos8) | #21 |
Fix proposed to branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Change abandoned on stx-puppet (f/centos8) | #22 |
Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-puppet (f/centos8) | #23 |
Fix proposed to branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Change abandoned on stx-puppet (f/centos8) | #24 |
Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-puppet (f/centos8) | #25 |
Fix proposed to branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Change abandoned on stx-puppet (f/centos8) | #26 |
Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-puppet (f/centos8) | #27 |
Fix proposed to branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ansible-playbooks (f/centos8) | #28 |
Fix proposed to branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (f/centos8) | #29 |
Fix proposed to branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : | #30 |
Fix proposed to branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ansible-playbooks (f/centos8) | #31 |
Fix proposed to branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ansible-playbooks (f/centos8) | #32 |
Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to ansible-playbooks (f/centos8) | #33 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: f/centos8
commit 4e96b762f549aad
Author: Mihnea Saracin <email address hidden>
Date: Sat May 22 15:48:19 2021 +0000
Revert "Restore host filesystems with collected sizes"
This reverts commit 255488739efa4ac
Reason for revert: Did a rework to fix https:/
Change-Id: Iea79701a874eff
Depends-On: I55ae6954d24ba3
commit c064aacc377c8bd
Author: Angie Wang <email address hidden>
Date: Fri May 21 21:28:02 2021 -0400
Ensure apiserver keys are present before extract from tarball
This is to fix the upgrade playbook issue that happens during
AIO-SX upgrade from stx4.0 to stx5.0 which introduced by
https:/
The apiserver keys are not available in stx4.0 side so we need
to ensure the keys under /etc/kubernetes/pki are present in the
backed-up tarball before extracting, otherwise playbook fails
because the keys are not found in the archive.
Change-Id: I8602f07d1b1041
Closes-Bug: 928925
Signed-off-by: Angie Wang <email address hidden>
commit 0261f22ff7c23d2
Author: Don Penney <email address hidden>
Date: Thu May 20 23:09:07 2021 -0400
Update SX to DX migration to wait for coredns config
This commit updates the SX to DX migration playbook to wait after
modifying the system mode to duplex until the runtime manifest that
updates coredns config has completed. The playbook will wait for up to
20 minutes to allow for the possibilty that sysinv has multiple
runtime manifests queued up, each of which could take several minutes.
Depends-On: https:/
Depends-On: https:/
Change-Id: I3bf94d3493ae20
Closes-Bug: 1929148
Signed-off-by: Don Penney <email address hidden>
commit 7c4f17bd0d92fc1
Author: Daniel Safta <email address hidden>
Date: Wed May 19 09:08:16 2021 +0000
Fixed missing apiserver-
When controller-1 is the active controller
the backup archive does not contain
/etc/
This change adds a new task which brings
the certs from /etc/kubernetes/pki
Closes-bug: 1928925
Signed-off-by: Daniel Safta <email address hidden>
Change-Id: I3c68377603e1af
commit e221ef8fbe51aa6
Author: David Sullivan <email address hidden>
Date: Wed May 19 16:01:27 2021 -0500
Support boo...
tags: | added: in-f-centos8 |
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (f/centos8) | #34 |
Fix proposed to branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to stx-puppet (f/centos8) | #35 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: f/centos8
commit 3e3940824dfb830
Author: Dan Voiculeasa <email address hidden>
Date: Thu May 13 18:03:45 2021 +0300
Enable kubelet support for pod pid limit
Enable limiting the number of pids inside of pods.
Add a default value to protect against a missing value.
Default to 750 pids limit to align with service parameter default
value for most resource consuming StarlingX optional app (openstack).
In fact any value above service parameter minimum value is good for the
default.
Closes-Bug: 1928353
Signed-off-by: Dan Voiculeasa <email address hidden>
Change-Id: I10c1684fe3145e
commit 0c16d288fbc4831
Author: Jessica Castelino <email address hidden>
Date: Tue May 11 10:21:57 2021 -0400
Safe restart of the etcd SM service in etcd upgrade runtime class
While upgrading the central cloud of a DC system, activation failed
because there was an unexpected SWACT to controller-1. This was due
to the etcd upgrade script. Part of this script runs the etcd
manifest. This triggers a reload/restart of the etcd service. As this
is done outside of the sm, sm saw the process failure and triggered
the SWACT.
This commit modifies platform:
to do a safe restart of the etcd SM service and thus, solve the
issue.
Change-Id: I3381b6976114c7
Signed-off-by: Jessica Castelino <email address hidden>
Closes-Bug: 1928135
commit eec3008f600aeeb
Author: Mihnea Saracin <email address hidden>
Date: Mon May 10 13:09:52 2021 +0300
Serialize updates to global_filter in the AIO manifest
Right now, looking at the aio manifest:
https:/
there are 3 classes that update
in parallel the lvm global_filter:
- include ::platform:
- include ::platform:
- include ::platform:
And this generates some errors.
We fix this by adding dependencies between the above classes
in order to update the global_filter in a serial mode.
Closes-Bug: 1927762
Signed-off-by: Mihnea Saracin <email address hidden>
Change-Id: If6971e520454cd
commit 97371409b9b2ae3
Author: Steven Webster <email address hidden>
Date: Fri May 7 15:33:43 2021 -0400
Add SR-IOV rate-limit dependency
Currently, the binding of an SR-IOV virtual function (VF) to a
driver has a dependency on platform:
to ensure that SR-IOV is enabled (VFs created) before actually
doing the bind.
This dependency does not exist for configuring the VF rate-limits
however. There is a cha...
OpenStack Infra (hudson-openstack) wrote : Fix proposed to config (f/centos8) | #36 |
Fix proposed to branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Change abandoned on config (f/centos8) | #37 |
Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to config (f/centos8) | #38 |
Reviewed: https:/
Committed: https:/
Submitter: "Zuul (22348)"
Branch: f/centos8
commit 9e420d9513e5faf
Author: Bin Qian <email address hidden>
Date: Mon May 31 14:45:52 2021 -0400
Add more logging to run docker login
Add error log for running docker login. The new log could
help identify docker login failure.
Closes-Bug: 1930310
Change-Id: I8a709fb6665de8
Signed-off-by: Bin Qian <email address hidden>
commit 31c77439d2cea59
Author: albailey <email address hidden>
Date: Fri May 28 13:42:42 2021 -0500
Fix controller-0 downgrade failing to kill ceph
kill_
file that does not exist in an AIO-DX environment.
We no longer invoke kill_ceph_
AIO SX or DX env.
This allows: "system host-downgrade controller-0"
to proceed in an AIO-DX environment where that second
controller (controller-0) was upgraded.
Partial-Bug: 1929884
Signed-off-by: albailey <email address hidden>
Change-Id: I633853f7531773
commit 0dc99eee608336f
Author: albailey <email address hidden>
Date: Fri May 28 11:05:43 2021 -0500
Fix file permissions failure during duplex upgrade abort
When issuing a downgrade for controller-0 in a duplex upgrade
abort and rollback scenario, the downgrade command was failing
because the sysinv API does not have root permissions to set
a file flag.
The fix is to use RPC so the conductor can create the flag
and allow the downgrade for controller-0 to get further.
Partial-Bug: 1929884
Signed-off-by: albailey <email address hidden>
Change-Id: I913bcad73309fe
commit 7ef3724dad17375
Author: Chen, Haochuan Z <email address hidden>
Date: Tue May 25 16:16:29 2021 +0800
Fix bug rook-ceph provision with multi osd on one host
Test case:
1, deploy simplex system
2, apply rook-ceph with below override value
value.yaml
cluster:
storage:
nodes:
- name: controller-0
devices:
- name: sdb
- name: sdc
3, reboot
Without this fix, only osd pod could launch successfully after boot
as vg start with ceph could not correctly add in sysinv-database
Closes-bug: 1929511
Change-Id: Ia5be599cd168d1
Signed-off-by: Chen, Haochuan Z <email address hidden>
commit 23505ba77d76114
Author: Angie Wang <email address hidden>
Date: Tue May 25 18:49:21 2021 -0400
Fix issue in partition data migration script
The created partition dictonary partition_map is not
an ordered dict so we need to sort it by its key -
device node when iterating it to adjust the device
nodes/paths for user created extra partitions to ensure
the number of device node...
OpenStack Infra (hudson-openstack) wrote : Change abandoned on config (f/centos8) | #39 |
Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https:/
OpenStack Infra (hudson-openstack) wrote : | #40 |
Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https:/
Fix proposed to branch: master /review. opendev. org/c/starlingx /stx-puppet/ +/786666
Review: https:/