Mixxx

tango settings menu UI issues

Bug #1851994 reported by Foss-4
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
Unassigned
Mixxx 2.3.0

Bug Description

macOS 10.14.6
mixxx 2.3.0-alpha-pre (build master r6987)

tango skin, settings menu has UI issues

- the checkmarks used to display an active setting is too big and poorly visible in dark mode (or default mode?)
- the text alignment when active and inactive settings are next to each other is cut off / misaligned (seems again to be caused by the oversized checkmark icon used for active settings
- it would be better if the active settings would use a checked box (needs to be fixed) and inactive settings are an empty box (as is now)

Tags: skin
Revision history for this message
Foss-4 (foss-4) wrote :
Revision history for this message
ronso0 (ronso0) wrote :

looks like Ubuntu font isn't imported.
Can you somehow make sure it's included?

Besides, https://github.com/mixxxdj/mixxx/pull/2337 should improve the menu and avoid squeezed rows when there's enough space like on your screen.

Revision history for this message
ronso0 (ronso0) wrote :

@foss-4 Did you check if Mixxx installs Ubuntu font?

The skin changes I mentioned are now in https://github.com/mixxxdj/mixxx/pull/2363
if you can please test if the issue is solved with this branch.

Revision history for this message
Foss-4 (foss-4) wrote :

Interesting finding as https://github.com/mixxxdj/mixxx/pull/2363 is not yet merged.

macOS 10.15.2 + mixxx 2.3.0-alpha-pre (build master r7076)

skin preferences for tango are now displayed correctly (see attached screenshot).

Revision history for this message
Foss-4 (foss-4) wrote :

What's the correct status here? Wonfix? Invalid? Fix commited without a commit isn't really great.

Changed in mixxx:
importance: Undecided → Low
Revision history for this message
ronso0 (ronso0) wrote :

it would be good to know if the issue was solved by upgrading MacOS or Mixxx.
If it is resolved in MacOS 10.14 as well we can mark it 'Fix committed' even though we can't tell if the fix was maybe in Qt sources or Mixxx

Revision history for this message
Foss-4 (foss-4) wrote :

Interesting
retested old r6987 build which had the problem on macOS 10.14. The problem is gone on 10.15.2 with that build as well.

So probably not solved on macOS 10.14.

Revision history for this message
Foss-4 (foss-4) wrote :

Setting to solved. Unsure if 10.14 users are still affected but problem is gone on 10.15.

Changed in mixxx:
status: New → Fix Released
status: Fix Released → Fix Committed
Daniel Schürmann (daschuer)
tags: removed: tango
Daniel Schürmann (daschuer)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9797

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.