libesd leaks pipe file descriptors

This bug was fixed in the package esound - 0.2.38-0ubuntu6

---------------
esound (0.2.38-0ubuntu6) hardy; urgency=low

  * esdlib.c: The previous patch leaks pipe file descriptors in the case
    that /usr/bin/esd doesn't exist. Fix that bug by only opening the
    pipes after we know that the esd executable exists (LP: #183411).

 -- Ryan Lortie <email address hidden> Tue, 15 Jan 2008 22:08:19 -0500

If I understand well, this bug appears in Feisty only because esound-common is installed as default, but esound is not. I suppose that there are dependencies forbidding esound-common to be removed. Is it a good workaround for Feisty to install esound as well from the repositories and to let everything else unchanged?

Sorry, I mean Gutsy (Ubuntu 7.10) and not Feisty!

I can confirm that the workaround (installing esound) corrects the problem. Thanks.

Since we have confirmation that this is the root cause of the problem we should probably upload this one to gutsy...

There is still something that I can't understand: The bug appears in Gutsy because in Gutsy esound is not installed as default. How can a fix in the package esound solve a problem that only happenes when just this package is not installed?
A real fix for this bug can't be done in the package esound...

The 'esound' source package ships multiple binary packages.

The 'esound' binary package isn't installed by default, but the 'libesd-alsa0' package (built from the same source package) is depended on by nautilus and many many other things.

The fix in this patch effects code that ends up in the libesd-alsa0 package (and is therefore installed by default).

I looked at the description of esound in the readme file inside esound-common:

"... However, it is part of the GNOME platform (for a little while longer), so we slavishly continue to maintain it."

There seem to be dependences why esound can't simply be taken out, as it has been done in Gutsy... I think that is the root cause of the problem.

@ Ryan Lortie:

Sorry, I had not yet read your notice when I posted mine. Now I understand better, thanks!

GNOME only depends on libesd, not on the daemon itself.

On Wed, 2008-01-16 at 20:55 +0000, Max-Ulrich Farber wrote:
> I looked at the description of esound in the readme file inside esound-
> common:
>
> "... However, it is part of the GNOME platform (for a little while
> longer), so we slavishly continue to maintain it."
>
> There seem to be dependences why esound can't simply be taken out, as it
> has been done in Gutsy... I think that is the root cause of the problem.
>

Ryan Lortie wrote:
Since we have confirmation that this is the root cause of the problem we should probably upload this one to gutsy...

That would be fine! Thanks!

Sponsored and accepted into gutsy-proposed:
 esound (0.2.38-0ubuntu4.1) gutsy-proposed; urgency=low
 .
   * esdlib.c: The previous patch leaks pipe file descriptors in the case
     that /usr/bin/esd doesn't exist. Fix that bug by only opening the
     pipes after we know that the esd executable exists (LP: #183411).

Ryan, please add a TEST CASE: to the description, as per SRU policy. Thanks!

This has been in -proposed for three months now. Any testers? Anyone who can confirm that it does not cause regressions?

I was able to reproduce the nautilus file descriptor leak problem using libesd-alsa0/esound-common 0.2.38-0ubuntu4 in gutsy. I can confirm that the packages in gutsy-proposed, libesd-alsa0/esound-common 0.2.38-0ubuntu4.1, addresses the issue; nautilus no longer leaks file descriptors. I was also able to continue playing audio from rhythmbox, totem, and firefox/flash-nonfree, as well as the audio component of videos. I also installed esd, restarted the desktop, and verified that esd was running and that sound still worked.

Thanks!

Oh, one additional note: despite having previews enabled for all audio files within nautilus, neither of the versions produced any sound while mousing over music files (ogg or mp3), which I would have expected from an attempted preview. I wasn't sure what the expected behavior there is, but at least with the update in gutsy-proposed, nautilus will not stop stop working if the user happens to mouse over many music files.

Hi Steve,

thanks for verifying!

Steve Beattie [2008-08-05 18:30 -0000]:
> Oh, one additional note: despite having previews enabled for all audio
> files within nautilus, neither of the versions produced any sound while
> mousing over music files (ogg or mp3)

This requires to have mpg321 and ogg123 installed, at least it was
like that in earlier GNOME releases. Ideally nautilus would use
gst-launch for that, not calling command line tools.

Copied to gutsy-updates.

This happen in 7.10, and 8.04, in Ubuntu, xubuntu, kubuntu, edubuntu, etc...

We need a solution now
Because when attach a usb mp3/mp4 drive, Ubuntu PRrrrrr chaaaaa, and now was nothing to can make, and reset button is the next way.
Disable the sound previews, or something... , thats sometimes works.... But it is not a really solution.......

What is the solution? i don't understand, sorry
Thanks