FFe: samba 4.10.0

Bug #1818518 reported by Andreas Hasenack
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
samba (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Samba 4.10.0[1] is the first samba release to completely support python3. It is a goal of Ubuntu to remove python2 from the desktop images (see bug #1440381), and this release of samba, together with the mandatory dependency updates it warrants (ldb, tdb, talloc and tevent), allow for that to happen.

tdb FFe: https://bugs.launchpad.net/ubuntu/+source/tdb/+bug/1818520
talloc FFe: https://bugs.launchpad.net/ubuntu/+source/talloc/+bug/1818522
tevent FFe: https://bugs.launchpad.net/ubuntu/+source/tevent/+bug/1818523
ldb FFe: https://bugs.launchpad.net/ubuntu/+source/ldb/+bug/1818525

Samba 4.10.0 is not yet released, though. The current release is 4.10.0rc4. The final release is expected for March 19th, 2019 (see [1]: it slipped, as it was supposed to be released on March 5th).

Release notes for the 4.10 branch are at [2]

Considerations:
- We are going ahead of Debian with this change
- python2 bindings will be dropped from the samba package, in favor of py3 only ones. It is possible to build with both, but the current packaging would have to be changed because, among other things, samba-libs has python dependencies. We would need to move those to another package otherwise samba-libs would depend on both python2 and python3, which defeats the purpose of what we want
- reverse depends for python-samba (the py2 package);
$ reverse-depends python-samba
Reverse-Depends
===============
* samba
* samba-common-bin
- new python3-* packages will result from this effort: python3-samba, python3-ldb, python3-talloc
- this is the first release of samba that supports python3. Bugs can be expected
- samba "dot-zero" (.0) releases might contain bugs that are quickly fixed in point releases. We might have to do such updates before Disco releases.
- samba 4.10.x is the last series of samba that will support python2
- sssd needed a patch to fix an FTBFS with samba 4.10. It's in the bileto ppa (see below) and I proposed it for disco already (https://code.launchpad.net/~ahasenack/ubuntu/+source/sssd/+git/sssd/+merge/363940). Turns out sssd was already an FTBFS in disco due to the krb5 1.17 update (which I also fix in that MP). UPDATE: it is in disco now.

We believe there is greater risk in postponing this change for disco+1 than doing it now, and flushing out the bugs in preparation for the next LTS.

FFe bugs for the samba 4.10 dependencies have been filed as well.

Ongoing work for this update is being tracked in https://trello.com/c/roVc4bsZ

Branches:
ldb: https://code.launchpad.net/~ahasenack/ubuntu/+source/ldb/+git/ldb/+ref/disco-ldb-1.5.4
tevent: https://code.launchpad.net/~ahasenack/ubuntu/+source/tevent/+git/tevent/+ref/disco-tevent-0.9.39
talloc: https://code.launchpad.net/~ahasenack/ubuntu/+source/talloc/+git/talloc/+ref/disco-talloc-2.1.16
tdb: https://code.launchpad.net/~ahasenack/ubuntu/+source/tdb/+git/tdb/+ref/disco-tdb-1.3.18
samba: https://code.launchpad.net/~ahasenack/ubuntu/+source/samba/+git/samba/+ref/disco-samba-4.10

A diff between what is in disco, and the proposed packages, can be obtained with git by running diffing against the ubuntu/devel branch.

Or with git-ubuntu:
sudo snap install git-ubuntu --edge --classic
git ubuntu clone <package>
cd <package>
git ubuntu remote add ahasenack
git checkout disco-<package>-<version>
git diff pkg/ubuntu/devel

PPA with test builds: https://launchpad.net/~ahasenack/+archive/ubuntu/samba-4.10/

Bileto ticket is green with all these packages: https://bileto.ubuntu.com/#/ticket/3672

The gvfs failure is a badtest in disco already.

1. https://wiki.samba.org/index.php/Release_Planning_for_Samba_4.10
2. https://gitlab.com/samba-team/samba/blob/v4-10-test/WHATSNEW.txt

Related branches

description: updated
description: updated
description: updated
description: updated
description: updated
description: updated
description: updated
description: updated
description: updated
description: updated
description: updated
description: updated
Revision history for this message
Steve Langasek (vorlon) wrote :

FFe approved.

Changed in samba (Ubuntu):
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package samba - 2:4.10.0~rc4+dfsg-0ubuntu1

---------------
samba (2:4.10.0~rc4+dfsg-0ubuntu1) disco; urgency=medium

  * New upstream version 4.10.0rc4 (LP: #1818518):
    - Removed patches already applied upstream:
      + d/p/nsswitch-Add-try_authtok-option-to-pam_winbind.patch
      + d/p/s3-auth-ignore-create_builtin_guests-failing-without.patch
    - d/p/add-so-version-to-private-libraries: refreshed to remove fuzz
    - d/control: Updated build dependencies:
      + tdb >= 1.3.17
      + talloc >= 2.1.15
      + tevent >= 0.9.38
      + ldb >= 1.5.3
    - d/samba-common.docs: README is now README.md
    - d/libsmbclient.symbols: update symbols for this version
    - d/libwbclient0.symbols: update symbols for this version
    - d/ctdb.install: new binary ctdb_local_daemons
    - d/samba-dev.install: use globbing for the header files with
      exceptions for wbclient.h and libsmbclient.h, which belong in
     other packages.
    - d/rules: fix globbing used to move the dckeytab python module to the
      samba package, and add a comment explaining why this is being done.
  * Switch to python3:
    - d/rules: calculate the ldb version using python3, and drop the
      "really" bit since the real 1.5.x series is being used now.
    - d/rules: make sure python3 is used for the build
    - d/rules: adjust globbing to remove the python3 version of tevent.so
    - d/rules: drop PYVERS, unused
    - d/control: adjust dependencies (build and runtime) for python3
    - d/python3-samba.install, d/control: new python3-samba package
      (LP: #1440381)
    - d/control, d/python-samba.install: get rid of python-samba, which is py2
    - d/python3-samba.lintian-overrides: use the same overrides we had for
      python-samba, now deleted.
    - d/samba-dev.install, d/samba-libs.install: update file list
    - d/t/control, d/t/python-smoke: use python3
    - d/control: use ${python3:Depends} now instead of the python 2
      counterpart for samba and samba-common-bin.
  * d/control: drop suggests for python-gpgme, it's no longer available.

 -- Andreas Hasenack <email address hidden> Sat, 09 Mar 2019 12:45:25 +0000

Changed in samba (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.