Mixxx

controllers can't focus tracks table item if there is only one

Bug #1808632 reported by ronso0 on 2018-12-15

This bug affects 3 people

Affects		Status	Importance	Assigned to	Milestone
	Mixxx	Fix Released	Low	ronso0	Mixxx 2.3.0

Bug Description

Reproduce:
* go to Tracks
* type search terms that would yield exactly one result
= one item/row in tracks table
* move focus to tracks table (Tab or controller key)
* try to focus/select the one row
= neither up/down arrows (keyboard) or [Library],MoveVertical or [..],ScrollVertical allow to focus the item

But pressing the right arrow key does select the row. It seems the leftmost table cell has 'focus' somehow but the row isn't selected.

master (2.3) 2018-12-15

See original description

Tags:

ronso0 (ronso0) on 2018-12-15

description:

updated

Revision history for this message

Daniel Schürmann (daschuer) wrote on 2018-12-15:

I can confirm the issue with Mixxx 1.2.5 as well.

Changed in mixxx:
status:	New → Confirmed
importance:	Undecided → Low
tags:	added: easy

Revision history for this message

ronso0 (ronso0) wrote on 2019-06-27:

@daschuer What easy solution do you propose?

In wtracktableview.cpp I'd like to select a single row automatically (in any feature/track model), but how would I retrieve the number of rows?

Revision history for this message

Daniel Schürmann (daschuer) wrote on 2019-06-28:

I do not have a recipe for an easy fix.

I think I would start using gdb and investigate the call stack that is used when more tracks are there and a s new one is highlighted. Than I would use a one track table and repeat the test with a braekpoint a bit down in the call tree. Are you able to single step though the code?

Maybe you can than find out, why it does not work with one track and fix it finally.

Revision history for this message

ronso0 (ronso0) wrote on 2019-07-09:

So far I used gdb only to create crash reports.
I'll see if I can wrap my head around that, but I'm afraid this won't happen soon as there are other issues more itching and more likely for me to solve them.

Revision history for this message

ronso0 (ronso0) wrote on 2019-09-11:

So far I've found out that the first table row is always soemhow focused but not selected/highlighted.

In wtracktableview.cpp I can manually select the first row if there's only one, but that would only work for [Playlist],MoveSelection controls, not for Up/Down key presses (real or emulated in librarycontrol.cpp). The issue seems to be in qabstractitemview or qtableview respectively.

ronso0 (ronso0) on 2019-11-26

summary:

- can't focus tracks table item if there is only one
+ controllers can't focus tracks table item if there is only one

ronso0 (ronso0) on 2019-11-29

Changed in mixxx:
assignee:	nobody → ronso0 (ronso0)
status:	Confirmed → In Progress

Uwe Klotz (uklotzde-deactivatedaccount) on 2020-08-27

Changed in mixxx:
milestone:	none → 2.3.0

ronso0 (ronso0) on 2020-08-28

Changed in mixxx:
assignee:	ronso0 (ronso0) → nobody

Revision history for this message

ronso0 (ronso0) wrote on 2020-08-29:

https://github.com/mixxxdj/mixxx/pull/3049

Changed in mixxx:
assignee:	nobody → ronso0 (ronso0)

Revision history for this message

ronso0 (ronso0) wrote on 2020-08-29:

#3049 that enforces a selection on FocusIn events of WLibraryTableView:
no previously focused item: select first
previously focused item, but no selection: select previous item

Revision history for this message

ronso0 (ronso0) wrote on 2020-09-28:

https://github.com/mixxxdj/mixxx/pull/3090