Add allowed address pair button is only visible to admin

policy_rules for allowed_address_pairs is correct [1] and the corresponding policy.json from neutron is correct too [2].

The policy for allowed_address_pairs contains a network owner check like below.
  "update_port:allowed_address_pairs": "rule:admin_or_network_owner"
I wonder the network information is not passed correctly to the policy check function.

[1] http://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/project/networks/ports/extensions/allowed_address_pairs/tables.py#n37
[2] http://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/conf/neutron_policy.json#n96

Temporarily assigning me as I cannot work on this soon

Would this be looked in to soon? :-)

Fix proposed to branch: master
Review: https://review.opendev.org/679967

Reviewed: https://review.opendev.org/679967
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=87b57dfe7113da09715d5613ab9c91c15a75c189
Submitter: Zuul
Branch: master

commit 87b57dfe7113da09715d5613ab9c91c15a75c189
Author: Shilpa Devharakar <email address hidden>
Date: Thu Aug 22 14:29:41 2019 +0530

    Add Allowed Address Pair/Delete buttons are only visible to admin

    Initially In Queens, when logging into Horizon in context
    of a _member_ in any project, the "Add Allowed Address Pair"
    and "Delete" buttons in "Network" -> "Networks" ->
    <select a network> -> "Ports" -> <select a port> ->
    "Allowed Address Pairs" are not visible.

    When accessing the same panel in context of a project where the user
    has the admin role, the "Add" and "Delete" button is visible and
    functional.

    This patch fixes the above issue by updating the policy_target.

    Change-Id: Ia7db6c2881c72580a156eb97b11bb51f295cfbce
    Closes-Bug: #1794421

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/684862

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/684922

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/685045

This issue was fixed in the openstack/horizon 16.0.0.0rc1 release candidate.

Reviewed: https://review.opendev.org/684922
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=83855762fb6af0f560de9432512aa488377e9e21
Submitter: Zuul
Branch: stable/rocky

commit 83855762fb6af0f560de9432512aa488377e9e21
Author: Shilpa Devharakar <email address hidden>
Date: Thu Aug 22 14:29:41 2019 +0530

    Add Allowed Address Pair/Delete buttons are only visible to admin

    Initially In Queens, when logging into Horizon in context
    of a _member_ in any project, the "Add Allowed Address Pair"
    and "Delete" buttons in "Network" -> "Networks" ->
    <select a network> -> "Ports" -> <select a port> ->
    "Allowed Address Pairs" are not visible.

    When accessing the same panel in context of a project where the user
    has the admin role, the "Add" and "Delete" button is visible and
    functional.

    This patch fixes the above issue by updating the policy_target.

    Change-Id: Ia7db6c2881c72580a156eb97b11bb51f295cfbce
    Closes-Bug: #1794421
    (cherry picked from commit 87b57dfe7113da09715d5613ab9c91c15a75c189)

Reviewed: https://review.opendev.org/685045
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=d8ae1d05920f144531fe16a70e80f9871c37675f
Submitter: Zuul
Branch: stable/queens

commit d8ae1d05920f144531fe16a70e80f9871c37675f
Author: Shilpa Devharakar <email address hidden>
Date: Thu Aug 22 14:29:41 2019 +0530

    Add Allowed Address Pair/Delete buttons are only visible to admin

    Initially In Queens, when logging into Horizon in context
    of a _member_ in any project, the "Add Allowed Address Pair"
    and "Delete" buttons in "Network" -> "Networks" ->
    <select a network> -> "Ports" -> <select a port> ->
    "Allowed Address Pairs" are not visible.

    When accessing the same panel in context of a project where the user
    has the admin role, the "Add" and "Delete" button is visible and
    functional.

    This patch fixes the above issue by updating the policy_target.

    Conflicts:
        openstack_dashboard/dashboards/admin/networks/ports/tests.py
        openstack_dashboard/dashboards/project/networks/ports/tests.py

    Change-Id: Ia7db6c2881c72580a156eb97b11bb51f295cfbce
    Closes-Bug: #1794421
    (cherry picked from commit 87b57dfe7113da09715d5613ab9c91c15a75c189)

Reviewed: https://review.opendev.org/684862
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=78574736a52656c6d9fba92634bf58e0ad03915a
Submitter: Zuul
Branch: stable/stein

commit 78574736a52656c6d9fba92634bf58e0ad03915a
Author: Shilpa Devharakar <email address hidden>
Date: Thu Aug 22 14:29:41 2019 +0530

    Add Allowed Address Pair/Delete buttons are only visible to admin

    Initially In Queens, when logging into Horizon in context
    of a _member_ in any project, the "Add Allowed Address Pair"
    and "Delete" buttons in "Network" -> "Networks" ->
    <select a network> -> "Ports" -> <select a port> ->
    "Allowed Address Pairs" are not visible.

    When accessing the same panel in context of a project where the user
    has the admin role, the "Add" and "Delete" button is visible and
    functional.

    This patch fixes the above issue by updating the policy_target.

    Change-Id: Ia7db6c2881c72580a156eb97b11bb51f295cfbce
    Closes-Bug: #1794421
    (cherry picked from commit 87b57dfe7113da09715d5613ab9c91c15a75c189)

This issue was fixed in the openstack/horizon 13.0.3 release.

This issue was fixed in the openstack/horizon 14.0.4 release.

This issue was fixed in the openstack/horizon 15.1.1 release.