widelands

error loading empire scenario 4

Bug #1784151 reported by luke
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
widelands
Fix Released
High
Unassigned
widelands build20-rc1

Bug Description

OS: Ubuntu 18.04.1
Widelands version: 19 (daily build installed from ppa:widelands-dev)
Widelands build: bzr8769-201807280716

Loading the new Empire scenario fails and produces the following error (also shown in attached screenshot). All other scenarios load fine.

program work: unknown command type "sound/empire beerbubble 180" in production program "work" for building "empire_brewery1"
stack traceback:
[string "scripting/tribes/brewery1.lua"]:3: in main chunk
[C]: in global 'include'
[string "campaigns/emp04.wmf/scripting/tribes/init.lua..."]:11: in local 'func'
[string "scripti

Tags: lua regression

Related branches

lp://staging/~widelands-dev/widelands/bug_1784151_fix_emp04_due_to_changed_program_names
hessenfarmer: Approve
GunChleoc: Approve
Diff: 218 lines (+29/-29)
8 files modified
data/campaigns/emp04.wmf/scripting/tribes/brewery1.lua (+1/-1)
data/campaigns/emp04.wmf/scripting/tribes/farm1.lua (+6/-6)
data/campaigns/emp04.wmf/scripting/tribes/foresters_house1.lua (+1/-1)
data/campaigns/emp04.wmf/scripting/tribes/foresters_house2.lua (+1/-1)
data/campaigns/emp04.wmf/scripting/tribes/lumberjacks_house1.lua (+1/-1)
data/campaigns/emp04.wmf/scripting/tribes/lumberjacks_house2.lua (+1/-1)
data/campaigns/emp04.wmf/scripting/tribes/mill1.lua (+1/-1)
data/campaigns/emp04.wmf/scripting/tribes/trainingcamp1.lua (+17/-17)
Revision history for this message
luke (luketudge) wrote :
ypopezios (ypopezios)
Changed in widelands:
status: New → Confirmed
importance: Undecided → High
tags: added: lua regression
Changed in widelands:
milestone: none → build20-rc1
Revision history for this message
kaputtnik (franku) wrote :

This a follow up from https://bazaar.launchpad.net/~widelands-dev/widelands/trunk/revision/8749

Looks like the entries in the scenario were forgotton to change.

Changed in widelands:
assignee: nobody → kaputtnik (franku)
Revision history for this message
hessenfarmer (stephan-lutz) wrote :

Thanks for the changes in the scenarios buildings. However it was intentional to have 2 Harvest cycles and no plant cycle for the sceanrios farm type. (this ensures a 0% productivity)

Revision history for this message
kaputtnik (franku) wrote :

I am not sure what you are referring to. May i do not understand those programs :-D All i did was to change the program names.

Feel to change it to fit your needs and make the merge proposal then.

Revision history for this message
hessenfarmer (stephan-lutz) wrote :

I am referring to

https://bazaar.launchpad.net/~widelands-dev/widelands/bug_1784151_fix_emp04_due_to_changed_program_names/view/head:/data/campaigns/emp04.wmf/scripting/tribes/farm1.lua#L51

this line needs to read
"callworker=harvest" a
although it is in the plant program of the farm. This is intentional to prevent the special building from working.

All other changes are fine and seem to be complete. Again thanks for doing it. (I saw the bug too late otherwise I would have done it by myself)

Revision history for this message
kaputtnik (franku) wrote :

Ah, thanks for clarifying :-)

The merge proposal is done now.

Revision history for this message
kaputtnik (franku) wrote :

This is fixed in revision 8773.

Changed in widelands:
status: Confirmed → Fix Committed
assignee: kaputtnik (franku) → nobody
Revision history for this message
GunChleoc (gunchleoc) wrote :

Fixed in build20-rc1

Changed in widelands:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.