Correct T&C and privacy statement displays when not in "Strict privacy" mode

Bug #1758733 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
18.04
Fix Released
High
Robert Lyon
18.10
Fix Released
High
Robert Lyon

Bug Description

There are a few things we'll need to clean up for when you are not in strict privacy mode.

1. Configure site -> Site options -> General settings
"Registration agreement": When turned on, it shows the old radio buttons to agree to the T&C. These need to go and instead the site T&C and privacy statement shown as well as any institution T&C and privacy statement if the user signs up for an institution that has one or both set.

2. When "Registration agreement" is set to "No", the user should not be required to agree to the statements and they shouldn't be shown.

3. When "Strict privacy" is not turned on, a user (except for site admin) does not see any legal statement when clicking the "Legal" link in the footer as they haven't agreed to any statements. They should still see the statements but without any consent switches as they are not required to agree. This setting is still beneficial for sites that handle agreeing to T&C and PS separately.

When any of the statements are updated, the user should not be asked to consent to the changes, but they should just be displayed with the last updated date.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8717

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/8716

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8716
Committed: https://git.mahara.org/mahara/mahara/commit/929c65cbc4a9f2347517aa3877344affa595cd6c
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 929c65cbc4a9f2347517aa3877344affa595cd6c
Author: Robert Lyon <email address hidden>
Date: Mon Mar 26 12:09:27 2018 +1300

Bug 1758733: Registering when register agreement is true

We should only show the privacy/T&C confirm switches when either
strict privacy or registration agree to T&C is turned on

Otherwise show legal info without switches

behatnotneeded

Change-Id: I0184bbebc35e1f29020bcb46c0abcdd3cf3cb3be
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8746

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8746
Committed: https://git.mahara.org/mahara/mahara/commit/060d18c14248842038000bda87e1c97b489438c5
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.04_STABLE

commit 060d18c14248842038000bda87e1c97b489438c5
Author: Robert Lyon <email address hidden>
Date: Mon Mar 26 12:09:27 2018 +1300

Bug 1758733: Registering when register agreement is true

We should only show the privacy/T&C confirm switches when either
strict privacy or registration agree to T&C is turned on

Otherwise show legal info without switches

behatnotneeded

Change-Id: I0184bbebc35e1f29020bcb46c0abcdd3cf3cb3be
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 929c65cbc4a9f2347517aa3877344affa595cd6c)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8717
Committed: https://git.mahara.org/mahara/mahara/commit/c9209bcf9717fa012cd14299ca93e54ae88bfce4
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit c9209bcf9717fa012cd14299ca93e54ae88bfce4
Author: Robert Lyon <email address hidden>
Date: Mon Mar 26 13:24:07 2018 +1300

Bug 1758733: Allow non-admin to see correct legal page when logged in

behatnotneeded

Change-Id: I0da3f8a12d62ff5142974e0f068ddf591c75979d
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8747

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8747
Committed: https://git.mahara.org/mahara/mahara/commit/8aae65b73411cd2c0b478dae929caa1f0b8698b1
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.04_STABLE

commit 8aae65b73411cd2c0b478dae929caa1f0b8698b1
Author: Robert Lyon <email address hidden>
Date: Mon Mar 26 13:24:07 2018 +1300

Bug 1758733: Allow non-admin to see correct legal page when logged in

behatnotneeded

Change-Id: I0da3f8a12d62ff5142974e0f068ddf591c75979d
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c9209bcf9717fa012cd14299ca93e54ae88bfce4)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.